From patchwork Fri Jun 25 18:53:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 467301 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04F75C2B9F4 for ; Fri, 25 Jun 2021 18:53:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8BA961969 for ; Fri, 25 Jun 2021 18:53:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229878AbhFYS4D (ORCPT ); Fri, 25 Jun 2021 14:56:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229813AbhFYS4B (ORCPT ); Fri, 25 Jun 2021 14:56:01 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78F35C061574 for ; Fri, 25 Jun 2021 11:53:39 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id yy20so8845734ejb.6 for ; Fri, 25 Jun 2021 11:53:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CGD4nVR1UJSiFHCmez0Ep/hjXV7j45YJTpnFxgYmszE=; b=KiN979bxbufge6e/uBKT2ZSOFKuRf7Y9qK1d8GXk4Crnu5NFI5HopiLZ7d5rXMneOK HpRulPP9nTx5K+vzrGaFrF8rCksG6MktNXn5/RQkkKIEXT3SzcbHgHoowmMFHdhHJq6N 7S+CwiPafDVxN/ISSSqn9OqKYeZA5OzRxSbMJTtPg+khWkrCxqOHoB2t+RORXzjOEN4C qjjB9mi7MA4JR7hXlwDNULE4rZnkK/XDcp2+TSVjCKebGxoT6pFnNZDCZRvhgVqHmsxp HRpW1IXqvN/IZZNENoG+DXjB9VoH+0+ZRKKM1bY7iSl80Q4Tl7mhSOT5WeyBW3cgMUQD sSWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CGD4nVR1UJSiFHCmez0Ep/hjXV7j45YJTpnFxgYmszE=; b=DJb28brBpCZ2hmFt/zPEzmIyLE7aMYmKLXGXGNlYBjy3hXCn6ozxu5XKta3p/2T7q3 TF6oStXNfnDKtytvqZuHbdp6Z6UJPYX/KNjlpnv/ubPPdypx7dWHp3kZGTtWUAzGOaa0 uvjMHBmTlSroz0W1MyhJnv8UAz163AKKOJlVWXL5/jkrTnYnbMcsF/a1eFQeLJKFRl/S PfxBqqT3I1D5xyIib1rSLt8t2WUljKh+SqS3fIxREnBGif6+mssIqw5X1e2ezrZiqbUT xGnpfiVqBnJQ+Ffxw1ElNPfLxt88tAiWKN7TF3Z7dHDb0IILy48lNSmFq4VPRZiiOawm e7OQ== X-Gm-Message-State: AOAM531yIilJOonVJ9u4G3C0D1S9XQuiw4aUIiblRK4QX01lKVnjYGlQ ob2ExrPJwDvvZHc/zMDEXK8= X-Google-Smtp-Source: ABdhPJwRNAUCT29DxOECRWTGFaHgCdc6iPHqRn7UPzMUGacrgYJ1ecy/MWjaWgkwB6p7RIdQbjA/tA== X-Received: by 2002:a17:906:c2d9:: with SMTP id ch25mr12558565ejb.127.1624647218100; Fri, 25 Jun 2021 11:53:38 -0700 (PDT) Received: from localhost.localdomain ([188.26.224.68]) by smtp.gmail.com with ESMTPSA id w2sm3094954ejn.118.2021.06.25.11.53.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jun 2021 11:53:37 -0700 (PDT) From: Vladimir Oltean To: Jakub Kicinski , "David S. Miller" , netdev@vger.kernel.org Cc: Florian Fainelli , Andrew Lunn , Vivien Didelot , Tobias Waldekranz , Jiri Pirko , Ido Schimmel , Roopa Prabhu , Nikolay Aleksandrov , Vladimir Oltean Subject: [PATCH net-next 2/7] net: ocelot: delete call to br_fdb_replay Date: Fri, 25 Jun 2021 21:53:16 +0300 Message-Id: <20210625185321.626325-3-olteanv@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210625185321.626325-1-olteanv@gmail.com> References: <20210625185321.626325-1-olteanv@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vladimir Oltean Not using this driver, I did not realize it doesn't react to SWITCHDEV_FDB_{ADD,DEL}_TO_DEVICE notifications, but it implements just the bridge bypass operations (.ndo_fdb_{add,del}). So the call to br_fdb_replay just produces notifications that are ignored, delete it for now. Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli --- drivers/net/ethernet/mscc/ocelot_net.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/mscc/ocelot_net.c b/drivers/net/ethernet/mscc/ocelot_net.c index aad33d22c33f..4fc74ee4aaab 100644 --- a/drivers/net/ethernet/mscc/ocelot_net.c +++ b/drivers/net/ethernet/mscc/ocelot_net.c @@ -1165,10 +1165,6 @@ static int ocelot_switchdev_sync(struct ocelot *ocelot, int port, if (err && err != -EOPNOTSUPP) return err; - err = br_fdb_replay(bridge_dev, brport_dev, &ocelot_switchdev_nb); - if (err) - return err; - err = br_vlan_replay(bridge_dev, brport_dev, &ocelot_switchdev_blocking_nb, extack); if (err && err != -EOPNOTSUPP)