From patchwork Mon Jun 7 16:53:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Nguyen X-Patchwork-Id: 455313 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp2907677jae; Mon, 7 Jun 2021 09:51:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwWCppOAyGA5BKK793pkvFg7vqBdQDGSm+VqHgGDrZn+0SJ2qNIzqO0qAfgnwtfN6hRat0n X-Received: by 2002:a17:907:101c:: with SMTP id ox28mr18998196ejb.322.1623084712313; Mon, 07 Jun 2021 09:51:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623084712; cv=none; d=google.com; s=arc-20160816; b=ve9uKR4cCEC5j8hVQujUlC3oVFONeoIe174Jit8skQzgatTr6dMlmukXCaGW2vUpyx PSb39KlKAlWihmUK/toVVgeW4ZinaOvER8XLHJN6tiHRa+QXay+KPOnTCVFV61VEgWX0 GcPdf5kDxi/o8XnXxH6LrBlfqNAepDbKyf/rFpUZsNmASXsi3qUJukdwEuZGsQJFHlGo zANZzfgVSF1B3eVXZQHmbFFYeHPumGzKrJmCg6y0yX83HKd43uqgx2Lhtw23J4cUWyyM Y21JHSA0edCyCNEswIaUeY5NHkvUnEbcNRm3zyM2Coa5gDUJenecD7VzgwLOVVj8RocP EiaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=BQnGpkwZCOVCssV7N4z9cI+oIJdGKPEwfJVtNBNCz58=; b=bl5VsPLB3VV+AydtdcbQAbhhX3O6F8UqJqrJ0ObQ5j1An1s1LJEW+Ty3OMGOr1pf4V C8DknRW0aMpksqIyEwwJ5bArb0TLVYVSlwxBRICjRmHVf90V5jJjdNN95wHWuuZOdAe/ zkkTorvTGEgEE+U1/DwypE+yVfKDWIQmmEoTDgsK9i00pBkBKAIYQtOUyjOw5vAU+61i DXp0e3PmvQZ/ggQKO95Vz7ipumMTuxU+DYbCPDLwJ/RWhUOsReOVXWdZbbNs+oQ+s4/G pXR9bD7ErFaxTu7b1sd7//qCl4XgsvG1t/C/eTQEskMD8wucYBdw6bqIHtA6BLIiJ1Th Hu4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s25si12554954ejq.289.2021.06.07.09.51.52; Mon, 07 Jun 2021 09:51:52 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231231AbhFGQwx (ORCPT + 8 others); Mon, 7 Jun 2021 12:52:53 -0400 Received: from mga14.intel.com ([192.55.52.115]:57113 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230331AbhFGQwq (ORCPT ); Mon, 7 Jun 2021 12:52:46 -0400 IronPort-SDR: xZ36wEq0FfxjN7DK8u0NG7lkGBLZKmzFtSUmFp3EoNPPjJ2xFjTtjZG12z4h2s0o1Z6fvQEJT2 cJ6t9YS+nAqQ== X-IronPort-AV: E=McAfee;i="6200,9189,10008"; a="204474554" X-IronPort-AV: E=Sophos;i="5.83,255,1616482800"; d="scan'208";a="204474554" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2021 09:50:54 -0700 IronPort-SDR: W5hjySMyy/98lhAPQ661SY86ThiA2wmWWTokld7Z1OSwkf5+PEsCVf3QI02s26j5rsBNHlby0t IkLcSIgY8Kcg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,255,1616482800"; d="scan'208";a="484841243" Received: from anguy11-desk2.jf.intel.com ([10.166.244.147]) by fmsmga002.fm.intel.com with ESMTP; 07 Jun 2021 09:50:54 -0700 From: Tony Nguyen To: davem@davemloft.net, kuba@kernel.org Cc: Salil Mehta , netdev@vger.kernel.org, sassmann@redhat.com, anthony.l.nguyen@intel.com, Tony Brelinski Subject: [PATCH net-next 07/15] ice: Re-organizes reqstd/avail {R, T}XQ check/code for efficiency Date: Mon, 7 Jun 2021 09:53:17 -0700 Message-Id: <20210607165325.182087-8-anthony.l.nguyen@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210607165325.182087-1-anthony.l.nguyen@intel.com> References: <20210607165325.182087-1-anthony.l.nguyen@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Salil Mehta If user has explicitly requested the number of {R,T}XQs, then it is unnecessary to get the count of already available {R,T}XQs from the PF avail_{r,t}xqs bitmap. This value will get overridden by user specified value in any case. Re-organize this code for improving the flow, readability and efficiency. This scope of improvement was found during the review of the ICE driver code. Fixes: 87324e747fde ("ice: Implement ethtool ops for channels") Tested-by: Tony Brelinski Signed-off-by: Salil Mehta Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_lib.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) -- 2.26.2 diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c index 135c4d9fd01c..357c5d39913d 100644 --- a/drivers/net/ethernet/intel/ice/ice_lib.c +++ b/drivers/net/ethernet/intel/ice/ice_lib.c @@ -163,12 +163,13 @@ static void ice_vsi_set_num_qs(struct ice_vsi *vsi, u16 vf_id) switch (vsi->type) { case ICE_VSI_PF: - vsi->alloc_txq = min3(pf->num_lan_msix, - ice_get_avail_txq_count(pf), - (u16)num_online_cpus()); if (vsi->req_txq) { vsi->alloc_txq = vsi->req_txq; vsi->num_txq = vsi->req_txq; + } else { + vsi->alloc_txq = min3(pf->num_lan_msix, + ice_get_avail_txq_count(pf), + (u16)num_online_cpus()); } pf->num_lan_tx = vsi->alloc_txq; @@ -177,12 +178,13 @@ static void ice_vsi_set_num_qs(struct ice_vsi *vsi, u16 vf_id) if (!test_bit(ICE_FLAG_RSS_ENA, pf->flags)) { vsi->alloc_rxq = 1; } else { - vsi->alloc_rxq = min3(pf->num_lan_msix, - ice_get_avail_rxq_count(pf), - (u16)num_online_cpus()); if (vsi->req_rxq) { vsi->alloc_rxq = vsi->req_rxq; vsi->num_rxq = vsi->req_rxq; + } else { + vsi->alloc_rxq = min3(pf->num_lan_msix, + ice_get_avail_rxq_count(pf), + (u16)num_online_cpus()); } }