From patchwork Fri Jun 4 15:17:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jason A. Donenfeld" X-Patchwork-Id: 454042 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp508357jae; Fri, 4 Jun 2021 08:18:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw+0EqU+fxMdigjW8KUyLPx5zlrAe7L5JVjOQ2IiUZkRSKx4IbhdWH8NIAzU0ACqNH4Exay X-Received: by 2002:a17:907:6288:: with SMTP id nd8mr4736032ejc.223.1622819929829; Fri, 04 Jun 2021 08:18:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622819929; cv=none; d=google.com; s=arc-20160816; b=b2k91CsccZV2ckqi7NRY/mwK/625hd5o14xMBO9iA/3vXNOeZKqD8dsFsSN+fRV483 xL17BWfWBkfPzoyI45X9yWyQ+zgt8TUdh5A4mh8HwCLq5CXjamEtU0AAN5a/jP9kgAYC L+ZR2DG8FTXdDSnPI75pUOp7VspjudJP8YRO5q7CP04O9LXtq4S7GLGSwjyicedm/4Zy 2t/AHtht02clU+AvgfAML0yXdmGTSXYgEcIpQwBsySNg2QEjf2MPaOq4OIoOP50ABbMt ZWfmuD758nCDLGoGBnap9JkVFZrYiRtqN70bgRCS51QeUF9yzvkRL8bM4WT8WULgUj3w rSUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=03qVuV/z5QIT1sBJaboojuxrUS02tPyZze9WNKWgRyc=; b=G9F5T0UQw93BkLzRinc3ZDA72lcLSbgsf9e9viSIT9zvMZAWDrDO4ezLCvALCCNpgM SEjlQXQj1JF46NueJMWOI8lIZXyazoQ6sM1QPpOpREmCVxdtGIc9ok2dQUKovKF9P827 6DCDkRoor2N71BAomMIc7brNQC4zc6mtr2FDyEUynpGSBCRFyuMkHuiUnA7b0sKt4sHi p5r+uZItaEB9vq8xvkHYlZDKd/SxVAHAXShYOOnD83r9KDpqWLA+y4BQxZ0WsF7YB+8v vHLbzGvrAQpVz+Cd6Y/oBLlHVjQHBSyrSMBFcEJ3cz6Z7dA0IMbmmCBZFhwEIoj10UX/ mUwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=qHDJOl+2; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l15si4894987ejc.521.2021.06.04.08.18.49; Fri, 04 Jun 2021 08:18:49 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=qHDJOl+2; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230378AbhFDPTu (ORCPT + 8 others); Fri, 4 Jun 2021 11:19:50 -0400 Received: from mail.zx2c4.com ([104.131.123.232]:54916 "EHLO mail.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230173AbhFDPTs (ORCPT ); Fri, 4 Jun 2021 11:19:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1622819881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=03qVuV/z5QIT1sBJaboojuxrUS02tPyZze9WNKWgRyc=; b=qHDJOl+2DFRnTHLPWmLGtEk9LFtAH95XFfHLCT61pQ6AiX+wRpOOwKvcnKZNV3HMB0si5N AVyCny87O4Gju85rR5c7+nr10FMuzZYiso5SY5MnGd/HIsUSPUlmvppUMiSqMDDLCMCe8I 46F5mVKr4Qq6lciwbZY0q2aWzTTH6gU= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 9c8a12b9 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Fri, 4 Jun 2021 15:18:00 +0000 (UTC) From: "Jason A. Donenfeld" To: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org Cc: "Jason A. Donenfeld" , Linus Torvalds , stable@vger.kernel.org Subject: [PATCH net 3/9] wireguard: do not use -O3 Date: Fri, 4 Jun 2021 17:17:32 +0200 Message-Id: <20210604151738.220232-4-Jason@zx2c4.com> In-Reply-To: <20210604151738.220232-1-Jason@zx2c4.com> References: <20210604151738.220232-1-Jason@zx2c4.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Apparently, various versions of gcc have O3-related miscompiles. Looking at the difference between -O2 and -O3 for gcc 11 doesn't indicate miscompiles, but the difference also doesn't seem so significant for performance that it's worth risking. Link: https://lore.kernel.org/lkml/CAHk-=wjuoGyxDhAF8SsrTkN0-YfCx7E6jUN3ikC_tn2AKWTTsA@mail.gmail.com/ Link: https://lore.kernel.org/lkml/CAHmME9otB5Wwxp7H8bR_i2uH2esEMvoBMC8uEXBMH9p0q1s6Bw@mail.gmail.com/ Reported-by: Linus Torvalds Fixes: e7096c131e51 ("net: WireGuard secure network tunnel") Cc: stable@vger.kernel.org Signed-off-by: Jason A. Donenfeld --- drivers/net/wireguard/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.31.1 diff --git a/drivers/net/wireguard/Makefile b/drivers/net/wireguard/Makefile index fc52b2cb500b..dbe1f8514efc 100644 --- a/drivers/net/wireguard/Makefile +++ b/drivers/net/wireguard/Makefile @@ -1,5 +1,4 @@ -ccflags-y := -O3 -ccflags-y += -D'pr_fmt(fmt)=KBUILD_MODNAME ": " fmt' +ccflags-y := -D'pr_fmt(fmt)=KBUILD_MODNAME ": " fmt' ccflags-$(CONFIG_WIREGUARD_DEBUG) += -DDEBUG wireguard-y := main.o wireguard-y += noise.o