From patchwork Wed Jun 2 12:41:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 452502 Delivered-To: patch@linaro.org Received: by 2002:a02:c735:0:0:0:0:0 with SMTP id h21csp536146jao; Wed, 2 Jun 2021 05:43:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJysP/uDxwVtDICKEsIGsdusX1Cvi0a9etFFM63zYA7lzB0IVwngfPn30C3I5D0Ue0UmrSWQ X-Received: by 2002:a17:907:d92:: with SMTP id go18mr16338637ejc.317.1622637800045; Wed, 02 Jun 2021 05:43:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622637800; cv=none; d=google.com; s=arc-20160816; b=n5a4qqVP9BlHNoYBMTwwZNBgyAyFHxvbLu3OFXe3ad20IEpXPcmAbTZlosgQZ/4gsW hM41a/z+tfyIhaSaYlqitCbVyYUoHh4Tn6M5znT3LMi66ig4fqGQFEkkNejXV9gE/ile W7wf5qR/t6sgs0o9pSaQX6EHHmOlbGQ2hTFNqWhrYt/CrxdpdlJr9Jq/CJnMqu4qCBqR keeKWjKKzuC2Ouz1LK/T+cAM9fgNuTROp90/8oSAylBnuQriEO8F5LkMO1r9lrUBka/N gsu30nA14ZgTb6xJTfrU2X+skoC0Y++IT29SgfjivM8EVBuiXnCYChKCkf66mKlyYIjp fuPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ZomBGs4eHViKX0lomLvHZXS684AyWHKwDi/uxcM0kfk=; b=0p0CsMIBc2HAS6o2W8SCrZN7w67WLcAHQkY6jQPup/a5LFerwWlWq7i/+vvOlhdAUl HP1ZnrtpMPn5A8nNB7XWa8OwkPG4oL9fmJ8FPHdZs3aA69Yrn9abCkOBbgRfewZfjPb1 erhWZgIYoZvF4jG+diIT0I01tBcCh7jaIabyiAUC1VbJxmQ3+l9czxtRm04FlYzqdeIY 6P+dqF8fs/zIpHIxvOMZLGsB2OmXHprluDBl7ZSzxNAypJi972Gl9mm7RrlWU4YwmvNa 340SdGteXqN9IGWD192z0sBFeZHGJ0t2oaFmBgWPBJOjLO93YrhfIKKG6yWKwUUcvX+e ZAWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="X/OqE2o/"; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i29si2693173ejo.446.2021.06.02.05.43.19; Wed, 02 Jun 2021 05:43:20 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="X/OqE2o/"; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229907AbhFBMoY (ORCPT + 8 others); Wed, 2 Jun 2021 08:44:24 -0400 Received: from mail-io1-f46.google.com ([209.85.166.46]:42625 "EHLO mail-io1-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229850AbhFBMoU (ORCPT ); Wed, 2 Jun 2021 08:44:20 -0400 Received: by mail-io1-f46.google.com with SMTP id k22so2332453ioa.9 for ; Wed, 02 Jun 2021 05:42:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZomBGs4eHViKX0lomLvHZXS684AyWHKwDi/uxcM0kfk=; b=X/OqE2o/bDI7oS3yDQ3/ISNF9qRVnYqvKykmcyzPbDDb94BR02haXzQnwZGjreaWqf m/YnjyDqiop5o0bPRHxBOj0a9Tm4dkeHAWTM7Ob6c7HqQHRclsjFid7PrIBQKAc8tFL9 yU/gwEIYLrYo0GLzo/lEiiul37BCpn+8loGB5O8UhJ31f8Xin0fAOoehhaQlcL+c1koO utTUzEqwRZe5SpQs/YsVhnXQEamdOHEYZa3FM1rhpq7CeCiiJez72fZX2OrbkgrkztiC jgOLUCYqjwM8Z4iqFvWiCGryV6RmWhDFSkryaIt1INIWl5XceOEihUKH1dCdE8tGccr+ 5pqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZomBGs4eHViKX0lomLvHZXS684AyWHKwDi/uxcM0kfk=; b=TMIFcPhr67siJpFUfgpPAQg7rT+SQ1VVtB8GTcnTBuVAxWNSbaqbBViZxLLs9yoFP+ lDFBF65YB5sYiai65xEowqhStDAtSfbh8g4EHJ1PMptsE9Y4dhiq9b2T8AK7za/+Y6Pj uga38kxc0uECLlz32iCKxeO7vK7Bhgi7+YW8rNTfG0XdKjdSP60faWohSpG76hl8vaAY um8aV3Yphje/jbs7HHJs6aAqZp/n7uNOhkLojhYRT1bzKogpfRmvJJuIpAZg2mo0IX+/ vKAWLyLGgflzeBsxFxi1IGNV7YqPSChSyyBnY4Qm34dNv7OkCEZVwf0rCBqC6pYCv12L jNlQ== X-Gm-Message-State: AOAM530kW0XweQyAPgVxPBEA2mTEhCcCtFn4NqiU5N/55eUPbihsVwrd uXwsm5K3MrE3J73NOSC1Iuh1Qg== X-Received: by 2002:a5d:8501:: with SMTP id q1mr25531804ion.66.1622637697713; Wed, 02 Jun 2021 05:41:37 -0700 (PDT) Received: from presto.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id v18sm11087054iob.3.2021.06.02.05.41.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 05:41:37 -0700 (PDT) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: bjorn.andersson@linaro.org, evgreen@chromium.org, cpratapa@codeaurora.org, subashab@codeaurora.org, sharathv@codeaurora.org, elder@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 2/2] Revert "net: ipa: disable checksum offload for IPA v4.5+" Date: Wed, 2 Jun 2021 07:41:31 -0500 Message-Id: <20210602124131.298325-3-elder@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210602124131.298325-1-elder@linaro.org> References: <20210602124131.298325-1-elder@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This reverts commit c88c34fcf8f501d588c0a999aa7e51e18552c5f0. The RMNet driver now supports inline checksum offload. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_endpoint.c | 16 ---------------- 1 file changed, 16 deletions(-) -- 2.27.0 diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c index 03719fb6a15a4..07a81b73306fe 100644 --- a/drivers/net/ipa/ipa_endpoint.c +++ b/drivers/net/ipa/ipa_endpoint.c @@ -88,11 +88,6 @@ static bool ipa_endpoint_data_valid_one(struct ipa *ipa, u32 count, if (ipa_gsi_endpoint_data_empty(data)) return true; - /* IPA v4.5+ uses checksum offload, not yet supported by RMNet */ - if (ipa->version >= IPA_VERSION_4_5) - if (data->endpoint.config.checksum) - return false; - if (!data->toward_ipa) { if (data->endpoint.filter_support) { dev_err(dev, "filtering not supported for " @@ -235,17 +230,6 @@ static bool ipa_endpoint_data_valid(struct ipa *ipa, u32 count, static bool ipa_endpoint_data_valid(struct ipa *ipa, u32 count, const struct ipa_gsi_endpoint_data *data) { - const struct ipa_gsi_endpoint_data *dp = data; - enum ipa_endpoint_name name; - - if (ipa->version < IPA_VERSION_4_5) - return true; - - /* IPA v4.5+ uses checksum offload, not yet supported by RMNet */ - for (name = 0; name < count; name++, dp++) - if (data->endpoint.config.checksum) - return false; - return true; }