From patchwork Thu May 27 18:56:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saeed Mahameed X-Patchwork-Id: 449318 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 042EEC47089 for ; Thu, 27 May 2021 18:57:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DEE92610C7 for ; Thu, 27 May 2021 18:57:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236166AbhE0S6f (ORCPT ); Thu, 27 May 2021 14:58:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:60096 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235958AbhE0S6O (ORCPT ); Thu, 27 May 2021 14:58:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9AED8610C7; Thu, 27 May 2021 18:56:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622141800; bh=CSQasfwmKg2NPJe8IFW2daWcYTYHC5GI9DF3P7UvjhY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Nr8+JfDfcqUdIXL5eCfrspaiVkWl8+chSYyD3awAtzMEp4nJfZJip+S8s2lcuH+n7 CWC1DF9VYKuCgkfu7CO3vwnXUOnNWHoQhy/+Q56bLJrRmufPRNWsLK9UMj7ZtX8yzs YRGEJqSOBj6po8rkT9rAs8f4+nmsNDG6/87zOh4UUkoAZtyloTZuirCZldpXVTsQyD dpXbS55dN/bnoj8gLvV+J7YeNLNTIBwpgmcrLrN3JrypJYOxLxB6szZ4OKgXDN2MdH GNRoXmBA1iueSyssIfkS9TWnHWI4bYop9ocCBHW1teQmYbNcLr/ueFYW1oFDycXXx2 IDtYjDfevq2BQ== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Tariq Toukan , Eli Cohen , Saeed Mahameed Subject: [net-next V2 13/15] net/mlx5: Remove unnecessary spin lock protection Date: Thu, 27 May 2021 11:56:22 -0700 Message-Id: <20210527185624.694304-14-saeed@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210527185624.694304-1-saeed@kernel.org> References: <20210527185624.694304-1-saeed@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eli Cohen Taking lag_lock to access ldev->tracker is meaningless in the context of do_bond() and mlx5_lag_netdev_event(). Signed-off-by: Eli Cohen Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/lag.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag.c b/drivers/net/ethernet/mellanox/mlx5/core/lag.c index b8748390335f..c9c00163d918 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lag.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag.c @@ -280,9 +280,7 @@ static void mlx5_do_bond(struct mlx5_lag *ldev) if (!mlx5_lag_is_ready(ldev)) return; - spin_lock(&lag_lock); tracker = ldev->tracker; - spin_unlock(&lag_lock); do_bond = tracker.is_bonded && mlx5_lag_check_prereq(ldev); @@ -481,9 +479,7 @@ static int mlx5_lag_netdev_event(struct notifier_block *this, break; } - spin_lock(&lag_lock); ldev->tracker = tracker; - spin_unlock(&lag_lock); if (changed) mlx5_queue_bond_work(ldev, 0);