From patchwork Sat May 15 22:13:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 439454 Delivered-To: patch@linaro.org Received: by 2002:a02:b78d:0:0:0:0:0 with SMTP id f13csp1437362jam; Sat, 15 May 2021 15:14:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdeUQbCW8Tk5spD2BW60rjKgVLRz6sS4xOwyeJpcxnu+H9/ABLJo/02csi1vA2yJ8N5uEh X-Received: by 2002:a5d:9ac7:: with SMTP id x7mr39440946ion.181.1621116897174; Sat, 15 May 2021 15:14:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621116897; cv=none; d=google.com; s=arc-20160816; b=qcA8i8vvq6G6IJay8tbC4Q0lDNTvuXteqlHJFG00ylsFH+clnbVwFFl6y+G0Q1WyTL Aa7zuqGmyRv3zCgjTYoghkFXYad640TgE75wmTgsaL40lSZQcfbOwZcdVFubycvtMhVr oq+FR4MPARduGEImNBUvr82ZIecUBpwM/zUdKcr4+SmUdKZK/xkBHOuRBAmLYEjmr4rG u9R0K1f5ACkg/A70mdl+Sq0dw+VB/rQWdRIVUwyGxJ8HRK7AoF0NnQQO8XYKX4Rti2UT zJ6WJvGJibh3RyjqZeVe6M3veWdkzS0Y+QWbUtRnobIrD6rUSukO+Vvqb9qVN+fiELLW CwfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=sCwcVuf3wodkv1sdVxy9knCCi90ACPARY0sY0aACsDk=; b=JYbMDFC0cX2pEoXClqNgIJpXv+unoLmt64T9LVxS2O5rGaK5CCBmZaM+XDmqEShB2n y3AFLz87XjdHpYYYmqWlElnY/uCMT8PhyyfQY8MYtCXf0F9KcGJtbmo3XiZzFa3d/kgW Ix6T4QNyhBIE2KWIHQWNrTo8hS8M6HNZmW8o78SWHabx2rPQUW3cbt29zPwBEtRV0IgO 71H6idPlgBNoLPS1EU8FCV5wmgHW8R8jm1OJME/qFQm0Rh4h/Mwim2hQDZw+/kl0WXCa 3wHNJNBkqY8bv+8cvkmUON/fCtwSlNv7WNHy1ddOIWpcQXnLuqtejwymqVUxrCYkuEi9 e9cw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IlFvjeb8; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n6si13185172jal.41.2021.05.15.15.14.56; Sat, 15 May 2021 15:14:57 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IlFvjeb8; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235269AbhEOWQE (ORCPT + 8 others); Sat, 15 May 2021 18:16:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:46862 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235225AbhEOWPw (ORCPT ); Sat, 15 May 2021 18:15:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CAD6760C3F; Sat, 15 May 2021 22:14:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621116879; bh=TnmI0Tt4l/vUEyEMDzwuUMGskOueZuQukAa7BRBP30s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IlFvjeb80LSGhLHhUUIaR2AXtzOXHignio44xj4m1q0sbRLQFOgeGN/rqT9pB0xDL QJ7K6C0MRZ5WupMlDlvHWHTZY8siuDkBUOH4rXjWe/KX9X63LibajFaVLZB3+ZRajd Pr91oPsxIOuwknHIxjPD7cnQ/XFmeEAa0c2ZpVx0BD6WJDGCqwUM+csBulslf7Lr+a 1dzJoFLZJmki8YJSX4y344Fhk1lubir/ApATQWPSKKxqmX6YW7nEXyfLFnShy59RU7 9N01cC/Nhoj+J+3C0RGPXxOZVo3oXrTrGpKSdVTwtCbomgL8zENFZ4jkCFp4c5nMWB wp81HbLvkANQQ== From: Arnd Bergmann To: netdev@vger.kernel.org Cc: Arnd Bergmann , Paul Gortmaker , "Maciej W. Rozycki" , "David S. Miller" , Jakub Kicinski , Doug Berger , Florian Fainelli , Sam Creasey , Geert Uytterhoeven , Finn Thain , Christophe JAILLET , Andrew Lunn , Alexei Starovoitov , Eric Dumazet , Andrii Nakryiko , Bartosz Golaszewski , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Subject: [RFC 03/13] [net-next] appletalk: ltpc: remove static probing Date: Sun, 16 May 2021 00:13:10 +0200 Message-Id: <20210515221320.1255291-4-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210515221320.1255291-1-arnd@kernel.org> References: <20210515221320.1255291-1-arnd@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Arnd Bergmann This driver never relies on the netdev_boot_setup_check() to get its configuration, so it can just as well do its own probing all the time. Signed-off-by: Arnd Bergmann --- drivers/net/Space.c | 3 --- drivers/net/appletalk/ltpc.c | 7 ++----- include/net/Space.h | 1 - 3 files changed, 2 insertions(+), 9 deletions(-) -- 2.29.2 diff --git a/drivers/net/Space.c b/drivers/net/Space.c index df79e7370bcc..9196a26615cc 100644 --- a/drivers/net/Space.c +++ b/drivers/net/Space.c @@ -142,9 +142,6 @@ static int __init net_olddevs_init(void) cops_probe(1); cops_probe(2); #endif -#ifdef CONFIG_LTPC - ltpc_probe(); -#endif return 0; } diff --git a/drivers/net/appletalk/ltpc.c b/drivers/net/appletalk/ltpc.c index c6f73aa3700c..9e7d3c686561 100644 --- a/drivers/net/appletalk/ltpc.c +++ b/drivers/net/appletalk/ltpc.c @@ -1013,7 +1013,7 @@ static const struct net_device_ops ltpc_netdev = { .ndo_set_rx_mode = set_multicast_list, }; -struct net_device * __init ltpc_probe(void) +static struct net_device * __init ltpc_probe(void) { struct net_device *dev; int err = -ENOMEM; @@ -1219,12 +1219,10 @@ static int __init ltpc_setup(char *str) } __setup("ltpc=", ltpc_setup); -#endif /* MODULE */ +#endif static struct net_device *dev_ltpc; -#ifdef MODULE - MODULE_LICENSE("GPL"); module_param(debug, int, 0); module_param_hw(io, int, ioport, 0); @@ -1242,7 +1240,6 @@ static int __init ltpc_module_init(void) return PTR_ERR_OR_ZERO(dev_ltpc); } module_init(ltpc_module_init); -#endif static void __exit ltpc_cleanup(void) { diff --git a/include/net/Space.h b/include/net/Space.h index 9cce0d80d37a..e30e7a70ea99 100644 --- a/include/net/Space.h +++ b/include/net/Space.h @@ -21,7 +21,6 @@ struct net_device *mvme147lance_probe(int unit); struct net_device *tc515_probe(int unit); struct net_device *lance_probe(int unit); struct net_device *cops_probe(int unit); -struct net_device *ltpc_probe(void); /* Fibre Channel adapters */ int iph5526_probe(struct net_device *dev);