From patchwork Sat May 8 06:25:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhen Lei X-Patchwork-Id: 432598 Delivered-To: patch@linaro.org Received: by 2002:a02:c901:0:0:0:0:0 with SMTP id t1csp990078jao; Fri, 7 May 2021 23:25:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJqdeCLkrBRhOo1SKivXz64sYTE7JrZErtcdy+ajscUbMUpjQZqtvA81V2BqCKRS10+3zT X-Received: by 2002:aa7:d996:: with SMTP id u22mr16455340eds.342.1620455152731; Fri, 07 May 2021 23:25:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620455152; cv=none; d=google.com; s=arc-20160816; b=h+jwknPmGZKXN0A/3eafPiB8g5OGuQeWxM0rIMIEiqkLEwqjrNXo+7///ALsIaiuyu vE1PyBdlqWT/STphWwSlZg32I/8L2Q5TuXN37MtXQ6/sVRrAtwevmj8aonmKhnup9+vQ k0piTWwHGUJCtZItcqwmMZ/NorJYBD6tB6XBiHuKH/cAQbjrLJ0KfInHr7f6CdXTRQv6 tRqlKv3U7oQsWxLsY38tORgYMfWJmCJN4PxaOv2y7CdpbiLTTofRe2HfOpAI/9KXYQ6u 5F/hXZF+7dKPsu2Srfj3QrMetD6dJOvwEpUqlhBIcS8pY8MLvLPtQa3jWZr7bNgKNcSO /xNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=/WJtz2HZJL0SWy3SK6S9umSZNpiadkwbF7W5KIm1W1g=; b=u8eE4O06DoraNmmwpMj9RYEJ/KZK4e2vlOX/qae/P+2Y5MQyoEBgVOFPyh/5alrWra qp7yTAct0JH0QINUkhDAF3Hv/JX32drpiy1uOu8SziUpQsc3oacop3AW6iEDyKnsFS43 7kE1TypqJXu86COoO2LHkEG3OwBJcH+K0ngeG+1lLwIxcz5feAOy0WIXSrRcH12ljXn9 8GeqngAiH7nzW/ypfcxy7gfeQ+vtKqQaz7X7shgAGwoK3bhX0p2xS72o8tm+Votp+O5I Yqi3whpFm1ykTT1JB6uSpzLQPNC3cX7hVAinMcSdabFPnpqGsH2GXgI3BV4mUPEDGKF5 ZQEQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k26si6740154edr.261.2021.05.07.23.25.52; Fri, 07 May 2021 23:25:52 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229925AbhEHG0m (ORCPT + 8 others); Sat, 8 May 2021 02:26:42 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:18013 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229760AbhEHG0k (ORCPT ); Sat, 8 May 2021 02:26:40 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Fccfz5WVBzQjFm; Sat, 8 May 2021 14:22:19 +0800 (CST) Received: from thunder-town.china.huawei.com (10.174.177.72) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Sat, 8 May 2021 14:25:27 +0800 From: Zhen Lei To: Alexander Aring , Stefan Schmidt , "David S . Miller" , "Jakub Kicinski" , linux-wpan , netdev , linux-kernel CC: Zhen Lei Subject: [PATCH 1/1] ieee802154: fix error return code in ieee802154_add_iface() Date: Sat, 8 May 2021 14:25:17 +0800 Message-ID: <20210508062517.2574-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: be51da0f3e34 ("ieee802154: Stop using NLA_PUT*().") Reported-by: Hulk Robot Signed-off-by: Zhen Lei --- net/ieee802154/nl-phy.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/net/ieee802154/nl-phy.c b/net/ieee802154/nl-phy.c index 2cdc7e63fe17..88215b5c93aa 100644 --- a/net/ieee802154/nl-phy.c +++ b/net/ieee802154/nl-phy.c @@ -241,8 +241,10 @@ int ieee802154_add_iface(struct sk_buff *skb, struct genl_info *info) } if (nla_put_string(msg, IEEE802154_ATTR_PHY_NAME, wpan_phy_name(phy)) || - nla_put_string(msg, IEEE802154_ATTR_DEV_NAME, dev->name)) + nla_put_string(msg, IEEE802154_ATTR_DEV_NAME, dev->name)) { + rc = -EMSGSIZE; goto nla_put_failure; + } dev_put(dev); wpan_phy_put(phy);