From patchwork Mon Apr 5 18:15:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 415540 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A433C433B4 for ; Mon, 5 Apr 2021 18:15:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C1AF6613B4 for ; Mon, 5 Apr 2021 18:15:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234686AbhDESQC (ORCPT ); Mon, 5 Apr 2021 14:16:02 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:33086 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233928AbhDESP6 (ORCPT ); Mon, 5 Apr 2021 14:15:58 -0400 Received: from mail-wr1-f71.google.com ([209.85.221.71]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lTTlP-0004rO-01 for netdev@vger.kernel.org; Mon, 05 Apr 2021 18:15:51 +0000 Received: by mail-wr1-f71.google.com with SMTP id v8so2367955wrv.7 for ; Mon, 05 Apr 2021 11:15:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Z6sJlr0sCPS8MR/sKy7gMvD05Sd0WFk7r5Dv1ypQclI=; b=ZZhOPcIEXWgnaWmZjpE2p0fR4QiR0d+qsQNi3cNjMthZ7h7JcaIH4BVJ74oWdTxwAR ka9Avnwvoip0ddwz2g/XAt1W5GQDZp+mEYbOhf4T+bdLSriU2PAk5jLPP68LYSV3Oyy2 80k6fcVTQ928GgRuzur+QQU7oCsPWVuHOwxPBUzdmc28O4jViYIo6SHRRFVUaOC4jrHV +EWxLV2ortSAULiIEIwbbs860G50HkBudMrwnqsHFfkMP3eTYC/XoyJl75wIeeP4McKU pH4TX5pNuLJ3yidGACC8tNl8Apn8pSsnBpiksH9ThsxEhbFVMF85xYfBuFfcQximedsb BRhQ== X-Gm-Message-State: AOAM530OmVCm5YxSLWGLpdLsbt/qLNZdNa4GYrNT1oyojAt6eOegMMCE dPjYWxSQ5lUTU2f54C6Pj1rqPbwNDNKK/7DVxg8sgndt8vgFFvH3DCB2j16UcDUbFHNAWjfUW4g AumaQQdjtlNeePtg+Jn0EgstnPHX2EBKSYQ== X-Received: by 2002:a05:600c:3650:: with SMTP id y16mr337783wmq.182.1617646550716; Mon, 05 Apr 2021 11:15:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQNdtJzoVtUMXkbcFivyybLHuHwyECjDgnf8EE/AYCZedkLowO9BthVxx0DZWdYzaREY7GHg== X-Received: by 2002:a05:600c:3650:: with SMTP id y16mr337775wmq.182.1617646550615; Mon, 05 Apr 2021 11:15:50 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-192-147.adslplus.ch. [188.155.192.147]) by smtp.gmail.com with ESMTPSA id 4sm8151817wrf.5.2021.04.05.11.15.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Apr 2021 11:15:50 -0700 (PDT) From: Krzysztof Kozlowski To: Steve Glendinning , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH] net: smsc911x: skip acpi_device_id table when !CONFIG_ACPI Date: Mon, 5 Apr 2021 20:15:48 +0200 Message-Id: <20210405181548.52501-1-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver can match via multiple methods. Its acpi_device_id table is referenced via ACPI_PTR() so it will be unused for !CONFIG_ACPI builds: drivers/net/ethernet/smsc/smsc911x.c:2652:36: warning: ‘smsc911x_acpi_match’ defined but not used [-Wunused-const-variable=] Signed-off-by: Krzysztof Kozlowski --- drivers/net/ethernet/smsc/smsc911x.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c index 606c79de93a6..556a9790cdcf 100644 --- a/drivers/net/ethernet/smsc/smsc911x.c +++ b/drivers/net/ethernet/smsc/smsc911x.c @@ -2649,11 +2649,13 @@ static const struct of_device_id smsc911x_dt_ids[] = { MODULE_DEVICE_TABLE(of, smsc911x_dt_ids); #endif +#ifdef CONFIG_ACPI static const struct acpi_device_id smsc911x_acpi_match[] = { { "ARMH9118", 0 }, { } }; MODULE_DEVICE_TABLE(acpi, smsc911x_acpi_match); +#endif static struct platform_driver smsc911x_driver = { .probe = smsc911x_drv_probe,