From patchwork Tue Mar 23 21:52:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 406955 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp4812581jai; Tue, 23 Mar 2021 14:54:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkbzHdGASebEilO2DKEzAfCc0zhRKT3gRIxwKTEkTM4yoKwrr0KtIbCTy6CLDt7yfOB33N X-Received: by 2002:a17:906:4f02:: with SMTP id t2mr277584eju.121.1616536464520; Tue, 23 Mar 2021 14:54:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616536464; cv=none; d=google.com; s=arc-20160816; b=gkLr+ZU7L9Gxp4HC91jZIZlms4Ia24pLrV7BFC4j+/4GDYpoJ4ERLDtBWM71zDF8JH 8CFkwePDVfp810ZOSK85UPe2x5CtPYfx48xIVGKLnS9+x7c26a3m+1Vwzwm2ahb/5GFv nMTVbvNY7Y1hKfY3hTXETMxNYLfxFuqSDedFVnEQm7q75NRLaxtmw6fX9Eo7HCW+fH46 jXnsmXOhsnj+B8kPDYZHqff+G8C3Py7rSf37NvyOZk/DrjZ1HPLaMAu0rwQeoztasDAq eO5l+1/U3G8WAH/9PZjZWBmjiNA33awrta6zIX4tIuWgA8A/LBat5P4fPn0WMWkEHTwE JZHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=dBAMygc58ddVk6CchxVyzaWwQkDeBDiBz5rxobi56OQ=; b=BVr55nfGF07C3TaDkRuBGltW6iSqXbPtDTZTF5/xvpgU3Ho79WQHnEU+hQzMZ1OsGA gilXrM/GgW8Ywj8sXRzCWMOdDcrwTn6XHxbbzyWEBH9LD9DTU2dXN+hOaIHw9glrVXya CfsMuSF5egdnC4ZH9LrsnFcyo+pgFkKtCqEgrprnx2DW7IUPXpzZsDg42E89/sqSJCde Ry4QyUhTzGb6RufW+gR3Je3KfmARyz6HTFbsHFPYhN1CpMHuLQGhqtuD1I+Szarp7QH1 NG1WcVi1NKhmXCiUT3+ngpIk86Xn4NqZEF6P+eiB3S/SG2uzMB6TuL4oerqFPEXH0yF7 bMwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="oRbUi/3D"; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bt16si162402edb.440.2021.03.23.14.54.24; Tue, 23 Mar 2021 14:54:24 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="oRbUi/3D"; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233749AbhCWVx6 (ORCPT + 8 others); Tue, 23 Mar 2021 17:53:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:33930 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233748AbhCWVxH (ORCPT ); Tue, 23 Mar 2021 17:53:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 65016619B3; Tue, 23 Mar 2021 21:53:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616536386; bh=V2fb0UEzfZd0vcBsxcQi9LFzvRC/iqf0tbUqQZ9dIro=; h=From:To:Cc:Subject:Date:From; b=oRbUi/3D7F2htn4xL5TWxJs1pRdEvhBd+BHbFymNrH7HKx61Taw56BuNdC0qjratR 8X11eovz0s6pJJ8OODTqkilsd6xDMueZgnOP7ChpNTV1lPpVskpdKbJ5mXwTQFKPBI uom0UNPWxHr7udMNIlNABAmYE7jlm1aTpeYX8868lzY9zL5S4waCERlX43iDfwA7ow q0XJ8IA9FRD5On/WuW/rYP8FIBMNI4IddR6Bqx/0bkG6sIWffUlHbUGKGMh8/zqJXh qq+MqzT8LiCXOMbdqkJSNUhbAU77aX6GL1ScaiYMMVD6QHhSEZoNC13eEziy8MX1xr skBUlIC0Q5adA== From: Arnd Bergmann To: Ayush Sawal , Vinay Kumar Yadav , Rohit Maheshwari , "David S. Miller" , Jakub Kicinski Cc: Arnd Bergmann , Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next] [RESEND] ch_ktls: fix enum-conversion warning Date: Tue, 23 Mar 2021 22:52:50 +0100 Message-Id: <20210323215302.30944-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Arnd Bergmann gcc points out an incorrect enum assignment: drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c: In function 'chcr_ktls_cpl_set_tcb_rpl': drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c:684:22: warning: implicit conversion from 'enum ' to 'enum ch_ktls_open_state' [-Wenum-conversion] This appears harmless, and should apparently use 'CH_KTLS_OPEN_SUCCESS' instead of 'false', with the same value '0'. Fixes: efca3878a5fb ("ch_ktls: Issue if connection offload fails") Reviewed-by: Andrew Lunn Signed-off-by: Arnd Bergmann --- I sent this last October, but it never made it in, resending --- drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.29.2 diff --git a/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c b/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c index 46a809f2aeca..7c599195e256 100644 --- a/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c +++ b/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c @@ -722,7 +722,7 @@ static int chcr_ktls_cpl_set_tcb_rpl(struct adapter *adap, unsigned char *input) kvfree(tx_info); return 0; } - tx_info->open_state = false; + tx_info->open_state = CH_KTLS_OPEN_SUCCESS; spin_unlock(&tx_info->lock); complete(&tx_info->completion);