From patchwork Mon Mar 22 10:43:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 406093 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp3450732jai; Mon, 22 Mar 2021 03:44:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzja5kJBF2L+UNeZwFO/RwlHOVwu3Ff1pG7k57N1S8gQR2rxgcalZSJxOUgvne6Ksrzmi3m X-Received: by 2002:a17:907:e88:: with SMTP id ho8mr19084148ejc.199.1616409875808; Mon, 22 Mar 2021 03:44:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616409875; cv=none; d=google.com; s=arc-20160816; b=RWzN07aKRJbLONbOAampc3egyCjl07uszsvqzr8S35IgFOJWAfh22uao995TERBa7S FiijL8x5qhYc1MPcE4y1qz7AlwaKafF85qYAOcgkvL3kpLcXXBQzF10kCzJaZ7ARVlrS Zpne04/N9aDwy7pai4ToV43lTFGMLhR4Dr5BBfvgrCDGIx77PBhemR7oJwUM6P47sHBe 79IuBuwzanjOUK89fOBPZw+lCgGhLqItI0YQSps2UvIdln43bV9csCh7s8EmthM4YCKY AaMra+g/UUY2jRxf6tVIKGXSVf6SW2tdKaUmlKqhl1acAtKw8h8QSCc7rYkjSraEKDK9 qN8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=aTHIzl028yFNpPThPZWL94fdsuXbLtbFcP+eQRgR0rY=; b=kyP2wI3J5S1EQwgK6khDJ/tdMKqOjKhoXkng/D36EljUs1AZnWHZcfkSMcuKKhWd3Y Ppc9yWb8ySS25SRTomjJXqbVP5qTfoCTvdTLNXF37DdsCe8Utis/9PIDKjlwLmtplXSX mknwYy0N9jlXjMDs7JvKUHydTS0rvGe1L3tOrICevSuFdkX3rcDpx5FdeApEQTLvjrXf wV+Y2anL2LyNpwy2IywQRF8qjpudAO8MImNHpMX657EYiSWy4wUEkGfA2DKFpk5vU3R8 sVT/Q1E0ndUvE7nNwBBjee1qqj/ZO3US3GymJp/DZg8zeKNA6KKGFptLqp+IOfD0uMN4 ONrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RUleBEDQ; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p9si10760432edh.186.2021.03.22.03.44.35; Mon, 22 Mar 2021 03:44:35 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RUleBEDQ; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229986AbhCVKoH (ORCPT + 8 others); Mon, 22 Mar 2021 06:44:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:54950 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229904AbhCVKnr (ORCPT ); Mon, 22 Mar 2021 06:43:47 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4CAAE61931; Mon, 22 Mar 2021 10:43:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616409827; bh=h/7NZxyJTdtxn6ErvpBB/wUkK789lbNzLTv0zGToHNI=; h=From:To:Cc:Subject:Date:From; b=RUleBEDQbNtxr/XVMeTQB3bFCK8wL5IgFp+zAf7Q/XkDgePvbTFrcgBhLJExR6MtW 5XdFWaD5JoJggZfhMaGXXEfCVkR6bhNKl7pSlawtXNRKZAeTP1dGZcRLbS5L6eN8Br loJqlQU0voQMzCKUeVLClq9+NOXy2egCF3KsG8tluTHz1TKqWB5Mmck3HQd2pBQVcb GOGWLAQTXP3oK1HPQXiojKhO8bS00wVpFf3xUYpV54l0g3/vdoJLet7zrWqnH+puEd Ds6YbxCgvhLgeOaKd6N562W/lm+SAk40FXtzXvJYCETrq3aRwtG8g6lQgLlCQq0G5l 697DH6H7Y6Q5w== From: Arnd Bergmann To: netdev@vger.kernel.org, Karsten Keil Cc: Arnd Bergmann , linux-kernel@vger.kernel.org Subject: [PATCH net-next 1/5] misdn: avoid -Wempty-body warning Date: Mon, 22 Mar 2021 11:43:31 +0100 Message-Id: <20210322104343.948660-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Arnd Bergmann gcc warns about a pointless condition: drivers/isdn/hardware/mISDN/hfcmulti.c: In function 'hfcmulti_interrupt': drivers/isdn/hardware/mISDN/hfcmulti.c:2752:17: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] 2752 | ; /* external IRQ */ Change this as suggested by gcc, which also fits the style of the other conditions in this function. Signed-off-by: Arnd Bergmann --- drivers/isdn/hardware/mISDN/hfcmulti.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.29.2 Acked-by: Stanislaw Gruszka diff --git a/drivers/isdn/hardware/mISDN/hfcmulti.c b/drivers/isdn/hardware/mISDN/hfcmulti.c index 7013a3f08429..8ab0fde758d2 100644 --- a/drivers/isdn/hardware/mISDN/hfcmulti.c +++ b/drivers/isdn/hardware/mISDN/hfcmulti.c @@ -2748,8 +2748,9 @@ hfcmulti_interrupt(int intno, void *dev_id) if (hc->ctype != HFC_TYPE_E1) ph_state_irq(hc, r_irq_statech); } - if (status & V_EXT_IRQSTA) - ; /* external IRQ */ + if (status & V_EXT_IRQSTA) { + /* external IRQ */ + } if (status & V_LOST_STA) { /* LOST IRQ */ HFC_outb(hc, R_INC_RES_FIFO, V_RES_LOST); /* clear irq! */