From patchwork Sat Mar 6 03:15:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 394535 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp965458jai; Fri, 5 Mar 2021 19:17:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJxwCabqHSp3ZUu4Jm4Q0BKWQRcnS71tgYRurmft7NNGXaCHe1xApBa1hRewAMiiFknmV6n6 X-Received: by 2002:aa7:cf90:: with SMTP id z16mr12152307edx.273.1615000628551; Fri, 05 Mar 2021 19:17:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615000628; cv=none; d=google.com; s=arc-20160816; b=WFVO2wPVPrQ/HRYPVg1QpYJdJGfeU4zRvWUVCcaaBSMh9Gz6u8pcNkJc4NsBFqWT4S 3Cni8jHjCa5J7fKsh3tki+tJJEmm8f7IDx4UkN2rLYifRQgxT8JzPAY35f3nBs+VmyQm VLbMNbPS8Dh3+MsiYV9zqE0UVek8CyilyWC0dKwI3dvY4zihc6SYGiIc1WsWtCWokRkU +aNbyqQu3l0diYljNYFGUE71m/hG8ZdPbGybI688IYKxmE6ZDbHP5porvTPgZriMbIp5 5YWzububZ00rWaiqXGiTiYOiYUpTS4sIBKvbJ6L82nSZwTsPpHMpl8U9+9q39O+bWgzP 7f1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=siv8ALjvw5nAWM5oVnlAOXA/08MIyz7olXglWGx22ko=; b=r/4sbO58nfoVDX0XRum60AsTqb1GQAwR19ZJEXZqP+7eeOlb/7sLt/Jip1203pBh2L nH/RSZqhSoieP39WBiSnXUi8zeU/RMBZ6LX7wLh5/n3Nv5kaSAI+NnWW8Ah5Y05kpX6n uHm2lZGwgSDSn2HHSEjQOvtvk5EdduOjw8gQltEi9FA+B9qZiqXsJk3lLXG6HJSgydqZ igENifBLlYHuEMHk35uPSleLzQ/R1jyqc42PFCfa6Bw1yaapyiTaEIdOH0SsoqTPEtZK S58nzWWZwpggFyq0UTOifcF+a+ArTiJNVXT1P8SuInXIV05VWnIcV9tOk90musGBrblg JGRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VaG23pAj; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j7si2719448edh.201.2021.03.05.19.17.08; Fri, 05 Mar 2021 19:17:08 -0800 (PST) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VaG23pAj; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230087AbhCFDQf (ORCPT + 9 others); Fri, 5 Mar 2021 22:16:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229749AbhCFDP7 (ORCPT ); Fri, 5 Mar 2021 22:15:59 -0500 Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CB4CC061762 for ; Fri, 5 Mar 2021 19:15:56 -0800 (PST) Received: by mail-il1-x129.google.com with SMTP id d5so3856239iln.6 for ; Fri, 05 Mar 2021 19:15:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=siv8ALjvw5nAWM5oVnlAOXA/08MIyz7olXglWGx22ko=; b=VaG23pAj8JOs+CT9cgwwHYOa0+JEos2V4LSaNc5NiboFIMDa6NIW9Njr6Tic3vZQj+ ud1QGV7C0CUFhgk02O9V5sxvLl/z0WlZTFmlf3XSZSWP1al4lrQ19CtsK+hSNUQt9TwH wbLpSKexzyuafiBtRYNJ56LIR0XrwTjVoi0hL4h0rJBV47Tl/T5j9J4FLq6uRy/+tfv1 krPb9Tq36Ab2hg+kvq8h0gYWZlr2NibtRnil57rpD3fGeeZxDlqJNAYQ54NWFPiVKfe/ frZjcpfTVaga8Inw+np2mr/ngDYqMS4I+lT2MUxb3r/xtu8TA0M+s7rOXOFDzk/1AjJ0 bcQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=siv8ALjvw5nAWM5oVnlAOXA/08MIyz7olXglWGx22ko=; b=i5tbz+QtJOlzt/+r6AvClyCBFPOEwfo/yS6mTzhTgkTncygMTlBRUdZMhNOjLxXEW+ zwPHvd2dScdT2/InPVatlCpKw4v/XYCCUpYKEzoE9eEtoK961B0r51VQyLJPmXUWt8iO xyyFAeFkXY3NAhImCi5z5ndpGE2mgpchi9MHVw0CdYQ8Mpefig4SMO1eVQNiCtPX7QJY rf+BREW1zzdjVV0F0QhJIgTZ/3jqHOaF/NOhU0HzhuCp/bqvReqn+U8eBIQBW+68612Z xW9Adi7A2kmGSHrRXSn/TcrZK9vq2s+nkVygBnwmQ3YnqTRqK118vRkGrAjvVZyMnGx3 yQNQ== X-Gm-Message-State: AOAM5324o6dE1I50KnsOFlvRs4iXwPm7OuUBndfnPQJl2WQPEIVEJP0j I8bW/+UCqWMBdBr77BFjxXdZvQ== X-Received: by 2002:a92:c7c2:: with SMTP id g2mr11802891ilk.209.1615000555738; Fri, 05 Mar 2021 19:15:55 -0800 (PST) Received: from presto.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id i67sm2278693ioa.3.2021.03.05.19.15.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 19:15:55 -0800 (PST) From: Alex Elder To: subashab@codeaurora.org, stranche@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: sharathv@codeaurora.org, bjorn.andersson@linaro.org, evgreen@chromium.org, cpratapa@codeaurora.org, elder@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 1/6] net: qualcomm: rmnet: mark trailer field endianness Date: Fri, 5 Mar 2021 21:15:45 -0600 Message-Id: <20210306031550.26530-2-elder@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210306031550.26530-1-elder@linaro.org> References: <20210306031550.26530-1-elder@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The fields in the checksum trailer structure used for QMAP protocol RX packets are all big-endian format, so define them that way. It turns out these fields are never actually used by the RMNet code. The start offset is always assumed to be zero, and the length is taken from the other packet headers. So making these fields explicitly big endian has no effect on the behavior of the code. Signed-off-by: Alex Elder Reviewed-by: Bjorn Andersson --- include/linux/if_rmnet.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.27.0 diff --git a/include/linux/if_rmnet.h b/include/linux/if_rmnet.h index 9661416a9bb47..8c7845baf3837 100644 --- a/include/linux/if_rmnet.h +++ b/include/linux/if_rmnet.h @@ -32,8 +32,8 @@ struct rmnet_map_dl_csum_trailer { #else #error "Please fix " #endif - u16 csum_start_offset; - u16 csum_length; + __be16 csum_start_offset; + __be16 csum_length; __be16 csum_value; } __aligned(1);