From patchwork Mon Mar 1 13:32:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 388636 Delivered-To: patch@linaro.org Received: by 2002:a02:290e:0:0:0:0:0 with SMTP id p14csp3353258jap; Mon, 1 Mar 2021 05:34:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJzj0Bi30+XBAbKvUTHKaDDlaDVT4DXwhmEWIHw1oQUn+89OF7srg1LwebMnDO5roCHNR/cQ X-Received: by 2002:a17:906:3c0b:: with SMTP id h11mr16201118ejg.347.1614605696008; Mon, 01 Mar 2021 05:34:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614605696; cv=none; d=google.com; s=arc-20160816; b=Dc1mYBfPpZs5zW0CPIT0kgTMxsix5ccFgMpWWAmEz3LWfZ0TVexexDESM2GFczEjKT 86ONj69hHetnWivbmbazZfkkKIty/XhqGxzr126rrJk3DXdohS8iiZRxyL8T1sJa0/EJ EXZqzVRcARHqHQNPL3lelPFNk3J1+ZH41xsgJeooE6dx4NnzT/aHFu3Kaq7siPtvq2lf KVKrVe4Wx8LQlsUuqlNNKXDl8sVIc3MCFSka3gddNtpm96ZUxfzDLKFoPXxedZNAOOB2 rqObQVN9G5ucXMnB1gKa5A9M2yVvdbrXQPHOjZkG+wlxlTrIA/iYh1e9WRmTsZMgASkI QlOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=wQalGovUJHUxAGD0LzoropIg8ifJImgRXYB/UBdo/FM=; b=ZVdJ7/lSKIXNteviICIhnNUTJlwk534FEWkJws2/YxNAu3PeOkA5LoO9mxN5SGOLrs CV6BTRCk3ISAtKOTfo1QH5D8P+Xx6SYbzTG6u4LlgXtuP2771NuvZWYtQMqryU0fhXEn zcOQIrSOer54B1fffulAMK+zDc+HKItsB9hFjfKrINe7phbrjQWLCpd1WGxJb5l3s8fi OGLd6JF5INl3/IBcQV3vYPJ0HJPneAqTM46dAjO2RDdvhT58d6LRHUGPZLG457crWpuQ XOaMFED1KJ0ajtrlq1a2+wxiB+0LYoAquzNkUS2AoEL1EL9jyDuoFsg91JwEJl1nmt2P 0gLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EcfV03XO; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q15si11037053edd.127.2021.03.01.05.34.55; Mon, 01 Mar 2021 05:34:56 -0800 (PST) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EcfV03XO; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235780AbhCANel (ORCPT + 9 others); Mon, 1 Mar 2021 08:34:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235748AbhCANdb (ORCPT ); Mon, 1 Mar 2021 08:33:31 -0500 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23A20C06178A for ; Mon, 1 Mar 2021 05:32:51 -0800 (PST) Received: by mail-lj1-x230.google.com with SMTP id e2so12222428ljo.7 for ; Mon, 01 Mar 2021 05:32:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wQalGovUJHUxAGD0LzoropIg8ifJImgRXYB/UBdo/FM=; b=EcfV03XOGJFa9Su6i6rEg7ozmay2Y73SCwaXy9mUdFcf8VZB9iqoLYtxN1eJ0TZMyv GiIuYkz9/oeMG/srJECF6wVRcmfw2T7N7jg8MtFawuKNqscHpDP7gsl6JgXBl/k4s4Wi 0TugNsfm0WtHV7xLute+ltCZkoCPfuX5AxJuseCPTWO73hFfRV7h9/jCIh97tlRz8a23 fLlHUATlHqnuHUVVrCWkt5dSZa153HOQ/VK49Wjv1pFffmJtrt6P2HI2yyq1XerJKGs2 CqLC+JYqhzzYhhiUNKGXTXgUFCGONenhdiwhJBh8D2++tRe2wILIX2H1hwpJ/sk5bjgM 12VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wQalGovUJHUxAGD0LzoropIg8ifJImgRXYB/UBdo/FM=; b=B9iFO1DzOzAN9sVXIAl7kkF+Ap/mDD0bHYAKl9me+nHaDvHJ5TQU4vQX2p9ias3h+J 3tWE9lD25DQjb4HbqR4ZeSqf2p/ZJcXxf+mhEPVoAfJAaYGxsZTzjBy1esPb5KJpDqUH JRe4Cl4IsEOr8hs1JQ3SbIvJkeDjPa7YUbNM223Q+q7HR0iHixsEgZffENJnRsbvdSEd v84TCCSZJody+RDLKYOIjnZmte9SM0OOM3qZInsalVDQtFsywIW4QivraJ3Hm7wsQH7m hfvEhTBkNHdyv2YQ/5z0Ud+nsErIKqvW+sQeZDtThCpZXUlD4XOCwfvss456z/M3fPaS OxYw== X-Gm-Message-State: AOAM531cs8Woq54y3Phl4xSozUI9uqFRzMcpZTe5ZGzm3xYXP20bhqWc /iUgxAlAafSjN8MR6qOwJGNRMw== X-Received: by 2002:a2e:9b90:: with SMTP id z16mr9190897lji.71.1614605569686; Mon, 01 Mar 2021 05:32:49 -0800 (PST) Received: from localhost.localdomain (c-d7cb225c.014-348-6c756e10.bbcust.telenor.se. [92.34.203.215]) by smtp.gmail.com with ESMTPSA id c9sm2310066lft.144.2021.03.01.05.32.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Mar 2021 05:32:49 -0800 (PST) From: Linus Walleij To: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Linus Walleij , DENG Qingfang , Mauri Sandberg Subject: [PATCH net 3/3] net: dsa: rtl4_a: Syntax fixes Date: Mon, 1 Mar 2021 14:32:41 +0100 Message-Id: <20210301133241.1277164-3-linus.walleij@linaro.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210301133241.1277164-1-linus.walleij@linaro.org> References: <20210301133241.1277164-1-linus.walleij@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Some errors spotted in the initial patch: use reverse christmas tree for nice code looks and fix a spelling mistake. Reported-by: Andrew Lunn Reported-by: DENG Qingfang Cc: Mauri Sandberg Signed-off-by: Linus Walleij --- net/dsa/tag_rtl4_a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.29.2 Reviewed-by: Florian Fainelli diff --git a/net/dsa/tag_rtl4_a.c b/net/dsa/tag_rtl4_a.c index 8098d81f660b..9da56c5ea9dc 100644 --- a/net/dsa/tag_rtl4_a.c +++ b/net/dsa/tag_rtl4_a.c @@ -36,8 +36,8 @@ static struct sk_buff *rtl4a_tag_xmit(struct sk_buff *skb, { struct dsa_port *dp = dsa_slave_to_port(dev); u8 *tag; - u16 *p; u16 out; + u16 *p; /* Pad out to at least 60 bytes */ if (__skb_put_padto(skb, ETH_ZLEN, false)) @@ -55,7 +55,7 @@ static struct sk_buff *rtl4a_tag_xmit(struct sk_buff *skb, *p = htons(RTL4_A_ETHERTYPE); out = (RTL4_A_PROTOCOL_RTL8366RB << 12) | (2 << 8); - /* The lower bits is the port numer */ + /* The lower bits are the port numer */ out |= (u8)dp->index; p = (u16 *)(tag + 2); *p = htons(out);