diff mbox series

[1/3] net: mscc: ocelot: select NET_DEVLINK

Message ID 20210225143910.3964364-1-arnd@kernel.org
State New
Headers show
Series [1/3] net: mscc: ocelot: select NET_DEVLINK | expand

Commit Message

Arnd Bergmann Feb. 25, 2021, 2:38 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>


Without this option, the driver fails to link:

ld.lld: error: undefined symbol: devlink_sb_register
>>> referenced by ocelot_devlink.c

>>>               net/ethernet/mscc/ocelot_devlink.o:(ocelot_devlink_sb_register) in archive drivers/built-in.a

>>> referenced by ocelot_devlink.c

>>>               net/ethernet/mscc/ocelot_devlink.o:(ocelot_devlink_sb_register) in archive drivers/built-in.a


Fixes: f59fd9cab730 ("net: mscc: ocelot: configure watermarks using devlink-sb")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/net/ethernet/mscc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

-- 
2.29.2

Comments

Jakub Kicinski Feb. 26, 2021, 11:36 p.m. UTC | #1 
On Thu, 25 Feb 2021 15:38:31 +0100 Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>

> 

> Without this option, the driver fails to link:

> 

> ld.lld: error: undefined symbol: devlink_sb_register

>  [...]  

> 

> Fixes: f59fd9cab730 ("net: mscc: ocelot: configure watermarks using devlink-sb")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Applied patch 1 and 2, I'll take Qingfang's patch for mt7530, thanks!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/mscc/Kconfig b/drivers/net/ethernet/mscc/Kconfig
index c0ede0ca7115..05cb040c2677 100644
--- a/drivers/net/ethernet/mscc/Kconfig
+++ b/drivers/net/ethernet/mscc/Kconfig
@@ -13,6 +13,7 @@  if NET_VENDOR_MICROSEMI
 
 # Users should depend on NET_SWITCHDEV, HAS_IOMEM
 config MSCC_OCELOT_SWITCH_LIB
+	select NET_DEVLINK
 	select REGMAP_MMIO
 	select PACKING
 	select PHYLIB