From patchwork Wed Jan 13 22:36:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 363438 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4B57C4332D for ; Thu, 14 Jan 2021 02:03:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B4DF23447 for ; Thu, 14 Jan 2021 02:03:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729396AbhANCDp (ORCPT ); Wed, 13 Jan 2021 21:03:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729400AbhAMWiH (ORCPT ); Wed, 13 Jan 2021 17:38:07 -0500 Received: from mail-qt1-x849.google.com (mail-qt1-x849.google.com [IPv6:2607:f8b0:4864:20::849]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DE27C0617A2 for ; Wed, 13 Jan 2021 14:36:19 -0800 (PST) Received: by mail-qt1-x849.google.com with SMTP id b8so2666269qtr.18 for ; Wed, 13 Jan 2021 14:36:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=2NIQ1TwrG95rTm/28dxUdJZ491lS6fXAiyg3+rtP0i0=; b=KylcDwdWWUEUTJhqVOxgSNBrPPoATDupoPunfBGtoclQ6YJ4OUgN6vSg4nbTgkHjZB MnIKPul4jtH9KszyatKBON5g3l6fx82uawDDUKE1k+0Vu4KhSkFw8ai4wgidpEgOGc7H KM+0G4gGx+b4RhVBz68OHNF9VU5PYYC0Zc0is8X5Wy/MQWODETLb/SjVGCRq92M+Qjw7 q7U1IRaYxzFLCApilQZLvGNLh/zlkd56fEXHGTIP8ZceEEGholW/PLgPpj73oYEccQfo 5y0t7IKwzrsUrRwQmdDLXCK9MYhJRYDrmQMAP4Kd6Iqrf+ufgblHGMqlPlvu3KU7DD1h omvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=2NIQ1TwrG95rTm/28dxUdJZ491lS6fXAiyg3+rtP0i0=; b=oDaFQbtPNqO5IBAvXf0FN/cSKYX1rzJnqz57WaHUJCSyh6/oz84WAqiw+NRBh4eNQW WzpBJVOgccTYqImhwfqeifimZbg7G+vGquzYT7zDnFKmAhlEbzwAA0ce9ziqik10dAgj dhqOfzWzTghsOZld0SBYYzG4jNH9+KI/uVknYtyW4Sxcx0ngWj6J8o6mGaiAN2Dblmti s2AkI2v+kFZNQ5RmIGaHuPN2Bg+56Q+n5h3n8duWPm8HeywkcL5uQEpX6guMgzNdmtgM Rq9U8/UxJHnUT/AbuXSYFi3156YF7SjP1dal1t7dGeoXLnRAq340aAAzyAU+gw1Xxxkf xf9g== X-Gm-Message-State: AOAM532xfaCDkN9pulP3Q/fE4BnZxTQaXVqyeQZ9ZFDy+SE50c6Y958L PZL/n7ZDlItZ8bQGN/OVNyMXZL01ri/R X-Google-Smtp-Source: ABdhPJwOcLUE1fHN/M+BRjVp35jvvW0TUzFD5zgB0l5RnMBsEvMytvO9oktDPKxLZv7UBzywhS2+TVqVX5Aq Sender: "irogers via sendgmr" X-Received: from irogers.svl.corp.google.com ([2620:15c:2cd:2:f693:9fff:fef4:4583]) (user=irogers job=sendgmr) by 2002:a05:6214:80d:: with SMTP id df13mr4757822qvb.10.1610577378483; Wed, 13 Jan 2021 14:36:18 -0800 (PST) Date: Wed, 13 Jan 2021 14:36:09 -0800 In-Reply-To: <20210113223609.3358812-1-irogers@google.com> Message-Id: <20210113223609.3358812-2-irogers@google.com> Mime-Version: 1.0 References: <20210113223609.3358812-1-irogers@google.com> X-Mailer: git-send-email 2.30.0.284.gd98b1dd5eaa7-goog Subject: [PATCH 2/2] tools/bpftool: Add -Wall when building BPF programs From: Ian Rogers To: Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , Quentin Monnet , Jean-Philippe Brucker , Tobias Klauser , Ilya Leoshkevich , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ian Rogers Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org No additional warnings are generated by enabling this, but having it enabled will help avoid regressions. Signed-off-by: Ian Rogers Acked-by: Yonghong Song --- tools/bpf/bpftool/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile index f897cb5fb12d..45ac2f9e0aa9 100644 --- a/tools/bpf/bpftool/Makefile +++ b/tools/bpf/bpftool/Makefile @@ -166,7 +166,7 @@ $(OUTPUT)%.bpf.o: skeleton/%.bpf.c $(OUTPUT)vmlinux.h $(LIBBPF) -I$(srctree)/tools/include/uapi/ \ -I$(LIBBPF_PATH) \ -I$(srctree)/tools/lib \ - -g -O2 -target bpf -c $< -o $@ && $(LLVM_STRIP) -g $@ + -g -O2 -Wall -target bpf -c $< -o $@ && $(LLVM_STRIP) -g $@ $(OUTPUT)%.skel.h: $(OUTPUT)%.bpf.o $(BPFTOOL_BOOTSTRAP) $(QUIET_GEN)$(BPFTOOL_BOOTSTRAP) gen skeleton $< > $@