From patchwork Sun Jan 3 11:25:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Holland X-Patchwork-Id: 356311 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5026DC433E0 for ; Sun, 3 Jan 2021 11:27:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15CED20B1F for ; Sun, 3 Jan 2021 11:27:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726844AbhACL0z (ORCPT ); Sun, 3 Jan 2021 06:26:55 -0500 Received: from wnew4-smtp.messagingengine.com ([64.147.123.18]:35751 "EHLO wnew4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726686AbhACL0w (ORCPT ); Sun, 3 Jan 2021 06:26:52 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id C195D548; Sun, 3 Jan 2021 06:25:45 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 03 Jan 2021 06:25:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm1; bh=+FVXHJywYn5HO +Q77R6/9hCLYI494XIlo4EmogXhRdk=; b=PfPGRuggemNVUlTt69LBqOFkYHinX a5BFY9pKFmvRoRw6LJppKoyYMBTpbpHP+8vrP91bXsOXjVbp1Is3ywpytwN2WbKs yOGCWMKqYeIxuS224gTeszjz+fnD+9F2i1MB5Am+mPI7x6X3DOZJNq14gynGS56X AMm1TOOLBHznQo8tb3ujB7SbmczQwEI7uKJUie7/6gbeCBIoJo0uifV1oxONqDQF 5VKMSdYWf1XG5+hTQMG01+EpUfP/rO2IjZ2JEriOc1x5fAwLxsP0y2eybMMXLrfN YyHG2/EMElSBh+FCCzlSC7wSnbXnkJJm7Rmuw5lXrzciAjO22KtIZjCKw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=+FVXHJywYn5HO+Q77R6/9hCLYI494XIlo4EmogXhRdk=; b=Ac6pZWA6 eOWbsT/9McwQafA8yumTCGoGusZkn2MDhONWamLvNCB+Sl5CzRF7Dy0iET6tACYC BxWvSYIkDZhozOn3jtTp1dkzEyNfw24rEyyS1fvvQ7k/05f7Y0bkBOlHFKjfMvIC /wMQTQwrcplywpXScgrP3dACJRj/4jECy31U6C7KU0S8aDDuDYNqvyfp8fLKxxeK kcWSMgYlDPFdEf2mrYIUDTPxWLKHWIqD6+0XRq8o8OEcB5qG1HXIlplUN8OgAbVi DO2zaWOjS19fMUWvlLRAaO0ZPWQzosGhf7EPTqiejYGLY9psTXw+1TUxLPQsYwCo NQ1mWmXOW+TRyw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdefuddgvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefurghmuhgv lhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenucggtf frrghtthgvrhhnpeduhfejfedvhffgfeehtefghfeiiefgfeehgfdvvdevfeegjeehjedv gfejheeuieenucfkphepjedtrddufeehrddugeekrdduhedunecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshgrmhhuvghlsehshhholhhlrghn ugdrohhrgh X-ME-Proxy: Received: from titanium.stl.sholland.net (70-135-148-151.lightspeed.stlsmo.sbcglobal.net [70.135.148.151]) by mail.messagingengine.com (Postfix) with ESMTPA id 258F3108005B; Sun, 3 Jan 2021 06:25:43 -0500 (EST) From: Samuel Holland To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Jakub Kicinski , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Corentin Labbe Cc: Ondrej Jirman , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Samuel Holland Subject: [PATCH net-next 1/5] net: stmmac: dwmac-sun8i: Return void from PHY unpower Date: Sun, 3 Jan 2021 05:25:38 -0600 Message-Id: <20210103112542.35149-2-samuel@sholland.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210103112542.35149-1-samuel@sholland.org> References: <20210103112542.35149-1-samuel@sholland.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This is a deinitialization function that always returned zero, and that return value was always ignored. Have it return void instead. Signed-off-by: Samuel Holland Reviewed-by: Chen-Yu Tsai --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c index a5e0eff4a387..8e505019adf8 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c @@ -820,15 +820,14 @@ static int sun8i_dwmac_power_internal_phy(struct stmmac_priv *priv) return 0; } -static int sun8i_dwmac_unpower_internal_phy(struct sunxi_priv_data *gmac) +static void sun8i_dwmac_unpower_internal_phy(struct sunxi_priv_data *gmac) { if (!gmac->internal_phy_powered) - return 0; + return; clk_disable_unprepare(gmac->ephy_clk); reset_control_assert(gmac->rst_ephy); gmac->internal_phy_powered = false; - return 0; } /* MDIO multiplexing switch function