From patchwork Tue Dec 22 15:16:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 346643 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp5415056jai; Tue, 22 Dec 2020 07:18:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJwo04tKBugMnqhnDvhese7Mb0wGDe4RrKIylTHBkyeyhhhJMVWm3mHt+FHg19FjqLEHWIWb X-Received: by 2002:a50:d484:: with SMTP id s4mr20599965edi.13.1608650295610; Tue, 22 Dec 2020 07:18:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608650295; cv=none; d=google.com; s=arc-20160816; b=ynW/A+iTZ3bYUGpvxQYI0iWvHmU1HApcuwBOZ+0jLOZp1PAqTJam5gLqdk8O/9fhhf N6+cgo25EdMA10deRzNazeYzI+eYAypcNxjeUBYwkWOosTdAVmzxi6zj9KT4tVliP0R1 pIADpi3MnS0cjgmX/LyZl0LZHTQjf+OuwHE7WKYX9nS8VTaz9O8jwEO6WPqCt1rnIA1d Pi2OnpwSwXlFK95Q/SiO6BNzAKJt4+Et85rEo5hW56A3e8IQLEFOixSGGvixRnV1j63P qUaQh6OAeJ/2Io0QS+n4G+sgMcxGZqQFHIejNOCflg7wMIUwLBcmhq653XNNLex4I2ZY wfHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=vFVTJ+0eHU766NlPjzayRjSs+Vk0hqn0SrA9Il/j3JU=; b=bFAIW0DI5y7vCdwXHfB9negvekyFUBXpuLbFmySLTxoRVuv06MsT//UNZrhjJJYZJ2 tPNVFE+R3tWokXj9SZdDWyWI66XeDHh4BGEnkYab47N7jl7/K3oOEd4lQRZLTAH6bk2h JHXeuuPQExdf4dfac7M/EiZnV3qF97QXEuCO+qdRN8f56JKyc5E7895s9NxUoSBwQ5pO XpUU7oH3lxbf9SLAgZirV3/FnPjiCrv3OCOQYIuVy/vDPN60YhK9MBpfOv4ykDcKpXP1 3lpaqIm8GStKGWlVl30yoYzJeD49nbSuYeZqykj9xuFSpx/+KjkQ5GqguuM7m3TUT26v S0Lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sSZ3NgXR; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ch18si10803332ejb.736.2020.12.22.07.18.15; Tue, 22 Dec 2020 07:18:15 -0800 (PST) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sSZ3NgXR; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728031AbgLVPQ6 (ORCPT + 8 others); Tue, 22 Dec 2020 10:16:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727452AbgLVPQ6 (ORCPT ); Tue, 22 Dec 2020 10:16:58 -0500 Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7D25C0613D6 for ; Tue, 22 Dec 2020 07:16:17 -0800 (PST) Received: by mail-il1-x132.google.com with SMTP id k8so12298679ilr.4 for ; Tue, 22 Dec 2020 07:16:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vFVTJ+0eHU766NlPjzayRjSs+Vk0hqn0SrA9Il/j3JU=; b=sSZ3NgXR3fJvfO5KGnv/psaGcLEYQx0ftL8WbaYkt8YldWrlXDxO++LjxIQlaQp2Gc OgeLUUG3UQ2h2zHrrl3apTSKHaGHKooKuTysvMaGtrWMsGBMFVHJzrzJank70A3eNjRE VE0x6tKeooyjNNQzhdzDM8H5Hcp85GyoldwT3wfua1IK6NehDHUti7oaQ8+DgzV0gFUA pB0OJ8mYiHHYhJfiVti+d93k7FG3ri+F2MxaCtnXXVM9YFBF6K4CM9HGJavi4cDbVGbm DWjzXdINbuB/YhGtk8jPzqwbAmzRq/4d+f79gnv67on9zioICf8uxrHr4QFwZH2wRIJv LExw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vFVTJ+0eHU766NlPjzayRjSs+Vk0hqn0SrA9Il/j3JU=; b=ER+fm3zFA8wzaz9Tvi0JEF3OQjlu78YzTklVxBRmF5WCEhrfbnTyRHYfN7AYYT9+tx xdmRj52DdGe8MrrRBlqcHUXcGQVCgvB6ieCvlr2LQvyhctrWT/rsUK8L4MnMGpYm2POe 2ody+iyTxrm8qyLFDXVd38axGiY0RChDAes50KXodTAO+EArdCAm9bpISLpl5GNVPYta yoIwZBRhm4nqyiM4xm5rXLG3COvdu1m5DIyXCIxV5oHhzJ6af+2GWB70nS/qwx7gpUn1 mLffpKuLEq+dK9ZF0kRSzbP9giGoewVdcCTaa1hDyGYJqWNjgngsGwwHEUOkxGQqbFiX sW4g== X-Gm-Message-State: AOAM530tpzj1vHJcGhJuPVKy1xvEoQAoEScUUkeEi5xPMgvz+r4FJdxH wz6Hhb/wZDc2KARIL2yGSV/JCA== X-Received: by 2002:a05:6e02:1bcb:: with SMTP id x11mr20217449ilv.32.1608650177174; Tue, 22 Dec 2020 07:16:17 -0800 (PST) Received: from beast.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id e25sm24018458iom.40.2020.12.22.07.16.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Dec 2020 07:16:16 -0800 (PST) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: evgreen@chromium.org, cpratapa@codeaurora.org, bjorn.andersson@linaro.org, subashab@codeaurora.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net] net: ipa: fix interconnect enable bug Date: Tue, 22 Dec 2020 09:16:13 -0600 Message-Id: <20201222151613.5730-1-elder@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When the core clock rate and interconnect bandwidth specifications were moved into configuration data, a copy/paste bug was introduced, causing the memory interconnect bandwidth to be set three times rather than enabling the three different interconnects. Fix this bug. Fixes: 91d02f9551501 ("net: ipa: use config data for clocking") Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_clock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.20.1 Reviewed-by: Georgi Djakov diff --git a/drivers/net/ipa/ipa_clock.c b/drivers/net/ipa/ipa_clock.c index 9dcf16f399b7a..135c393437f12 100644 --- a/drivers/net/ipa/ipa_clock.c +++ b/drivers/net/ipa/ipa_clock.c @@ -115,13 +115,13 @@ static int ipa_interconnect_enable(struct ipa *ipa) return ret; data = &clock->interconnect_data[IPA_INTERCONNECT_IMEM]; - ret = icc_set_bw(clock->memory_path, data->average_rate, + ret = icc_set_bw(clock->imem_path, data->average_rate, data->peak_rate); if (ret) goto err_memory_path_disable; data = &clock->interconnect_data[IPA_INTERCONNECT_CONFIG]; - ret = icc_set_bw(clock->memory_path, data->average_rate, + ret = icc_set_bw(clock->config_path, data->average_rate, data->peak_rate); if (ret) goto err_imem_path_disable;