From patchwork Thu Nov 26 13:38:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 332972 Delivered-To: patch@linaro.org Received: by 2002:a17:906:4755:0:0:0:0 with SMTP id j21csp152647ejs; Thu, 26 Nov 2020 05:39:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJyEYqlD7l45q80weAPAU9jKIvbjeIOtD2QOxMfqlOOPY4L/+/eTWBD8qBb7AlqldFFSEWUR X-Received: by 2002:a17:906:dc49:: with SMTP id yz9mr2607360ejb.499.1606397980616; Thu, 26 Nov 2020 05:39:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606397980; cv=none; d=google.com; s=arc-20160816; b=QqbHy18TBWZNZmsigsZRAdq5xnMJSDwQg20GwbkdMbItADkvKDmfHEog9DW5REx0ui WEwmfpkgWKGnfJLm67GVbxbuph2JI2rzqzdAnSiBBRSi0ft/t/w/XwMY3rwN9jdT350g N/bnDZOsbRLoo436/D4xZT4C2fHGxRsRF2S+6zkcvClyRGxo39YvKoFga2m1KFIoTPVX ukMYwAU3PE6EQcYnhtJN+ACI0DBAuhGLlpjEomTJlsx7pDIkSX5F5W5kGrjfFg21iFjJ kPJk30Y2QBdnWTUHzqojA6h44ufQWubyj5WWPZ08koO5XEIHOzmDkwi39i/GBxbrAt9H uyXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DTJOzm0gZUliIM1CJNEOWqPKlNYApXefDQfPPtC85HY=; b=ADyjlv447qNyuA0gg42+WFayi25i+c8zvrApY9nXQd30+U2Ah0ZSkjrwBqh73NEL6q gMCQ7oD5dRgfuKQZDxcJ0cynA6VinFodljBl9FLNHJyiZJ+yZ73wHJoZwRZRiKuFlIzw gr1vokWipoqGf1ethM8Kj805OOZBRHcB/CKhpqyXSf6OI81aaYvualBwba3slP2hClzn dxTAZKuMYnwe5FwO7iVQCWZ3f+KFHCrI0BRW0XjMFqXN8rNyq+eVF8+xIRXh6ImQa8ih yhOb/i60CGEcEbXaV8y26+bIjPKZ7HnPE4v370uefwHen4P1biXstSxxse1bjjUEOFjp tFEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MpLT1rTc; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bt20si3037473edb.405.2020.11.26.05.39.40; Thu, 26 Nov 2020 05:39:40 -0800 (PST) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MpLT1rTc; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390554AbgKZNjK (ORCPT + 8 others); Thu, 26 Nov 2020 08:39:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390368AbgKZNjH (ORCPT ); Thu, 26 Nov 2020 08:39:07 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 930A2C0617A7 for ; Thu, 26 Nov 2020 05:39:07 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id s8so2163504wrw.10 for ; Thu, 26 Nov 2020 05:39:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DTJOzm0gZUliIM1CJNEOWqPKlNYApXefDQfPPtC85HY=; b=MpLT1rTcOQFXj5o4p45U25gq5Wthd5hRlOe6Ee20BztH8fDINAFaP0ZGPZrw/fdu38 SQDpyQIFeHvBMZPN84C6jFq3J/b9fMFZUIqyfyvASKnB4KKLD2TTzAPoMoOaBwcjGw0W Q/dLgkJXs8gJC3AhstDCm/oTI4DLuAkMXHGatvyRdaPI6XbX5O5rP642oQxh5iZCK86S gBKa8VwBXCPDpUt90nGEOfBD1oM7WZIuQofLaxEdI4/vzc2IhjdS4Y7G3j7IaZBOT7q2 4ENAa5iQyd+BgkiP2sMF01e4mBpRVZiTs7Wn2xKv4duAzKRegKdJkcE929j47H1/FM7t Sh4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DTJOzm0gZUliIM1CJNEOWqPKlNYApXefDQfPPtC85HY=; b=Yw2ZCYP0vOsq4CFgyzwygD14DWyVEO7T23J0bycMvDGl5saFpuUNFDSCN1xQ4wwor8 r4vdIhpgqdpXAVrj8JmIe00g+6hVmXKXRKR5jRJRn/uTP1sNu3rdI2n38LbBBPyASqX2 pgSenAzu4yvH4x8dQQjKCGi9TGVB9gze183C1OsMvzYweeeGtSWxLygI6cznSdUbGeCF zlsEkKOxJi7fPL9mTVRSP+SDpSowG+R+ibJGuIOrtdiT+vqiJZXwwO3qpt6Um1xIlxYW dISZFZwO0eGuUrq0afkmUs84nItXr1eMy7XJ1dLueUr/m+vX6hiklYr2oFc+N68aIHfY LCrA== X-Gm-Message-State: AOAM531giokN1Iz84lSlCG46jSxeLrWjT7uylUpVi9eKDZv6aMOgmu+l BQTTNa0PWjUpNJBqVx/r8ULJ7w== X-Received: by 2002:adf:e551:: with SMTP id z17mr3940424wrm.374.1606397946311; Thu, 26 Nov 2020 05:39:06 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id s133sm7035825wmf.38.2020.11.26.05.39.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:39:05 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Geoff Levand , "David S. Miller" , Jakub Kicinski , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Utz Bacher , Jens Osterkamp , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH 6/8] net: ethernet: toshiba: ps3_gelic_net: Fix some kernel-doc misdemeanours Date: Thu, 26 Nov 2020 13:38:51 +0000 Message-Id: <20201126133853.3213268-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133853.3213268-1-lee.jones@linaro.org> References: <20201126133853.3213268-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter or member 'irq' not described in 'gelic_card_interrupt' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter or member 'ptr' not described in 'gelic_card_interrupt' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1407: warning: Function parameter or member 'txqueue' not described in 'gelic_net_tx_timeout' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1439: warning: Function parameter or member 'napi' not described in 'gelic_ether_setup_netdev_ops' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1639: warning: Function parameter or member 'dev' not described in 'ps3_gelic_driver_probe' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1795: warning: Function parameter or member 'dev' not described in 'ps3_gelic_driver_remove' Cc: Geoff Levand Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Utz Bacher Cc: Jens Osterkamp Cc: netdev@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) -- 2.25.1 Reviewed-by: Andrew Lunn diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c b/drivers/net/ethernet/toshiba/ps3_gelic_net.c index d9a5722f561b5..f886e23f8ed0a 100644 --- a/drivers/net/ethernet/toshiba/ps3_gelic_net.c +++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.c @@ -1100,7 +1100,7 @@ static int gelic_net_poll(struct napi_struct *napi, int budget) return packets_done; } -/** +/* * gelic_card_interrupt - event handler for gelic_net */ static irqreturn_t gelic_card_interrupt(int irq, void *ptr) @@ -1400,6 +1400,7 @@ static void gelic_net_tx_timeout_task(struct work_struct *work) /** * gelic_net_tx_timeout - called when the tx timeout watchdog kicks in. * @netdev: interface device structure + * @txqueue: unused * * called, if tx hangs. Schedules a task that resets the interface */ @@ -1431,6 +1432,7 @@ static const struct net_device_ops gelic_netdevice_ops = { /** * gelic_ether_setup_netdev_ops - initialization of net_device operations * @netdev: net_device structure + * @napi: napi structure * * fills out function pointers in the net_device structure */ @@ -1632,7 +1634,7 @@ static void gelic_card_get_vlan_info(struct gelic_card *card) dev_info(ctodev(card), "internal vlan %s\n", card->vlan_required? "enabled" : "disabled"); } -/** +/* * ps3_gelic_driver_probe - add a device to the control of this driver */ static int ps3_gelic_driver_probe(struct ps3_system_bus_device *dev) @@ -1787,10 +1789,9 @@ static int ps3_gelic_driver_probe(struct ps3_system_bus_device *dev) return result; } -/** +/* * ps3_gelic_driver_remove - remove a device from the control of this driver */ - static int ps3_gelic_driver_remove(struct ps3_system_bus_device *dev) { struct gelic_card *card = ps3_system_bus_get_drvdata(dev);