From patchwork Thu Nov 26 13:31:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 332951 Delivered-To: patch@linaro.org Received: by 2002:a17:906:4755:0:0:0:0 with SMTP id j21csp147962ejs; Thu, 26 Nov 2020 05:33:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJw8+sUctRCIzSjmovBhXl8nzB3lfR3liWI6trzhtJ66oMrU18ZJh13E+bAVvvlq7+i5A1cV X-Received: by 2002:aa7:c61a:: with SMTP id h26mr2600902edq.327.1606397608947; Thu, 26 Nov 2020 05:33:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606397608; cv=none; d=google.com; s=arc-20160816; b=jITxhiNLSB0g3d5DBJt2lOGSgblUTvQCzVXdtEajDiv+ZxLp67eoDgEV1pgcZ2xjXu HtFEgtC/F5U/XKvhXH8b78caQPkiPcm1wNlWic18vOU8IH2anQI98Aa3kXpLXQU+YR/l 5lnGzQVtbKaM2L3xLnEFOGOyke9oIuPpeZ2BhjpA/xdlvVa20ZWc3NsINDtubN36r8go +uaweIXCy8jfKpyQX3vyiztX1EFidkfAjyJHyEeUajZTG30QSM4M8VY+gj0AExieUqsJ OXIq2rD4lmUWLqx8ihojK1i6V8NtmmkBlOfWWM9Q67BV+mpaBfWXFI4cr4BIm4QOdNLo BR3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=SxQ9eC4olAQ/BaWiTM/LMUE/iibApHADASIQRVEODWI=; b=jqaUpvS1LwMdflSuPpieqHitgKjU1+/yS0m2J7feu9Hlezubt3V46FiIu0N0+DMvzT PAPv54KcIEnuTrvVZs2pNDobkrqNek8QXlOx1q2F6d2pDblpdyaqv8bdijscEOCuxrC+ huovqtHVLjxIAU0p3/nuiqndIsusiTQ8d5+mAqJsC0N3tCG1bT1S1oT78C49vIPEqu2o KKVGZIjA5nCaRt1QZBCt+NZRA1zOOWqUBJ+ZqooPLed71isiHDARVKmn7FREK3QGgpU9 VXD7x9UHB/ImGaWqO5B6OaHCWVO0nfuh2gTG9xT84AdckHhUtK0Qrcc0JV1lJLJy/tQq M/vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tlDrq9iI; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q15si3191310edr.58.2020.11.26.05.33.28; Thu, 26 Nov 2020 05:33:28 -0800 (PST) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tlDrq9iI; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390362AbgKZNcU (ORCPT + 8 others); Thu, 26 Nov 2020 08:32:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390343AbgKZNcT (ORCPT ); Thu, 26 Nov 2020 08:32:19 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C00BEC061A47 for ; Thu, 26 Nov 2020 05:32:17 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id a65so2431452wme.1 for ; Thu, 26 Nov 2020 05:32:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SxQ9eC4olAQ/BaWiTM/LMUE/iibApHADASIQRVEODWI=; b=tlDrq9iIniydmRPORn0GM7r7Sk+AYo81IX40ePvYCs9TvW173vIQNiohrAz4S+p7IW fBy7trdzh4ocFFU0zcprItKqpZe37746Y9o6fwQklnx8oZD0QaCeL4XFot4goDfpBwfH 53tUjsuyWlWwCfrErTH1CbKfH8+iyIVScKIyqgssp2hMAtY1pFUNfnAbC7SKk94sgTKl hULP+RETO+bmAWVeli/OjyuI/FEVLsP99k8H47IgkGd1kdhiVrjftx5glDxqkgVGX6nE yMPtsfTykIcmWYbEE0peYDfCx3541qvesAGMTauB6RA9nQlWkzMgfwkOyiVKOWHsSFp1 2CmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SxQ9eC4olAQ/BaWiTM/LMUE/iibApHADASIQRVEODWI=; b=LyGFpSUe2STn+i8sAZffgTGznNe15L85TO0LvXLqLTP3pruLMkQ+eZe1niUU2BtF3h +5OMhb+vV26zJILCo+IAhcNqdVDrsSzIlgRvh+JRx/Y8msDYWWlzuR/CGS/uv6Q3QHt+ Bh/mZkH9vwXrUb9e0qPeQIkBDwRDPGbIpq1tqqQVKyCDAOsycqtu8JvtCaxRpHn4sgTw sP87noARmyvkS9xL7z+f0J+sBqyQJovIMiCRL/XeHUvOhNp2P+/B5rxskCO5G2DTzNxE bnmx8CeCd8pnrk1ADj42Nrf319F12BIGiVR3xuQIba7IOtAMQwcEF6k1lLvyoShsnSBU mw2w== X-Gm-Message-State: AOAM533qdMEAiaEfEFJV2bKXLPCO10zec79meyhsKH/zA8aDZNX4su4E caw245L7jj0nvzM/9K8yo4pPSQ== X-Received: by 2002:a1c:c343:: with SMTP id t64mr3467938wmf.140.1606397536471; Thu, 26 Nov 2020 05:32:16 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id n10sm8701001wrv.77.2020.11.26.05.32.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:32:15 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org, kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 16/17] iwlwifi: fw: acpi: Demote non-conformant function headers Date: Thu, 26 Nov 2020 13:31:51 +0000 Message-Id: <20201126133152.3211309-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133152.3211309-1-lee.jones@linaro.org> References: <20201126133152.3211309-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/fw/acpi.c:123: warning: Function parameter or member 'dev' not described in 'iwl_acpi_get_dsm_object' drivers/net/wireless/intel/iwlwifi/fw/acpi.c:123: warning: Function parameter or member 'rev' not described in 'iwl_acpi_get_dsm_object' drivers/net/wireless/intel/iwlwifi/fw/acpi.c:123: warning: Function parameter or member 'func' not described in 'iwl_acpi_get_dsm_object' drivers/net/wireless/intel/iwlwifi/fw/acpi.c:123: warning: Function parameter or member 'args' not described in 'iwl_acpi_get_dsm_object' drivers/net/wireless/intel/iwlwifi/fw/acpi.c:142: warning: Function parameter or member 'dev' not described in 'iwl_acpi_get_dsm_u8' drivers/net/wireless/intel/iwlwifi/fw/acpi.c:142: warning: Function parameter or member 'rev' not described in 'iwl_acpi_get_dsm_u8' drivers/net/wireless/intel/iwlwifi/fw/acpi.c:142: warning: Function parameter or member 'func' not described in 'iwl_acpi_get_dsm_u8' Cc: Johannes Berg Cc: Emmanuel Grumbach Cc: Luca Coelho Cc: Intel Linux Wireless Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/iwlwifi/fw/acpi.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/intel/iwlwifi/fw/acpi.c b/drivers/net/wireless/intel/iwlwifi/fw/acpi.c index 3e5a35e26ad34..ab1d8b18d9976 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/acpi.c +++ b/drivers/net/wireless/intel/iwlwifi/fw/acpi.c @@ -113,11 +113,11 @@ void *iwl_acpi_get_object(struct device *dev, acpi_string method) } IWL_EXPORT_SYMBOL(iwl_acpi_get_object); -/** -* Generic function for evaluating a method defined in the device specific -* method (DSM) interface. The returned acpi object must be freed by calling -* function. -*/ +/* + * Generic function for evaluating a method defined in the device specific + * method (DSM) interface. The returned acpi object must be freed by calling + * function. + */ static void *iwl_acpi_get_dsm_object(struct device *dev, int rev, int func, union acpi_object *args) { @@ -134,7 +134,7 @@ static void *iwl_acpi_get_dsm_object(struct device *dev, int rev, int func, return obj; } -/** +/* * Evaluate a DSM with no arguments and a single u8 return value (inside a * buffer object), verify and return that value. */