From patchwork Sat Nov 21 11:44:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kurt Kanzenbach X-Patchwork-Id: 330251 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95C31C56202 for ; Sat, 21 Nov 2020 11:45:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4574C2224A for ; Sat, 21 Nov 2020 11:45:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="hKW+uXMj"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="Mp4xRwTy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727681AbgKULpV (ORCPT ); Sat, 21 Nov 2020 06:45:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727224AbgKULpV (ORCPT ); Sat, 21 Nov 2020 06:45:21 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB417C0613CF for ; Sat, 21 Nov 2020 03:45:20 -0800 (PST) From: Kurt Kanzenbach DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1605959119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qigJQbKQFSP4c6lJ4vijSarKeYToBXwmf9g1KDr6BxU=; b=hKW+uXMjCIeAnEhEQ6a58Sn9lUlr3Y57LnFwtK2eRgLp/ojdtiIfDXvgg6f61RZGHoNMp0 kqgcJ0ctHvIvuZYaAQ0ByfVCMjLvnps6bW36GTKJeOlrb3O2eNcO709MuGTbr+W82R/LXq GprgtFcNfeDcwe9mAreywsVVRh9nroU7X2UF4cZp0eWgdlN36v4/I6ClAUxu+WgVc+80YR flO8hdOWf/uimCFX6nhzdSWnRv23fhBtd9vGQCFyftDabD/A50w5ncu+pJyUZNOtb1cpmg tgL7eMJV1CzCILAZBkB+6Ns6qls03/fFav6O3OA7LVnJn6sbdcko0iaKIeVBig== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1605959119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qigJQbKQFSP4c6lJ4vijSarKeYToBXwmf9g1KDr6BxU=; b=Mp4xRwTy11GWZ5lZDf51auKWRxw6w105GmNf/7mk2h0xnTtTxKgt3+NfLEktQ35+NJ+zeQ Sr8gJ5SOAbgRkqBA== To: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean Cc: "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, Kurt Kanzenbach Subject: [PATCH net-next 2/2] net: dsa: hellcreek: Don't print error message on defer Date: Sat, 21 Nov 2020 12:44:55 +0100 Message-Id: <20201121114455.22422-3-kurt@linutronix.de> In-Reply-To: <20201121114455.22422-1-kurt@linutronix.de> References: <20201121114455.22422-1-kurt@linutronix.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When DSA is not loaded when the driver is probed an error message is printed. But, that's not really an error, just a defer. Use dev_err_probe() instead. Signed-off-by: Kurt Kanzenbach Reviewed-by: Vladimir Oltean --- drivers/net/dsa/hirschmann/hellcreek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/hirschmann/hellcreek.c b/drivers/net/dsa/hirschmann/hellcreek.c index d42f40c76ba5..6420b76ea37c 100644 --- a/drivers/net/dsa/hirschmann/hellcreek.c +++ b/drivers/net/dsa/hirschmann/hellcreek.c @@ -1266,7 +1266,7 @@ static int hellcreek_probe(struct platform_device *pdev) ret = dsa_register_switch(hellcreek->ds); if (ret) { - dev_err(dev, "Unable to register switch\n"); + dev_err_probe(dev, ret, "Unable to register switch\n"); return ret; }