From patchwork Mon Nov 2 11:23:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315847 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B215EC388F2 for ; Mon, 2 Nov 2020 11:24:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E086223B0 for ; Mon, 2 Nov 2020 11:24:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uzU+59hH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728595AbgKBLY1 (ORCPT ); Mon, 2 Nov 2020 06:24:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728598AbgKBLYZ (ORCPT ); Mon, 2 Nov 2020 06:24:25 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10166C0617A6 for ; Mon, 2 Nov 2020 03:24:23 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id p22so9018234wmg.3 for ; Mon, 02 Nov 2020 03:24:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=A1fMIMjw6i89f8UX70P4Kw6NDXaWlqTcl97Lfk1WFz4=; b=uzU+59hH5565Hurqo3QSpw5jMldLf2h0/QVjPsls6qykE/ceDqX8W3w0QjvF+RNNxK ob6ZesURS0nG0LpVVGD+PwwYIhIHQrSUrIpP7lqfbSIo5noKVOS41mw6mSFPjdiP8fKO WSvbAPpu0pV97tymA9dcJBDRm4I0NbViB7JiTYZ6Q8IA+r2vOB66zBRdbnHzsu9QXQ4/ x5Zwv0aLPwnsdrvXPv7kRMaRWinwnjWBTOuYWVX1uBCK4WYpR+maFieGrFymLLeQQEnr U120OvXsajcfXIoNbeUAGMe0qbTaJxVJ1L9AFDzjUY6q4SNmSyGkXmHhy8wXc5pKKT5U vGwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=A1fMIMjw6i89f8UX70P4Kw6NDXaWlqTcl97Lfk1WFz4=; b=gLna9vR4wa0gg6OcsAp2Sjia0X/LSYhRsRoK+R76bYAE3Yt13XLMf4wrRL2ViHIAZV Bn5ETcpx759IBLlHsm+HaaEtVNJetTsB7xU7iO1i3uHVTMR/3hZOaYA8tXubkkLY9cyJ zG7PZFBrTCmWYwQcyYrOH1sYrhThTEluT9zs5ALK/i5gK+7xBosumimGiU/1805nQmWS d1/s5yZyz4FC23hBqIOh7ifCNHRmiW0bJek1Ar04Lc+Q0wrbLLKO5ZtVknLpxjO5paIc 3esczmO3r10EkapdP4WZ7Mz6NXms89ghlwczsV5xqZbKoXER9ipnsv6ogc1+zzjIg7oI C4aQ== X-Gm-Message-State: AOAM530Cl8XQq9RLmwJVri4BayC420675mx7o8Z2sGNzhIDWHCz/uizG SWSCDHsUBnA2hmj5pJukbe3Xdw== X-Google-Smtp-Source: ABdhPJxOMcmp/5oX7Gq5iCjpMjclVgcK49IJ9lE6t5E9al45QFOH+Lc6yhmlA8ZPv4GomW4lGTZDIg== X-Received: by 2002:a1c:790b:: with SMTP id l11mr16053038wme.53.1604316261773; Mon, 02 Nov 2020 03:24:21 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:21 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Ping-Ke Shih , "David S. Miller" , Jakub Kicinski , Larry Finger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 03/41] rtl8192cu: mac: Fix some missing/ill-documented function parameters Date: Mon, 2 Nov 2020 11:23:32 +0000 Message-Id: <20201102112410.1049272-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:124: warning: Function parameter or member 'hw' not described in 'rtl92c_llt_write' drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:124: warning: Excess function parameter 'io' description in 'rtl92c_llt_write' drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:155: warning: Function parameter or member 'hw' not described in 'rtl92c_init_llt_table' drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:155: warning: Excess function parameter 'io' description in 'rtl92c_init_llt_table' Cc: Ping-Ke Shih Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Larry Finger Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c index 2890a495a23ec..8d2c6d8d32d93 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c @@ -113,7 +113,7 @@ void rtl92c_read_chip_version(struct ieee80211_hw *hw) /** * writeLLT - LLT table write access - * @io: io callback + * @hw: Pointer to the ieee80211_hw structure. * @address: LLT logical address. * @data: LLT data content * @@ -145,11 +145,10 @@ bool rtl92c_llt_write(struct ieee80211_hw *hw, u32 address, u32 data) /** * rtl92c_init_LLT_table - Init LLT table - * @io: io callback - * @boundary: + * @hw: Pointer to the ieee80211_hw structure. + * @boundary: Page boundary. * * Realtek hardware access function. - * */ bool rtl92c_init_llt_table(struct ieee80211_hw *hw, u32 boundary) {