From patchwork Mon Nov 2 11:23:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315827 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADC2CC00A89 for ; Mon, 2 Nov 2020 11:29:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 587C1223AC for ; Mon, 2 Nov 2020 11:29:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mSKuh/oQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728788AbgKBL3a (ORCPT ); Mon, 2 Nov 2020 06:29:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728562AbgKBLYW (ORCPT ); Mon, 2 Nov 2020 06:24:22 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA74DC061A04 for ; Mon, 2 Nov 2020 03:24:21 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id c18so9018308wme.2 for ; Mon, 02 Nov 2020 03:24:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bTiCTwpSeuoC0ZILvau+EWPZDB/8AsBPEAL01U6W1b4=; b=mSKuh/oQx2l+5azZ5IH6cLue5yw1lvhVyOtk9XfOR4NLK4Cfn48DDs1VUWdigzZ/oh bAkemouy5StWNyflyuH/BRhSA/GHZdyI+I1doII0o+zIRL9pWY08ELzHvboJgjZLRnkt sJ1l59vpWGkXCBhLwGE1bqRW1JyUuK+2ccOxyoqoJ57d/14nFshRVVj69RksJ9ctBxyx kYTZirub27Ts8fWmFyBhFfe1O12tzRa4jf2FCcb8NJGuNnX0p+LNggbE8PB4OOQquZta 8gF7AxVGtZY0+RqNapn/npw28v3PtjhDc1ljWTdVlNBLFJUcZce6XwlMDIl4viLfj7r+ M9Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bTiCTwpSeuoC0ZILvau+EWPZDB/8AsBPEAL01U6W1b4=; b=kryKRIin8hTPeFKPmP97gVv7pnFZzatyVDPgjjxia47GwL9vMqbMvPZyT2HJ8N9SrA nG0iPSwbhWylJlK95l6W1dxYmVq5BOjGQDE3c0AUQj5ACI0rxAlWDdZrSKOezQuzfIAz r7sJNpQw0w/rZFs+NKHbabt/wW8wbCDayikx+2bNPHmxhCng+ye1zG9aFLtn/RCbbhcy 2tqvzeKcjyZ0fP1VplXZjm9O+OiigrZHZ1zUvoFjY5VyZ01c6hEhQqawKzsr6pWKUXxd 4FZ8jLcmps/YKEaX6QXDtysZdx/wSSoevX7evpUru7QPUBRI3poavHMkOrhi7D0eu6CU PIsQ== X-Gm-Message-State: AOAM530tRBQFXtGVxESuGbE21+xZTx5OaFg6RNgHt67BLjz+Qf7t3VFe M7sYNexn/Lp5tBIkJf9wrjEQcQ== X-Google-Smtp-Source: ABdhPJysV3sSLjorLpfTTVKOdxO80zr1Or3MAdqQyIDLtjVRp2ORjSI2bSJGUUuC/vYvuQGnFzLCNw== X-Received: by 2002:a05:600c:2252:: with SMTP id a18mr15786081wmm.139.1604316260550; Mon, 02 Nov 2020 03:24:20 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:19 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Amitkumar Karwar , Siva Rebbagondla , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 02/41] rsi_91x_usb: Fix some basic kernel-doc issues Date: Mon, 2 Nov 2020 11:23:31 +0000 Message-Id: <20201102112410.1049272-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/rsi/rsi_91x_usb.c:26: warning: cannot understand function prototype: 'u16 dev_oper_mode = DEV_OPMODE_STA_BT_DUAL; ' drivers/net/wireless/rsi/rsi_91x_usb.c:88: warning: Function parameter or member 'endpoint' not described in 'rsi_write_multiple' drivers/net/wireless/rsi/rsi_91x_usb.c:88: warning: Excess function parameter 'addr' description in 'rsi_write_multiple' drivers/net/wireless/rsi/rsi_91x_usb.c:320: warning: Function parameter or member 'ep_num' not described in 'rsi_rx_urb_submit' drivers/net/wireless/rsi/rsi_91x_usb.c:320: warning: Function parameter or member 'mem_flags' not described in 'rsi_rx_urb_submit' Cc: Amitkumar Karwar Cc: Siva Rebbagondla Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/rsi/rsi_91x_usb.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_usb.c b/drivers/net/wireless/rsi/rsi_91x_usb.c index a62d41c0ccbc0..8928e14671512 100644 --- a/drivers/net/wireless/rsi/rsi_91x_usb.c +++ b/drivers/net/wireless/rsi/rsi_91x_usb.c @@ -1,4 +1,4 @@ -/** +/* * Copyright (c) 2014 Redpine Signals Inc. * * Permission to use, copy, modify, and/or distribute this software for any @@ -75,7 +75,7 @@ static int rsi_usb_card_write(struct rsi_hw *adapter, * rsi_write_multiple() - This function writes multiple bytes of information * to the USB card. * @adapter: Pointer to the adapter structure. - * @addr: Address of the register. + * @endpoint: Type of endpoint. * @data: Pointer to the data that has to be written. * @count: Number of multiple bytes to be written. * @@ -313,6 +313,8 @@ static void rsi_rx_urb_kill(struct rsi_hw *adapter, u8 ep_num) /** * rsi_rx_urb_submit() - This function submits the given URB to the USB stack. * @adapter: Pointer to the adapter structure. + * @ep_num: Endpoint number. + * @mem_flags: The type of memory to allocate. * * Return: 0 on success, a negative error code on failure. */