From patchwork Sun Nov 1 12:50:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ioana Ciornei X-Patchwork-Id: 315888 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65422C4741F for ; Sun, 1 Nov 2020 12:55:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3095520719 for ; Sun, 1 Nov 2020 12:55:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rNoYRpHi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726999AbgKAMzR (ORCPT ); Sun, 1 Nov 2020 07:55:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726670AbgKAMw0 (ORCPT ); Sun, 1 Nov 2020 07:52:26 -0500 Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4B8AC061A04; Sun, 1 Nov 2020 04:52:25 -0800 (PST) Received: by mail-ed1-x543.google.com with SMTP id v4so11399871edi.0; Sun, 01 Nov 2020 04:52:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=n5W+ROLvWRCB6lTVb9DWGVA66kjGHAbhcZbQXXZedOg=; b=rNoYRpHigSkIPHKK39F4fwHBL8HBSpM4cGUhzwwZRnq+uPy9cA93A5uOuQL7Z/ykLS JJkHT5zeOtOr63pmuhVb4TGCpJhIM2XN2hm0eEvQqTACLqGBLthyVxj/eFwFe1/JbpBI 58c0QO4QQUbPqbZgkFF7ELbQeffSt1gNt8+eMcprPZkJXjgKPfbyzh7wQcMBtt8Dofpc aE020KmdbIVrSBqiKKAZcx5YrAf7CWrh0ESQaNuQi3p6JijFoAd6mn2hx47jyi5lndH5 MnmRhbzDNBolFBXGmhpzL1QI+a3ujUoTYKX3JeQNHgXHfyQybA/Oh6icQVyt4tII2gtb ic3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=n5W+ROLvWRCB6lTVb9DWGVA66kjGHAbhcZbQXXZedOg=; b=Q1eiXgezzgjqDidhRx2LQ3we/ckmDRfJBPcenMyXRqwONxQbSzsj84MgoZhQc/5/WM Yw3QqX5WLaQXiyNNUbACiol3LhMRzSY80JoJIvkRHJ5C38o3A/7Q3Fz+VCjys1YIC8kJ m0zI2+PieBU6w4wT50akLBxRrnzzQPH13ZNlztCmOVcgCxPuOGPDnVmWytBgPjuSnoqM iEgubcJs8egoMbCJ4/4yQaDBRkHP04jil4zE5JHvxXmrw36WnrESEDzS4SyzRNXrhog4 r3+Wa/O9g5Rl2Lq4+SwrRA3aYrWkgV98RXHwXnrPU7BVocLewonAuap40ZKOOjly1mvV kD/A== X-Gm-Message-State: AOAM530egoVxNlWKPNkVv/LL5oEN0eiWvZq1td8o8gId/IIym/el/Wav LxXlVuU1PQ8EuIVaOjBQI9o= X-Google-Smtp-Source: ABdhPJzAYNkrYyPQUNa/4pLKbBoV50SqCed2+gaF+KvDzxLnOQcFSGxfLD8M1LjHo5Axh5MLHGvKiA== X-Received: by 2002:aa7:d1d5:: with SMTP id g21mr12071763edp.348.1604235144548; Sun, 01 Nov 2020 04:52:24 -0800 (PST) Received: from yoga-910.localhost ([188.25.2.177]) by smtp.gmail.com with ESMTPSA id c5sm8133603edx.58.2020.11.01.04.52.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Nov 2020 04:52:23 -0800 (PST) From: Ioana Ciornei To: Andrew Lunn , Heiner Kallweit , Russell King , Florian Fainelli , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ioana Ciornei , Alexandru Ardelean , Andre Edich , Antoine Tenart , Baruch Siach , Christophe Leroy , Dan Murphy , Divya Koppera , Hauke Mehrtens , Jerome Brunet , Kavya Sree Kotagiri , Linus Walleij , Marco Felsch , Marek Vasut , Martin Blumenstingl , Mathias Kresin , Maxim Kochetkov , Michael Walle , Neil Armstrong , Nisar Sayed , Oleksij Rempel , Philippe Schenker , Willy Liu , Yuiko Oshino Subject: [PATCH net-next v2 03/19] net: phy: make .ack_interrupt() optional Date: Sun, 1 Nov 2020 14:50:58 +0200 Message-Id: <20201101125114.1316879-4-ciorneiioana@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201101125114.1316879-1-ciorneiioana@gmail.com> References: <20201101125114.1316879-1-ciorneiioana@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ioana Ciornei As a first step into making phylib and all PHY drivers to actually have support for shared IRQs, make the .ack_interrupt() callback optional. After all drivers have been moved to implement the generic interrupt handle, the phy_drv_supports_irq() check will be changed again to only require the .handle_interrupts() callback. Cc: Alexandru Ardelean Cc: Andre Edich Cc: Antoine Tenart Cc: Baruch Siach Cc: Christophe Leroy Cc: Dan Murphy Cc: Divya Koppera Cc: Florian Fainelli Cc: Hauke Mehrtens Cc: Heiner Kallweit Cc: Jerome Brunet Cc: Kavya Sree Kotagiri Cc: Linus Walleij Cc: Marco Felsch Cc: Marek Vasut Cc: Martin Blumenstingl Cc: Mathias Kresin Cc: Maxim Kochetkov Cc: Michael Walle Cc: Neil Armstrong Cc: Nisar Sayed Cc: Oleksij Rempel Cc: Philippe Schenker Cc: Willy Liu Cc: Yuiko Oshino Signed-off-by: Ioana Ciornei --- Changes in v2: - none drivers/net/phy/phy_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 413a0a2c5d51..f54f483d7fd6 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -2815,7 +2815,7 @@ EXPORT_SYMBOL(phy_get_internal_delay); static bool phy_drv_supports_irq(struct phy_driver *phydrv) { - return phydrv->config_intr && phydrv->ack_interrupt; + return phydrv->config_intr && (phydrv->ack_interrupt || phydrv->handle_interrupt); } /**