From patchwork Mon Oct 26 21:29:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 298576 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A4AEC2D0A3 for ; Mon, 26 Oct 2020 21:34:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D7F0320829 for ; Mon, 26 Oct 2020 21:34:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603748056; bh=xqB3X08bN2svUASvlYu38zyWDmiDAAvYC7985pJeF4g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=jZ0aIlPb6GwqgwJxMyDEaeBIrFeWW7s5GnOyQh1KJqhuP9O/DrXwepsJ4C9TR+Zt/ wfJSedIrIKShGUOMDo0aLvKBOzxrUT4AZqoadBQUJm7QrwvqGZVjPLwwMrzl+KvdTT 17aQyWmT030qNqN7GVCX3691V1Jgr52e67Ss1OAg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389485AbgJZVeP (ORCPT ); Mon, 26 Oct 2020 17:34:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:45022 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733242AbgJZVeO (ORCPT ); Mon, 26 Oct 2020 17:34:14 -0400 Received: from localhost.localdomain (unknown [192.30.34.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DFD3207C4; Mon, 26 Oct 2020 21:34:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603748054; bh=xqB3X08bN2svUASvlYu38zyWDmiDAAvYC7985pJeF4g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kYovXbsBze1BmDe27+xif23hvxMIpGhp9aPbxWLlDRr4FYNP1Ant6CcdBwSQlkAlF XWgpTqfxbKNoCySSINjmmqcD7Jve0DekqlN6cxHgiDfRrbLkTgTjv23VTNfD2VnQN/ LPCfPlu2NNPYKO44FVt+sg5vW9fVs1V1l1gGDTQQ= From: Arnd Bergmann To: Ayush Sawal , Vinay Kumar Yadav , Rohit Maheshwari , "David S. Miller" , Jakub Kicinski Cc: Arnd Bergmann , YueHaibing , "Gustavo A. R. Silva" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 10/11] ch_ktls: fix enum-conversion warning Date: Mon, 26 Oct 2020 22:29:57 +0100 Message-Id: <20201026213040.3889546-10-arnd@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201026213040.3889546-1-arnd@kernel.org> References: <20201026213040.3889546-1-arnd@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Arnd Bergmann gcc points out an incorrect enum assignment: drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c: In function 'chcr_ktls_cpl_set_tcb_rpl': drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c:684:22: warning: implicit conversion from 'enum ' to 'enum ch_ktls_open_state' [-Wenum-conversion] This appears harmless, and should apparently use 'CH_KTLS_OPEN_SUCCESS' instead of 'false', with the same value '0'. Fixes: efca3878a5fb ("ch_ktls: Issue if connection offload fails") Signed-off-by: Arnd Bergmann Reviewed-by: Andrew Lunn --- drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c b/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c index 5195f692f14d..83787f62577d 100644 --- a/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c +++ b/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c @@ -681,7 +681,7 @@ static int chcr_ktls_cpl_set_tcb_rpl(struct adapter *adap, unsigned char *input) kvfree(tx_info); return 0; } - tx_info->open_state = false; + tx_info->open_state = CH_KTLS_OPEN_SUCCESS; spin_unlock(&tx_info->lock); complete(&tx_info->completion);