From patchwork Wed Sep 23 10:05:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tang Bin X-Patchwork-Id: 260332 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32A1BC4727F for ; Wed, 23 Sep 2020 10:15:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E68FE2076E for ; Wed, 23 Sep 2020 10:15:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726548AbgIWKPr (ORCPT ); Wed, 23 Sep 2020 06:15:47 -0400 Received: from cmccmta1.chinamobile.com ([221.176.66.79]:15905 "EHLO cmccmta1.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726328AbgIWKPr (ORCPT ); Wed, 23 Sep 2020 06:15:47 -0400 X-Greylist: delayed 591 seconds by postgrey-1.27 at vger.kernel.org; Wed, 23 Sep 2020 06:15:44 EDT Received: from spf.mail.chinamobile.com (unknown[172.16.121.3]) by rmmx-syy-dmz-app01-12001 (RichMail) with SMTP id 2ee15f6b1df2a4a-86392; Wed, 23 Sep 2020 18:05:40 +0800 (CST) X-RM-TRANSID: 2ee15f6b1df2a4a-86392 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[223.112.105.130]) by rmsmtp-syy-appsvr02-12002 (RichMail) with SMTP id 2ee25f6b1df1e3d-8f271; Wed, 23 Sep 2020 18:05:40 +0800 (CST) X-RM-TRANSID: 2ee25f6b1df1e3d-8f271 From: Tang Bin To: davem@davemloft.net, andrew@lunn.ch, hkallweit1@gmail.com, kuba@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tang Bin , Zhang Shengju Subject: [PATCH] net: mdio: Remove redundant parameter and check Date: Wed, 23 Sep 2020 18:05:32 +0800 Message-Id: <20200923100532.18452-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In the function ipq8064_mdio_probe(), of_mdiobus_register() might returned zero, so the direct return can simplify code. Thus remove redundant parameter and check. Signed-off-by: Zhang Shengju Signed-off-by: Tang Bin --- drivers/net/mdio/mdio-ipq8064.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/mdio/mdio-ipq8064.c b/drivers/net/mdio/mdio-ipq8064.c index 1bd1885..33cccce 100644 --- a/drivers/net/mdio/mdio-ipq8064.c +++ b/drivers/net/mdio/mdio-ipq8064.c @@ -102,7 +102,6 @@ ipq8064_mdio_probe(struct platform_device *pdev) struct device_node *np = pdev->dev.of_node; struct ipq8064_mdio *priv; struct mii_bus *bus; - int ret; bus = devm_mdiobus_alloc_size(&pdev->dev, sizeof(*priv)); if (!bus) @@ -125,12 +124,9 @@ ipq8064_mdio_probe(struct platform_device *pdev) return PTR_ERR(priv->base); } - ret = of_mdiobus_register(bus, np); - if (ret) - return ret; - platform_set_drvdata(pdev, bus); - return 0; + + return of_mdiobus_register(bus, np); } static int