From patchwork Wed Aug 26 09:33:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248380 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4155624ils; Wed, 26 Aug 2020 02:35:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwLabcaf1e/MYDcqeKRtFFWwoD2Nks5EHwTNkheHLShNyiuSHPIxd0bwbfJi5zVt/Eg+x0 X-Received: by 2002:a17:906:3647:: with SMTP id r7mr10957860ejb.336.1598434535822; Wed, 26 Aug 2020 02:35:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434535; cv=none; d=google.com; s=arc-20160816; b=ne2cC9AtF1i2htoKQUBYgSTqAgTCSfliWc2nTev0X/ccgqF3QXFckgAcAes2O7csWD mBj/fZFB4uD0VapDKUllcWLsUPLinJzvuqeB7rV/HSi/TmuGtrA4HTQiQWV4a40pvEMn hK+pp2+Ry9qEL+kvJ/v2n3s0H6OnT5cFC2Un3i24+wu3MpISGWXDCj0Ea3t9KFvuWwPg ZToPAtqHI69/d/LwatINDbAw5UWTQakFkuq9SBRY7fX7uOXi1zSmGZEGzmyMzebT0Ati iZ1U+ZtLDU+8e+oCxLYQ3JsTA0rPATQhVAO3jveMWUFwa/gbevP8mt16zOjYTsok616q DXhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gXj0QTNi35Mkf/0PfjV36Op7KYk+Sf8/3WVle5YvISs=; b=ULQ0+mk9XlJ91C2DQNOPHuBmqbwEArewd/ZKCMqeMgXdX49baelLKJTt+ZgfDNzZE+ qG9pPHxG1LJMOK51w9T1M8Oyb0cAwQ/NgqvNcvVW+w9TSGeQN54WKu2KgXQhNOgf4jST Xvf0ymcvAtZuNp0uZ7pbFqpw/svS4/dipVjsfzw28WLQp4K3aF56RdZ/qnGANWWG4vU9 Dn+Fsyd/KgsF6oNb5YmUVly7O1E0pi6SvDix5ZBSusbKTi3kqtEpsVayZQzH94PqlR2Y vwGNSnfMCCAJFeUdO4X0DiNIMAetICrBaPWwjQUe56Jbloeo2ePyHRlgNGseDSzxTd1z 9jMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LwLU6UgN; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d13si1160336ejd.721.2020.08.26.02.35.35; Wed, 26 Aug 2020 02:35:35 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LwLU6UgN; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728405AbgHZJfS (ORCPT + 9 others); Wed, 26 Aug 2020 05:35:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728342AbgHZJes (ORCPT ); Wed, 26 Aug 2020 05:34:48 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D18CC061798 for ; Wed, 26 Aug 2020 02:34:26 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id u18so1075151wmc.3 for ; Wed, 26 Aug 2020 02:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gXj0QTNi35Mkf/0PfjV36Op7KYk+Sf8/3WVle5YvISs=; b=LwLU6UgNWRhkAICyUcI0WTYo9m6TXWqPAHELcWqUYunSe14/NoTP2Wi3SxwnjRCPYp P8ToArmn9LBzbGkBXZ5NsJr3JcJPxfj4PgpcLvujetjrJ+klZkFbwpqK7c0ENSxr3mNx TZxfs6nglopjKXRQRLOaqoCUM9q4GccbGnin36RbIYanIqRUXWquVts5sYLDdBZYOzzb vAyKkiZ+aFleQE2DfWIpFhUJ+MAVRqtkvonJgyFAONhAPazcEjwPOHxWz+EVcNksSV7I vfNUXi6Qw+KqfZKelE0ChGdvsvJPlz3owrqDYGcVtd3723oXffVMm074IevYrbmxxaLj Gs8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gXj0QTNi35Mkf/0PfjV36Op7KYk+Sf8/3WVle5YvISs=; b=IV58cYNs/jAhdv3YppI9/XY0fZm5zRJ10H+il+68XNyqPW2fve/7NV6p8HsYtQGfQD LwF7AD0YcXn7D+ssOvSUUpPsQavxFyo+n4+NuC6ZNvhYBMY5Nm2CtzmpK057MsMjj3U+ tjM0nJdPuAsmMVPLJBvfdStCrpwD8CGHl0LoPaninydvJkQofoGvKOKxM1ZU7f89+EV6 XX+5f4SxkleWXFGut2X5pXsX4t0g0Nl9BsXOhmv8wkk39k1/3nbd48zREymNVXedqhPe gAVHmpUMnBieXHgpo1txTbvOX8gRVy3amVE+bYRmSCVmXVb59LL9I/lk10B1MT7r6fLD cvYQ== X-Gm-Message-State: AOAM533hit6FGIBOaE0yPKlfADoRX6c6nsuU+FfP9G3v1jjMDSPbpVYf Ut8AAi5+VVLQkv94uMVavQNnsw== X-Received: by 2002:a1c:c913:: with SMTP id f19mr5945307wmb.173.1598434464899; Wed, 26 Aug 2020 02:34:24 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:24 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Amitkumar Karwar , Siva Rebbagondla Subject: [PATCH 16/30] wireless: rsi: rsi_91x_sdio: Fix a few kernel-doc related issues Date: Wed, 26 Aug 2020 10:33:47 +0100 Message-Id: <20200826093401.1458456-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org - File headers do not make for good kernel-doc candidates - Kernel-doc header lines should start with " *" - Fix doc-rot issue Fixes the following W=1 kernel build warning(s): drivers/net/wireless/rsi/rsi_91x_sdio.c:25: warning: cannot understand function prototype: 'u16 dev_oper_mode = DEV_OPMODE_STA_BT_DUAL; ' drivers/net/wireless/rsi/rsi_91x_sdio.c:802: warning: bad line: from the device. drivers/net/wireless/rsi/rsi_91x_sdio.c:842: warning: Function parameter or member 'pfunction' not described in 'rsi_init_sdio_interface' drivers/net/wireless/rsi/rsi_91x_sdio.c:842: warning: Excess function parameter 'pkt' description in 'rsi_init_sdio_interface' Cc: Amitkumar Karwar Cc: Siva Rebbagondla Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/rsi/rsi_91x_sdio.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/rsi/rsi_91x_sdio.c b/drivers/net/wireless/rsi/rsi_91x_sdio.c index a04ff75c409f4..a7b8684143f46 100644 --- a/drivers/net/wireless/rsi/rsi_91x_sdio.c +++ b/drivers/net/wireless/rsi/rsi_91x_sdio.c @@ -1,4 +1,4 @@ -/** +/* * Copyright (c) 2014 Redpine Signals Inc. * * Permission to use, copy, modify, and/or distribute this software for any @@ -799,7 +799,7 @@ static int rsi_sdio_host_intf_write_pkt(struct rsi_hw *adapter, /** * rsi_sdio_host_intf_read_pkt() - This function reads the packet - from the device. + * from the device. * @adapter: Pointer to the adapter data structure. * @pkt: Pointer to the packet data to be read from the the device. * @length: Length of the data to be read from the device. @@ -832,11 +832,10 @@ int rsi_sdio_host_intf_read_pkt(struct rsi_hw *adapter, * rsi_init_sdio_interface() - This function does init specific to SDIO. * * @adapter: Pointer to the adapter data structure. - * @pkt: Pointer to the packet data to be read from the the device. + * @pfunction: Pointer to the sdio_func structure. * * Return: 0 on success, -1 on failure. */ - static int rsi_init_sdio_interface(struct rsi_hw *adapter, struct sdio_func *pfunction) {