From patchwork Wed Aug 26 09:33:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248398 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4157496ils; Wed, 26 Aug 2020 02:39:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBqHRCk0mehhNdhdpvIP2p28zs48Ln8Y4/YZ6vrsSsUhaFeXNFJERsVJkRjPH87vU2LRr+ X-Received: by 2002:a17:906:3399:: with SMTP id v25mr14398883eja.383.1598434746662; Wed, 26 Aug 2020 02:39:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434746; cv=none; d=google.com; s=arc-20160816; b=qyH3POOSnlcF57CyT929SZUcs0DzDNcBBc2TXUpKEIUrL143k+tnM0aWzkH/pPsToa 0w34mGH7pCZapIeY6wiDEMLfkfUZfxI14g8F/ldj4tNUC8bQYKMFJpFYptrH/hiwFZ3w nIR7ZuiKYp6GMnojZscnHJ9NNDq+EfL6BYkVqEe0kkB8QLWuT5JlrWnANiZtWrr5SvqJ JrISlkg7sBiVr9A383L7EQUZc8xWlh7Rgu8fO6QhSkqQv+LsqZGCvvg6gCDFmMr4O40X tzvfV27N6eWRKci9hQeb/P2alzEvBQc6VbzjN/OyM4rOcZzL2mnHmI2oYwK4RIJBT9/n apYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=lOqkWcILbsAeyAfZ0GfzIi50eF5PW2PXQFze4naQS2g=; b=MH7ca/6MMuOi7Pz6FlSS/93V+kHf8/B1snQTx05BCki7hdVjCKeLGGxtus1nFUxgKV N9M1uk784NcfKv6QDDXj96iZILfBkX8QhgeA4kNGwgfcH/BMwdzdnUvwLSOHtGeyG4xt c1L/cQ50KRXF8QzlDZvyeKJI1hZaPbeYhFyEMS1QjbPZnmr5LwFKlktE4I1QJU53zi50 1xUYzYKZqtfLLTPjHdT+DUaUUMEuQcG+6Kx5A0P0O6WOqUrUhsAMasohqoou3RrHXDBv Ncz/SVxp8UQyMEUXid/tT4wCzQeIw9n80PD/BxIFy88ApY2+BTjVqW2B/AhOQnRIPcOp GfPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QHJKMOnZ; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id va1si1202798ejb.558.2020.08.26.02.39.06; Wed, 26 Aug 2020 02:39:06 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QHJKMOnZ; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728025AbgHZJjE (ORCPT + 9 others); Wed, 26 Aug 2020 05:39:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728218AbgHZJeb (ORCPT ); Wed, 26 Aug 2020 05:34:31 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14CD1C061384 for ; Wed, 26 Aug 2020 02:34:19 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id b79so482679wmb.4 for ; Wed, 26 Aug 2020 02:34:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lOqkWcILbsAeyAfZ0GfzIi50eF5PW2PXQFze4naQS2g=; b=QHJKMOnZ4tO+oPpdZO1XclI2udxtKXtC1n+sqUbOkrkLwibykUsRORT51V6Hkmmgh/ t2XgThhanyCXXUkHdhqimUKMlX98ujIdPf048s1aR3v7hgOP3/8q7x/nJ8HBBGos6wf8 lSorCwKC8Zxsxlntp2BNMFDaeK0yCVuJD9uU7Uo7WOoeNbsJRrDgCyd5OmboxWIMY+b+ ULLaynAuXVhaNpZirlsqEfKY/DHuk8Qzqjwm4x84UNsBiHXJPjegYxVr+KnAjZFTTFW3 Zk8AF2IVK+2d7F/ED6AGsvg9yf18ULdammO9EEvq9dfHEq7n6Vt5AIRLCwep9X2DZRiD E6PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lOqkWcILbsAeyAfZ0GfzIi50eF5PW2PXQFze4naQS2g=; b=a4//8BRAZ/Ts+6qmQMqedroo/TA4uCeJnmcnQCHWVWZWPt5Q4u+U2G3GW3tkdD6+OU pjIC0Ruyn13BMhb+OHhhGPxgdIk+MyD6ZC0ipO2NsvU41dpoQADmE616LATWfHKHvmZu YPXuQwvBEOWpYaYBg0Nn59rcZz5ftLCAhHDL2naxE56qwCcoGv8aM8yRcgEPa29o6CYV ox4uKonh2fjicj1+93vMrEYC/7Q9O+bEEkB6pEl2VQwfzdOQ+RxQhKCJ2qOQd96SFGas HK2cKh0vPmOIKOySxuB0D5yYeoyNests/byPwfllBtyOy+wGRdi16bpQWenh1M6SqOlB uBbg== X-Gm-Message-State: AOAM531IX7NF865T6gMMAj8ae4WMH80XOS3uEVqreWJ7gNiVTUbPby8A M/IeyIKGZeJnVzCBK8gm0JHI9g== X-Received: by 2002:a1c:cc05:: with SMTP id h5mr5870886wmb.129.1598434457697; Wed, 26 Aug 2020 02:34:17 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:17 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Daniel Drake , Ulrich Kunitz , Michael Wu , "Luis R. Rodriguez" Subject: [PATCH 10/30] wireless: zydas: zd1211rw: zd_mac: Add missing or incorrect function documentation Date: Wed, 26 Aug 2020 10:33:41 +0100 Message-Id: <20200826093401.1458456-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/zydas/zd1211rw/zd_mac.c:433: warning: Function parameter or member 'hw' not described in 'zd_mac_tx_status' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:433: warning: Function parameter or member 'skb' not described in 'zd_mac_tx_status' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:433: warning: Function parameter or member 'tx_status' not described in 'zd_mac_tx_status' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:433: warning: Excess function parameter 'flags' description in 'zd_mac_tx_status' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:487: warning: Function parameter or member 'urb' not described in 'zd_mac_tx_failed' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:487: warning: Excess function parameter 'dev' description in 'zd_mac_tx_failed' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:927: warning: Function parameter or member 'hw' not described in 'zd_op_tx' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:927: warning: Excess function parameter 'dev' description in 'zd_op_tx' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:963: warning: Function parameter or member 'hw' not described in 'filter_ack' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:963: warning: Excess function parameter 'dev' description in 'filter_ack' Cc: Daniel Drake Cc: Ulrich Kunitz Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Michael Wu Cc: "Luis R. Rodriguez" Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/zydas/zd1211rw/zd_mac.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c index a9999d10ae81f..3ef8533205f91 100644 --- a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c +++ b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c @@ -416,11 +416,10 @@ int zd_restore_settings(struct zd_mac *mac) /** * zd_mac_tx_status - reports tx status of a packet if required - * @hw - a &struct ieee80211_hw pointer - * @skb - a sk-buffer - * @flags: extra flags to set in the TX status info + * @hw: a &struct ieee80211_hw pointer + * @skb: a sk-buffer * @ackssi: ACK signal strength - * @success - True for successful transmission of the frame + * @tx_status: success and/or retry * * This information calls ieee80211_tx_status_irqsafe() if required by the * control information. It copies the control information into the status @@ -477,7 +476,7 @@ static void zd_mac_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb, /** * zd_mac_tx_failed - callback for failed frames - * @dev: the mac80211 wireless device + * @urb: pointer to the urb structure * * This function is called if a frame couldn't be successfully * transferred. The first frame from the tx queue, will be selected and @@ -913,9 +912,9 @@ static int fill_ctrlset(struct zd_mac *mac, /** * zd_op_tx - transmits a network frame to the device * - * @dev: mac80211 hardware device - * @skb: socket buffer + * @hw: a &struct ieee80211_hw pointer * @control: the control structure + * @skb: socket buffer * * This function transmit an IEEE 802.11 network frame to the device. The * control block of the skbuff will be initialized. If necessary the incoming @@ -946,7 +945,7 @@ static void zd_op_tx(struct ieee80211_hw *hw, /** * filter_ack - filters incoming packets for acknowledgements - * @dev: the mac80211 device + * @hw: a &struct ieee80211_hw pointer * @rx_hdr: received header * @stats: the status for the received packet *