From patchwork Fri Aug 21 07:16:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248092 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp104485ils; Fri, 21 Aug 2020 00:18:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnMQq2aBYSDggiLjV8hNTdBsu84yYTdPnu26nwk5Z7iXtgjKc9V+ZHebWFG7/x+n1OUEmL X-Received: by 2002:a05:6402:3070:: with SMTP id bs16mr1379919edb.269.1597994313244; Fri, 21 Aug 2020 00:18:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597994313; cv=none; d=google.com; s=arc-20160816; b=JwjT3t3+WeiDGUFgM2SaZtOx83olouhNT7LgszC/mRnG08B3OvbX+0yelWPs9M4b3G ci1BVMTVrV2P5bLDb/9QIMRC9D1mYtvUvHL3ufKpN+l/bGjOxbujS9RCVIO6cneeM1rm ptYifchQ/plVgLR2D7RAdwM6AyQShl8GtxkIppNfgrYbjK/r6pE1vg5rmEh+NNasEV0P 9OlhsjrpYIQXm1ESJnEyTHSrTnrtH8mhQwABPP7rPgz83s0MKcdnxCL+XAeVxIMI6Kra peK5rmIrMTtX8BIqEk8Le2txKzkOaIDd069Et2SPBk8WdX/YThQgjCGgvbru0X0PCTHv uwhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4gn8qz7mdeM+KJv2Goskpg63XeKb8kIfVsEGkRwpuww=; b=Zi6AzYx+G3RkJ9UEFCvj2pp+F36d3IivtLbSYtX/Y31oP3SLCCZEyMqafZSyPLDq5S snssnlRzC4U4vz6ggc9okSUjv6l5slUlidmXpX5+ZdzAh41MpMahpqsNx88WFWyqGasz JgHgNqwGQ3eSpJJJNuO3o96eG7OiaV2Bt5X+ullmrnKuQVetf6/oUwQd3qo+6jWPsbDO 4fB112Z3aJo+H/4R7sL0LOnq49Qk9u9nWcY6IhFZe9er/E8NVBuBXCidDGBue+YIpAWe l5e0ZBUyqu423WJHux181+ZXkR7+vhbh9Ob6fhuHl+iW4j0tjkZX+aTu40jybiS/+RP+ QzDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=apPHSRdg; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s13si692554edx.216.2020.08.21.00.18.33; Fri, 21 Aug 2020 00:18:33 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=apPHSRdg; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728327AbgHUHS3 (ORCPT + 9 others); Fri, 21 Aug 2020 03:18:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728223AbgHUHSE (ORCPT ); Fri, 21 Aug 2020 03:18:04 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 318F0C061378 for ; Fri, 21 Aug 2020 00:17:18 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id x5so838474wmi.2 for ; Fri, 21 Aug 2020 00:17:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4gn8qz7mdeM+KJv2Goskpg63XeKb8kIfVsEGkRwpuww=; b=apPHSRdgB/3MNG9reCq6xCgMRg/mCa41Z1HvbnqH9l0KRmFouQgus1aGJwwdw7B8q4 lA4IBmkje2fpTJ1SENRtLaEbN0xpteqLL/wJM0p8JUOGlPG6OEkdtRLdMxcFm/lkOw1K 1QkADdlGZaTWJ6ksQKuJ5Qpc689mVRZ0YeoOtFkF10hogtepQz4qUnyNdtjGB8F4k5wv i3YHHHEUCBjPmO9BePTSH+6HhVAdjo9gxFZepAKpMHKED7wwxZnaID1PJ2n4aH1Ri6oN iW3+IlyFqizs2X2OJ3TFSlOQSOJyOmUKIVFuj7v8+is/3v7gFcViIYsFkOVsokzJDFrB TkjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4gn8qz7mdeM+KJv2Goskpg63XeKb8kIfVsEGkRwpuww=; b=ioQ8Kt1GvIwuwREuUP3fH6kXJyHMpzxLueM86eurnKmar0U4jLT6uV7/CRqMy/UELU LpiRRd8b0MkSUwV2uCDz0UCnvHVRB3GaRIWu73C2uo+ZsW8YY7TYd47O+yXcEiynoGUo yH3+L2GfeLsY5D4oCYQUNgn44X5uFtDnXtdVva7snwIEg90X3DXWL6MSxjTVyCv25nBl MyNV8D08Vm0syFKLkgixh+RluIVG534hQoZ597XM/66+6XwVgofNxrk8hhrNHSZwMRrg ClQa9vX+HT9E7u6wpOtrJR4Yrm1pqpYVCdFxFoM8mKj/YiXGKs8TXR/hXUno6ScwKFgJ JLWA== X-Gm-Message-State: AOAM531b8D4L4jzjFTl9dHZhaUS7UDRJKcQYgL7Iv8VoqbOmvI5rMTZJ YiPtCsS+spx7OJT1ilFfe0O6YQ== X-Received: by 2002:a1c:105:: with SMTP id 5mr2444020wmb.83.1597994235935; Fri, 21 Aug 2020 00:17:15 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id y24sm2667957wmi.17.2020.08.21.00.17.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2020 00:17:15 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Stanislaw Gruszka , Linux Wireless Subject: [PATCH 22/32] wireless: intel: iwlegacy: 4965-rs: Demote non kernel-doc headers to standard comment blocks Date: Fri, 21 Aug 2020 08:16:34 +0100 Message-Id: <20200821071644.109970-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200821071644.109970-1-lee.jones@linaro.org> References: <20200821071644.109970-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlegacy/4965-rs.c:156: warning: cannot understand function prototype: 's32 expected_tpt_legacy[RATE_COUNT] = ' drivers/net/wireless/intel/iwlegacy/4965-rs.c:406: warning: Function parameter or member 'tbl' not described in 'il4965_rs_collect_tx_data' drivers/net/wireless/intel/iwlegacy/4965-rs.c:406: warning: Function parameter or member 'scale_idx' not described in 'il4965_rs_collect_tx_data' drivers/net/wireless/intel/iwlegacy/4965-rs.c:406: warning: Function parameter or member 'attempts' not described in 'il4965_rs_collect_tx_data' drivers/net/wireless/intel/iwlegacy/4965-rs.c:406: warning: Function parameter or member 'successes' not described in 'il4965_rs_collect_tx_data' drivers/net/wireless/intel/iwlegacy/4965-rs.c:629: warning: Function parameter or member 'il' not described in 'il4965_rs_use_green' drivers/net/wireless/intel/iwlegacy/4965-rs.c:629: warning: Function parameter or member 'sta' not described in 'il4965_rs_use_green' drivers/net/wireless/intel/iwlegacy/4965-rs.c:645: warning: Function parameter or member 'lq_sta' not described in 'il4965_rs_get_supported_rates' drivers/net/wireless/intel/iwlegacy/4965-rs.c:645: warning: Function parameter or member 'hdr' not described in 'il4965_rs_get_supported_rates' drivers/net/wireless/intel/iwlegacy/4965-rs.c:645: warning: Function parameter or member 'rate_type' not described in 'il4965_rs_get_supported_rates' drivers/net/wireless/intel/iwlegacy/4965-rs.c:2130: warning: duplicate section name 'NOTE' drivers/net/wireless/intel/iwlegacy/4965-rs.c:2134: warning: Function parameter or member 'il' not described in 'il4965_rs_initialize_lq' drivers/net/wireless/intel/iwlegacy/4965-rs.c:2134: warning: Function parameter or member 'conf' not described in 'il4965_rs_initialize_lq' drivers/net/wireless/intel/iwlegacy/4965-rs.c:2134: warning: Function parameter or member 'sta' not described in 'il4965_rs_initialize_lq' drivers/net/wireless/intel/iwlegacy/4965-rs.c:2134: warning: Function parameter or member 'lq_sta' not described in 'il4965_rs_initialize_lq' Cc: Stanislaw Gruszka Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Linux Wireless Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/iwlegacy/4965-rs.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/intel/iwlegacy/4965-rs.c b/drivers/net/wireless/intel/iwlegacy/4965-rs.c index 1f196665d21f1..9a491e5db75bd 100644 --- a/drivers/net/wireless/intel/iwlegacy/4965-rs.c +++ b/drivers/net/wireless/intel/iwlegacy/4965-rs.c @@ -142,7 +142,7 @@ il4965_rs_dbgfs_set_mcs(struct il_lq_sta *lq_sta, u32 * rate_n_flags, int idx) } #endif -/** +/* * The following tables contain the expected throughput metrics for all rates * * 1, 2, 5.5, 11, 6, 9, 12, 18, 24, 36, 48, 54, 60 MBits @@ -393,7 +393,7 @@ il4965_get_expected_tpt(struct il_scale_tbl_info *tbl, int rs_idx) return 0; } -/** +/* * il4965_rs_collect_tx_data - Update the success/failure sliding win * * We keep a sliding win of the last 62 packets transmitted @@ -620,7 +620,7 @@ il4965_rs_toggle_antenna(u32 valid_ant, u32 *rate_n_flags, return 1; } -/** +/* * Green-field mode is valid if the station supports it and * there are no non-GF stations present in the BSS. */ @@ -631,7 +631,7 @@ il4965_rs_use_green(struct il_priv *il, struct ieee80211_sta *sta) !il->ht.non_gf_sta_present; } -/** +/* * il4965_rs_get_supported_rates - get the available rates * * if management frame or broadcast frame only return @@ -2114,7 +2114,7 @@ il4965_rs_rate_scale_perform(struct il_priv *il, struct sk_buff *skb, lq_sta->last_txrate_idx = i; } -/** +/* * il4965_rs_initialize_lq - Initialize a station's hardware rate table * * The uCode's station table contains a table of fallback rates