From patchwork Fri Aug 21 07:16:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248109 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp106359ils; Fri, 21 Aug 2020 00:21:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxsek8oJTiER7rZI9HwEtslVX3vrFA/gW+W51tIER8FQjW4HGwEWEp9dvac1+uU/sM6eEIC X-Received: by 2002:a17:906:a253:: with SMTP id bi19mr1600972ejb.338.1597994510232; Fri, 21 Aug 2020 00:21:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597994510; cv=none; d=google.com; s=arc-20160816; b=tEe3QIxHg1QPbV3/Rm2yma/CWZ4ZUhizqhaJmCnt30ah1QW72wstt6KOsmCFSyfbCe T5n4i2IZkMgN7xmQ8cS7WnF4XfLwiVueWysbru0EeY0PAGXTLTToUH98tJd54NcQBE7O hnipaR/1ES5J0xt8vdBN+9S0csWwUsATEDQ/v3E8My1JEMtkIwqqxQk/5j4nncK1NUMb ZwRjMqKFEFAM5yWyGMOwVWaFk29r8rz5ayaebx8LMKWM5ugvwMHAreKY6N4RAx+fLzNM tYuVmHnv5Wtfo5oiUORPvdv0qv1UZzoAK1Mx3Ntp35BR60sTy5Ei7N3mmoRVoMba4LQn 43Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=R1IXIaJwBVwWNcurZZnrk/N/PocscpFlNi1T2hgjOyE=; b=Gc/KnVQ4pw9VmM1vmuSNOBugD/6g8yIt+W5MoNNmyo+LltYmfgbeHcgnzbP+MZrPTC xT7D5/gwYfL0cmZQhw//juKgrL8JnQAiy2iwBNjpfIUFGscpY6clXJr91Xk9hecLzFBv 8fRscYd4n3UQ8p6PsgoMthmbZEKSORqZ+7er+e4yOLEi6ru2uP/sVSGKWlNQgKv10YYS blJ/7v1sUPQiLL4AyX+Qoc7J4oR4Q6TZFkC9AWwkldaRWkFES/a+TpwtBJgEgD/MBkx9 ZucBw0DMqRKvfM/T8jsXpMvhAosufoFqDqH0vN/r0GqOW8J0hw+wZlsxCKqyU7G2qGc6 XGfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="lFDRLu/z"; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n13si597642eje.393.2020.08.21.00.21.50; Fri, 21 Aug 2020 00:21:50 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="lFDRLu/z"; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728594AbgHUHVm (ORCPT + 9 others); Fri, 21 Aug 2020 03:21:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728131AbgHUHRg (ORCPT ); Fri, 21 Aug 2020 03:17:36 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35AF7C061365 for ; Fri, 21 Aug 2020 00:17:10 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id p14so842684wmg.1 for ; Fri, 21 Aug 2020 00:17:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=R1IXIaJwBVwWNcurZZnrk/N/PocscpFlNi1T2hgjOyE=; b=lFDRLu/zcyf4hbmckt7lqVi6V3P0yLBvPW+LRjvyXB3Ko0P2bH6UYA5+veGuOE/tgN lIyuTYTUuTwIEvFv+qtX/eTLAioT4CNre54eXgrh13hckcWrJSjVJeBtK6OdMLtCbhgc Hq+S3wgc0FAN94y6W+z8bFEFdAhtc70B+3+lOSD3JyWJ0jjq6jTTbLJzRPDkhqxEvHiC 6JWbPGefBcniOGWMCcZN0Xwg0M8jRBRFqakFrmQe1RS14P72SqqOP8N5mfCWIbzztYAf gLEPk2DpnbH8caK1gNSC7Hj4Ex9XjLxZRGVaI7AUf1u5mrWq/lBx1kkVhAVkG+ERS2ON DyLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R1IXIaJwBVwWNcurZZnrk/N/PocscpFlNi1T2hgjOyE=; b=cfR5yhuBp+QlfKrc4jw/o2vR5CQsz4eBNO21iAiDG/t2cRmGoTboA2LqIMzO64tZD8 RJQyd+kVKOYGntji3abtxqOcMb38fMy1g2KL11PD7rlYr27rgwptpA7z6X4z7Os9Fgro XQmPSb4Fs0EC8gGSQ8PZrdymdWvrM3whlRG0YGv2/kIug2nBHCi5uSTTavDaBrNjUS62 JtjrJxfswKz2VHVRNlhYalfgJfqCEuUbkFjsG8V3EIFd18nMnazgzmg2LYgchMB1yywk VKeon3CYofzq7Fs0lrxd/J0HDbwXJd7EZ4Q0fD8GubvTU+U5U8IcO3HaPpMWPfZC0ioP sKJg== X-Gm-Message-State: AOAM531u5SiNAHGHWX+ZIPh8j0On3j+uzeJUnI+9aW6+SKX98FE3JCAO FsKdzz63skU/jxgoqI1B8/Vm4g== X-Received: by 2002:a7b:c219:: with SMTP id x25mr2293147wmi.101.1597994228439; Fri, 21 Aug 2020 00:17:08 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id y24sm2667957wmi.17.2020.08.21.00.17.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2020 00:17:07 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com Subject: [PATCH 16/32] wireless: brcm80211: btcoex: Update 'brcmf_btcoex_state' and demote others Date: Fri, 21 Aug 2020 08:16:28 +0100 Message-Id: <20200821071644.109970-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200821071644.109970-1-lee.jones@linaro.org> References: <20200821071644.109970-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The function headers are either very weakly documented or not at all. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:94: warning: Function parameter or member 'reg50' not described in 'brcmf_btcoex_info' drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:94: warning: Function parameter or member 'saved_regs_part2' not described in 'brcmf_btcoex_info' drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:233: warning: Function parameter or member 'btci' not described in 'btcmf_btcoex_save_part1' drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:253: warning: Function parameter or member 'btci' not described in 'brcmf_btcoex_restore_part1' drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:273: warning: Function parameter or member 't' not described in 'brcmf_btcoex_timerfunc' drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:453: warning: Function parameter or member 'vif' not described in 'brcmf_btcoex_set_mode' drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:453: warning: Function parameter or member 'duration' not described in 'brcmf_btcoex_set_mode' drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:453: warning: Excess function parameter 'cfg' description in 'brcmf_btcoex_set_mode' Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Chi-Hsien Lin Cc: Wright Feng Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list.pdl@broadcom.com Cc: brcm80211-dev-list@cypress.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../wireless/broadcom/brcm80211/brcmfmac/btcoex.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c index ec2bec0999d1b..f9f18ff451ea7 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c @@ -65,11 +65,12 @@ enum brcmf_btcoex_state { * @reg68: saved value of btc_params 68 * @saved_regs_part1: flag indicating regs 66,41,68 * have been saved + * @reg50: saved value of btc_params 50 * @reg51: saved value of btc_params 51 * @reg64: saved value of btc_params 64 * @reg65: saved value of btc_params 65 * @reg71: saved value of btc_params 71 - * @saved_regs_part1: flag indicating regs 50,51,64,65,71 + * @saved_regs_part2: flag indicating regs 50,51,64,65,71 * have been saved */ struct brcmf_btcoex_info { @@ -226,7 +227,7 @@ static bool brcmf_btcoex_is_sco_active(struct brcmf_if *ifp) return res; } -/** +/* * btcmf_btcoex_save_part1() - save first step parameters. */ static void btcmf_btcoex_save_part1(struct brcmf_btcoex_info *btci) @@ -246,7 +247,7 @@ static void btcmf_btcoex_save_part1(struct brcmf_btcoex_info *btci) } } -/** +/* * brcmf_btcoex_restore_part1() - restore first step parameters. */ static void brcmf_btcoex_restore_part1(struct brcmf_btcoex_info *btci) @@ -266,7 +267,7 @@ static void brcmf_btcoex_restore_part1(struct brcmf_btcoex_info *btci) } } -/** +/* * brcmf_btcoex_timerfunc() - BT coex timer callback */ static void brcmf_btcoex_timerfunc(struct timer_list *t) @@ -441,9 +442,8 @@ static void brcmf_btcoex_dhcp_end(struct brcmf_btcoex_info *btci) } } -/** +/* * brcmf_btcoex_set_mode - set BT coex mode - * @cfg: driver private cfg80211 data * @mode: Wifi-Bluetooth coexistence mode * * return: 0 on success