From patchwork Thu Aug 20 23:49:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luke Hsiao X-Patchwork-Id: 262163 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC533C433E1 for ; Thu, 20 Aug 2020 23:56:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C60E720702 for ; Thu, 20 Aug 2020 23:56:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c3a3StAt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726974AbgHTX45 (ORCPT ); Thu, 20 Aug 2020 19:56:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727040AbgHTX4W (ORCPT ); Thu, 20 Aug 2020 19:56:22 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5580FC06134D for ; Thu, 20 Aug 2020 16:50:29 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id x6so112582pgx.12 for ; Thu, 20 Aug 2020 16:50:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qobnCFVTWkfs7U2jqVYwHzId3JsX5devmX9LImldd+A=; b=c3a3StAtWKGmtVp43/Aq0TJXS0Om+PYmlXjwTMTJDsGmr7ZolpEHFQWg5sywrzBJ9h /xGEZFlYfzJCAWMHUDyTAHWarS5hhsvt2OUaZHdcMt5695K+hacVkD7TteE52+vrzxae KG6xEWRp9B22cNbcG4n9ZfN38QApkvc9GEBRX8269M2fsP3cB47/fNfDRtRuiwZF2T4e J5zKcBjwF2F65X4JigEawO0E+4HA2+X+SBPYIjA6VCITUCCGh3TNCLyUsqssAu//fGmu VoRcH6kXA92e94ZkR5RWdUjjHC4uoYE55i3rtHotfJv41gVbk+31Pc2S9i0EpT+eMbWY jtQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qobnCFVTWkfs7U2jqVYwHzId3JsX5devmX9LImldd+A=; b=eSau11UOI9JCJ4c15t4qmJtemVV0jo3SUyCd/oCbZTurYiPw2dEpzLUbIzyLbcEZyu 0y+jVw6fip2i4FiYgrnmOdOWKJlkD02PrafRtFcgaI6hrOKcWd7p7dcyvWkGpJzXHB+A 6iysbgEVE/v6E2hx6Dgh/RVNwI7aCXpvVXUfxCBTZTMFgyFXxJeB+OnLGoX5MuLgYQzu AN+0RiFlNAl4ZnBMobGKJie9EFTfJrw0kLOV83cWXwwNKeVOBWEPDrIJ/UTPm1Ry9rVK E3ffSGe+lpJg/tjM4WAiFubnJTQ26re6pMNa8ish+IS2XtrlmthldVVuMlYyLopIvigb I6nw== X-Gm-Message-State: AOAM532V+QcgA0vctRu2lVV1Fth8Gd+rms5mZsbQ7sJrzHRcv7L0WsJU mon/dB67hstZ1Jj43DiaUJoCeZMqKYQ= X-Google-Smtp-Source: ABdhPJxoQTk6TB2x2wRckZC5THjvyjw9L7NBijXzgs1vPfw0a0qxwNvQFL+IDhOyMMF/8vUHCW0Jqg== X-Received: by 2002:a63:af47:: with SMTP id s7mr377554pgo.335.1597967428892; Thu, 20 Aug 2020 16:50:28 -0700 (PDT) Received: from lukehsiao.c.googlers.com.com (40.156.233.35.bc.googleusercontent.com. [35.233.156.40]) by smtp.gmail.com with ESMTPSA id x9sm194815pff.145.2020.08.20.16.50.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2020 16:50:28 -0700 (PDT) From: Luke Hsiao To: David Miller Cc: netdev@vger.kernel.org, Jens Axboe , Luke Hsiao , Arjun Roy , Soheil Hassas Yeganeh , Eric Dumazet Subject: [PATCH net-next 2/2] io_uring: ignore POLLIN for recvmsg on MSG_ERRQUEUE Date: Thu, 20 Aug 2020 16:49:54 -0700 Message-Id: <20200820234954.1784522-3-luke.w.hsiao@gmail.com> X-Mailer: git-send-email 2.28.0.297.g1956fa8f8d-goog In-Reply-To: <20200820234954.1784522-1-luke.w.hsiao@gmail.com> References: <20200820234954.1784522-1-luke.w.hsiao@gmail.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Luke Hsiao Currently, io_uring's recvmsg subscribes to both POLLERR and POLLIN. In the context of TCP tx zero-copy, this is inefficient since we are only reading the error queue and not using recvmsg to read POLLIN responses. This patch was tested by using a simple sending program to call recvmsg using io_uring with MSG_ERRQUEUE set and verifying with printks that the POLLIN is correctly unset when the msg flags are MSG_ERRQUEUE. Signed-off-by: Arjun Roy Signed-off-by: Soheil Hassas Yeganeh Acked-by: Eric Dumazet Signed-off-by: Luke Hsiao --- fs/io_uring.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/fs/io_uring.c b/fs/io_uring.c index dc506b75659c..664ce8739615 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -79,6 +79,7 @@ #include #include #include +#include #define CREATE_TRACE_POINTS #include @@ -4902,7 +4903,8 @@ static __poll_t __io_arm_poll_handler(struct io_kiocb *req, return mask; } -static bool io_arm_poll_handler(struct io_kiocb *req) +static bool io_arm_poll_handler(struct io_kiocb *req, + const struct io_uring_sqe *sqe) { const struct io_op_def *def = &io_op_defs[req->opcode]; struct io_ring_ctx *ctx = req->ctx; @@ -4932,6 +4934,11 @@ static bool io_arm_poll_handler(struct io_kiocb *req) mask |= POLLIN | POLLRDNORM; if (def->pollout) mask |= POLLOUT | POLLWRNORM; + + /* If reading from MSG_ERRQUEUE using recvmsg, ignore POLLIN */ + if (req->opcode == IORING_OP_RECVMSG && (sqe->msg_flags & MSG_ERRQUEUE)) + mask &= ~(POLLIN); + mask |= POLLERR | POLLPRI; ipt.pt._qproc = io_async_queue_proc; @@ -6146,7 +6153,7 @@ static void __io_queue_sqe(struct io_kiocb *req, const struct io_uring_sqe *sqe, * doesn't support non-blocking read/write attempts */ if (ret == -EAGAIN && !(req->flags & REQ_F_NOWAIT)) { - if (!io_arm_poll_handler(req)) { + if (!io_arm_poll_handler(req, sqe)) { punt: ret = io_prep_work_files(req); if (unlikely(ret))