From patchwork Fri Aug 14 11:39:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 247727 Delivered-To: patch@linaro.org Received: by 2002:a92:cc90:0:0:0:0:0 with SMTP id x16csp295630ilo; Fri, 14 Aug 2020 04:44:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzaiqZVaHl3eMkwXEi3pyPW9DYtmwfw8rjI7HqHG5elX/kc9tpVbtRSDkXTRKpnqGLWzUil X-Received: by 2002:a17:906:496:: with SMTP id f22mr1955122eja.180.1597405483669; Fri, 14 Aug 2020 04:44:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597405483; cv=none; d=google.com; s=arc-20160816; b=dKsFVwjznz3W6wPs4UEAIQ3CM/G9pyXC8xQmLCwOE5DvNh7bf524v5EVnmOru01/yV CMaOWOTk9hgU8EJ+/aJnbOCYf7VAtkgE6rEPLhDa9PIe9uY58Dm/P5gxQ0X7LUvkHjJA WeUrtlPT2p/b25QaxEn3qe7fd6pdpMxDEXXvlKL+0rK5Npw3kZsJIm5xlAXBzwF2NWZg nGao5FwH40fLyawMI9hEslyB5BpDsGNnid4ncwagehzZjBXLNR1TlDu97bXtitSYKYSj UK5KebYWQf6rpZQGFWiRXon/dL9YgnyNb2xfl8GwlNHqKojU+0ntfjCXgaJNw96HsPud bIUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hkxne9wZTlAVbAAYNmpFWLXf7r4C/SN/Gq+uNhys7UA=; b=r0kdQMH1/KzR4/JELAUdjiZwfAjnhucL5wIFdjdcn3bT2LDtsgRPMiDan/AFvY7XWk hwLTr1phe/oMraWttNdaY1UwOmILNg8HyUPsq2Cl8JQ00KaX5uRu3bz8VTHMtykZS2iu 8AuRP+KpuW7NNGXVxcLY3JnBZyp+9l1NEY7ra7NO6kWbJ8F2VY+JaQFLnwp/L2zDHNEB uKB/wQAHfWEsE9kkc4pABQ7dLWeXUvvmHStVBJtTb+mpD/WPGXibactziVRh1jC5Vvxx kSY+YCzoBQkV1w01mFOF6TxlouOxHRe4sjXaYVjmLdi/qw6HTyeQMUhQmZTTwvpUvhmG UVKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=A2CVs4qx; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l12si1967942ejn.133.2020.08.14.04.44.43; Fri, 14 Aug 2020 04:44:43 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=A2CVs4qx; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728100AbgHNLjs (ORCPT + 9 others); Fri, 14 Aug 2020 07:39:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728058AbgHNLjo (ORCPT ); Fri, 14 Aug 2020 07:39:44 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9914CC061386 for ; Fri, 14 Aug 2020 04:39:44 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id y3so8076795wrl.4 for ; Fri, 14 Aug 2020 04:39:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hkxne9wZTlAVbAAYNmpFWLXf7r4C/SN/Gq+uNhys7UA=; b=A2CVs4qxFTnXi4JQ4bVs4AIscTO7tdyd0Y7OF/MjFR4l5/KzuytVtCzuwG0uMy1YhR DUCeyZjBaqB/vwjoz0z1VSI/Px1LMQmWIwfl6jpcAFavd+m4XCXkwdeQ7HwjDQPDG9bO GY+fqeWNegJlFO86lIvjBLHy5oIc1tgzzJKq361YEBP8mdl1S0+yOdkr07LRGXMD9Ssk gAGj8iYy3g5kWrBJ+xDi/RPn0IhOgFVIFMb/1cJgruW1nOHYdRx2KCASsrSSR2oA3c6h LgYnaHN4GtwF8UBmS8EksivSmqKxeJ9rQ1H9ZlXQWhp9s63+0+sUmC3NRrynKgnKzMs7 4v/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hkxne9wZTlAVbAAYNmpFWLXf7r4C/SN/Gq+uNhys7UA=; b=DWk2Qr/1bvNG8S/yuu7TiPhNgQO7OuayNtnmzQXvSVVyETu6Cli4qd0I+KE2LpTy2c zfvOTYhqcvbrxmCR8SUwy3bVON69dDafofM8hgh8ZbESxEKgSOGs6UzCZdMqXhArbB0n KXFJ+1X4h/Q1urA4levLIOt4nvz1FgamZzyRo9XbGAw3OeaqND2PO0Y0OA7jzLurdVOx CRuNQp/ptFgyzUps3fG/u8KpTRUetAOnCEvVolF+5kJQ1mTCLwaZduz5FpMbh+Y9/VpU Z5CZF5Fkh59r67w4wGwMoLo4jMBXwPrewn/dWVlTCb3ZdqZrosDheCb/tISj5gAnfdqa qOiw== X-Gm-Message-State: AOAM531UGQZJO1FhF1jpBUVGkfXVty9wNJsFoxNThh8lfK5a40+gtIgx N498JmTMqDNVsuIa2Y6FfLmrBg== X-Received: by 2002:a5d:6a09:: with SMTP id m9mr470749wru.383.1597405183375; Fri, 14 Aug 2020 04:39:43 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id 32sm16409129wrh.18.2020.08.14.04.39.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2020 04:39:42 -0700 (PDT) From: Lee Jones To: davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Shannon Nelson , Heiner Kallweit , Martin Habets , "Michael S. Tsirkin" , Donald Becker , David Hinds , netdev@vger.kernel.org Subject: [PATCH 03/30] net: ethernet: 3com: 3c574_cs: Remove set but unused variables 'tx' and 'rx' Date: Fri, 14 Aug 2020 12:39:06 +0100 Message-Id: <20200814113933.1903438-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200814113933.1903438-1-lee.jones@linaro.org> References: <20200814113933.1903438-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/3com/3c574_cs.c: In function ‘update_stats’: drivers/net/ethernet/3com/3c574_cs.c:954:9: warning: variable ‘tx’ set but not used [-Wunused-but-set-variable] 954 | u8 rx, tx, up; | ^~ drivers/net/ethernet/3com/3c574_cs.c:954:5: warning: variable ‘rx’ set but not used [-Wunused-but-set-variable] 954 | u8 rx, tx, up; | ^~ Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Shannon Nelson Cc: Heiner Kallweit Cc: Martin Habets Cc: "Michael S. Tsirkin" Cc: Donald Becker Cc: David Hinds Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/ethernet/3com/3c574_cs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.25.1 diff --git a/drivers/net/ethernet/3com/3c574_cs.c b/drivers/net/ethernet/3com/3c574_cs.c index ef1c3151fbb24..bd0ada4e81b0f 100644 --- a/drivers/net/ethernet/3com/3c574_cs.c +++ b/drivers/net/ethernet/3com/3c574_cs.c @@ -951,7 +951,7 @@ static struct net_device_stats *el3_get_stats(struct net_device *dev) static void update_stats(struct net_device *dev) { unsigned int ioaddr = dev->base_addr; - u8 rx, tx, up; + u8 up; pr_debug("%s: updating the statistics.\n", dev->name); @@ -972,8 +972,8 @@ static void update_stats(struct net_device *dev) dev->stats.tx_packets += (up&0x30) << 4; /* Rx packets */ inb(ioaddr + 7); /* Tx deferrals */ inb(ioaddr + 8); - rx = inw(ioaddr + 10); - tx = inw(ioaddr + 12); + /* rx */ inw(ioaddr + 10); + /* tx */ inw(ioaddr + 12); EL3WINDOW(4); /* BadSSD */ inb(ioaddr + 12);