From patchwork Fri May 15 21:28:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 219141 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF54AC433DF for ; Fri, 15 May 2020 21:29:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C97E720709 for ; Fri, 15 May 2020 21:29:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589578184; bh=Kfc7RH5wQklFLrTjyZrxyKWCF3lId530z4BZsrN14fM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=zHUqVScFRJ/p7GbBh2KP/YrfuDDT9EA99wKCoDqpJMlEUCElJAB5R6ZUua907IRjE cyneGbHvvLQiVP4MZVLTtepubtDqjZ3sREj24aUGSFtUCW7XC7zp/ia02/Y4zNySV4 +GssVWF3AYChxCk/o21MZJhRSvwqojIA4k/pQsQ0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727910AbgEOV3F (ORCPT ); Fri, 15 May 2020 17:29:05 -0400 Received: from mail-pj1-f68.google.com ([209.85.216.68]:55098 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726261AbgEOV25 (ORCPT ); Fri, 15 May 2020 17:28:57 -0400 Received: by mail-pj1-f68.google.com with SMTP id s69so1476674pjb.4; Fri, 15 May 2020 14:28:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iJHZT4MFB+sxpA2IE8Rn7gYtD/Qc3TQAcYIYNGZYEvg=; b=phgAbbNGhP6J6HCS81WASgrpY9Nrx5oVe49i1im1AEYCMmyduUplIcxbSk128lbn5z TU2mr1DIJBXRCn0klJ41zaK7+lstVO2R1X9Mt3moIhbF1Z2I2T1IaKpUnEJ/hEV6+b/H ZT1TabezFw8DNFr/6SUEIU+ShgnsNkOOShmjegw3aXW3+dPT3rahU/pTRJ3jem3C/UHU nwfLtdSsE3FiPQ13tMm7pqTCk5DHaVzSj8uGfDs+Or0WM7VGkpITCN/69O64+202a897 RiLjpzheuUA9YMRXoR4QSwImyHDd4RymJKRryVL+VOogvxc0LBBast66Ir0BpeFcKCYF dh7g== X-Gm-Message-State: AOAM5307VsbEQwiBDwxoBXLSrs66/8AOC2cJSWO81u8LqRTHytElmFSm FdNIdsjE6atRICRr2kTle1Y= X-Google-Smtp-Source: ABdhPJyXGdNJ50o8iXun3oJYb5kOl4qAS44k7tBrK+zhGB5FrkYaAMjM2mxcrnwWQ+1fLrVtkOdV0w== X-Received: by 2002:a17:902:9f97:: with SMTP id g23mr5721810plq.30.1589578136986; Fri, 15 May 2020 14:28:56 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id m9sm2450255pgd.1.2020.05.15.14.28.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 14:28:55 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id CB94E41EDA; Fri, 15 May 2020 21:28:49 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Rasesh Mody , Sudarsana Kalluru , GR-Linux-NIC-Dev@marvell.com Subject: [PATCH v2 05/15] bna: use new module_firmware_crashed() Date: Fri, 15 May 2020 21:28:36 +0000 Message-Id: <20200515212846.1347-6-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200515212846.1347-1-mcgrof@kernel.org> References: <20200515212846.1347-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: Rasesh Mody Cc: Sudarsana Kalluru Cc: GR-Linux-NIC-Dev@marvell.com Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net/ethernet/brocade/bna/bfa_ioc.c index e17bfc87da90..b3f44a912574 100644 --- a/drivers/net/ethernet/brocade/bna/bfa_ioc.c +++ b/drivers/net/ethernet/brocade/bna/bfa_ioc.c @@ -927,6 +927,7 @@ bfa_iocpf_sm_disabled(struct bfa_iocpf *iocpf, enum iocpf_event event) static void bfa_iocpf_sm_initfail_sync_entry(struct bfa_iocpf *iocpf) { + module_firmware_crashed(); bfa_nw_ioc_debug_save_ftrc(iocpf->ioc); bfa_ioc_hw_sem_get(iocpf->ioc); }