From patchwork Wed Mar 11 22:32:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Kicinski X-Patchwork-Id: 222665 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEC46C0044D for ; Wed, 11 Mar 2020 22:33:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B55A920746 for ; Wed, 11 Mar 2020 22:33:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583966014; bh=Xh5fNeLwNDTlCuNr2PLHmA9tTgD4KBPsrK+Ba8jqZrw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=adel3kj+yHgP3RCjdC0Awpp8H6DgVotMuggv/baCTaFc+Lm8OtdQynq45n7EulpIs g3JW3emMn8EKaDOgHyEVkR2FxtMQHVD4hAvgdesE9z3l0y6bQQ/6rGVxHC7OvG9OQU +iIJsQx+2duc83yUPJ+jdta5olbVN/JizvhjRpxE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387518AbgCKWdd (ORCPT ); Wed, 11 Mar 2020 18:33:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:37954 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730304AbgCKWdQ (ORCPT ); Wed, 11 Mar 2020 18:33:16 -0400 Received: from kicinski-fedora-PC1C0HJN.thefacebook.com (unknown [163.114.132.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6F54620750; Wed, 11 Mar 2020 22:33:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583965996; bh=Xh5fNeLwNDTlCuNr2PLHmA9tTgD4KBPsrK+Ba8jqZrw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VoYb8zNoQbOTkLQCqV1RK4WuAJrj7zSu74zlAaUUW/Xw18sba6CgYekmwy1185nJS UJEmhB04oELeAJnAQqwXd7fcbAMmXX3QRmycPewpge9HxjHhDR0MZn/VpUgggh96W4 qn/4izaHDbj3qiytycMvJqhpCSiBVxUwIkWB9hCg= From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, mkubecek@suse.cz, sathya.perla@broadcom.com, ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com, madalin.bucur@nxp.com, fugang.duan@nxp.com, claudiu.manoil@nxp.com, yisen.zhuang@huawei.com, salil.mehta@huawei.com, jeffrey.t.kirsher@intel.com, jacob.e.keller@intel.com, alexander.h.duyck@linux.intel.com, Jakub Kicinski Subject: [PATCH net-next 07/15] net: e1000: reject unsupported coalescing params Date: Wed, 11 Mar 2020 15:32:54 -0700 Message-Id: <20200311223302.2171564-8-kuba@kernel.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200311223302.2171564-1-kuba@kernel.org> References: <20200311223302.2171564-1-kuba@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Set ethtool_ops->supported_coalesce_params to let the core reject unsupported coalescing parameters. This driver did not previously reject unsupported parameters. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c index be56e631d693..6f45df5690d4 100644 --- a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c +++ b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c @@ -1852,6 +1852,7 @@ static void e1000_get_strings(struct net_device *netdev, u32 stringset, } static const struct ethtool_ops e1000_ethtool_ops = { + .supported_coalesce_params = ETHTOOL_COALESCE_RX_USECS, .get_drvinfo = e1000_get_drvinfo, .get_regs_len = e1000_get_regs_len, .get_regs = e1000_get_regs,