From patchwork Wed Mar 11 22:32:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Kicinski X-Patchwork-Id: 222670 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C87DCC2BAEE for ; Wed, 11 Mar 2020 22:33:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB3742074B for ; Wed, 11 Mar 2020 22:33:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583965995; bh=zd3VNACH1b5TEwQUvLU2e4G56pBnpG1+6DWLkdG8lcQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=a2oVZEhOg19nZE4XdZwaEz8FCeWOIzJ3sBYxiL8pV5VWMGvVUZmE0ubd7eOO1guhF shC5T4zssWC4ijlzT1GcXhzxBHYL45b7t/oEnYZq4vPdUY8kQjDbhcIzLnMtT+YTyG OpUFG1khuCCAOBvu2eqUpx5D3Qaz5+ZvGWy0oU/s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731357AbgCKWdO (ORCPT ); Wed, 11 Mar 2020 18:33:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:37822 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731249AbgCKWdN (ORCPT ); Wed, 11 Mar 2020 18:33:13 -0400 Received: from kicinski-fedora-PC1C0HJN.thefacebook.com (unknown [163.114.132.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ED10920751; Wed, 11 Mar 2020 22:33:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583965993; bh=zd3VNACH1b5TEwQUvLU2e4G56pBnpG1+6DWLkdG8lcQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mkyvnMl/vqhvc/a8Tb6mrFc1GN6z5O2ktJDxh6dRNx7kCCoIYfCRgB/k/iDDNcXzS GBBD1TSYikpIp2bu2nlPWI2q3T2+5iQ3FpRUYrpA9Tgtypdq5p1d1oRV+B9Yg2ybGw s26XHYLM0+pjuw/edgqrC65vf2PKeDrO//sphACA= From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, mkubecek@suse.cz, sathya.perla@broadcom.com, ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com, madalin.bucur@nxp.com, fugang.duan@nxp.com, claudiu.manoil@nxp.com, yisen.zhuang@huawei.com, salil.mehta@huawei.com, jeffrey.t.kirsher@intel.com, jacob.e.keller@intel.com, alexander.h.duyck@linux.intel.com, Jakub Kicinski Subject: [PATCH net-next 04/15] net: gianfar: reject unsupported coalescing params Date: Wed, 11 Mar 2020 15:32:51 -0700 Message-Id: <20200311223302.2171564-5-kuba@kernel.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200311223302.2171564-1-kuba@kernel.org> References: <20200311223302.2171564-1-kuba@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Set ethtool_ops->supported_coalesce_params to let the core reject unsupported coalescing parameters. This driver did not previously reject unsupported parameters. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c index f82e0be4d309..cc7d4f93da54 100644 --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c @@ -1474,6 +1474,8 @@ static int gfar_get_ts_info(struct net_device *dev, } const struct ethtool_ops gfar_ethtool_ops = { + .supported_coalesce_params = ETHTOOL_COALESCE_USECS | + ETHTOOL_COALESCE_MAX_FRAMES, .get_drvinfo = gfar_gdrvinfo, .get_regs_len = gfar_reglen, .get_regs = gfar_get_regs,