From patchwork Wed Mar 11 22:32:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Kicinski X-Patchwork-Id: 222664 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0AA3C2BAEE for ; Wed, 11 Mar 2020 22:33:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F1A320746 for ; Wed, 11 Mar 2020 22:33:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583966020; bh=IoBZ+maS4nexZK8c5eWbXLy/jh2CjB2l9DEus+/uqfg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=RA/uGCdFWvJfmRb24970V1/K7enfnWnDMVrqHYIWOpR4cP2xvGdsYfBs7u6fmOqLD Kl/ZUGx8BdRebR2+VqQ2Lt4Elj/hlFqXvcVVDqvYoFIvneTCduwSWXHqqEytalCv2V Ot0/kRtNy28ole4Q4J426ffEm98tsI7Qf5nOPWG4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387547AbgCKWdj (ORCPT ); Wed, 11 Mar 2020 18:33:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:37768 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731330AbgCKWdN (ORCPT ); Wed, 11 Mar 2020 18:33:13 -0400 Received: from kicinski-fedora-PC1C0HJN.thefacebook.com (unknown [163.114.132.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 227892074F; Wed, 11 Mar 2020 22:33:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583965992; bh=IoBZ+maS4nexZK8c5eWbXLy/jh2CjB2l9DEus+/uqfg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BPbTGmBXjnWvFHkYZb+9FbGlGB0VUQouThc0vvKmdQRbjw9Se1VbEObnNdkQnJ37O 7EWeTyjOgXSa9x5qxW7R2zqsy+QdFrazrKjzGv5LasuupgdX/wb0+T6w+XCUXOXTDE /yBuBw7r32pz+7lDi6hruWqnOYDHFdmMGqHivneU= From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, mkubecek@suse.cz, sathya.perla@broadcom.com, ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com, madalin.bucur@nxp.com, fugang.duan@nxp.com, claudiu.manoil@nxp.com, yisen.zhuang@huawei.com, salil.mehta@huawei.com, jeffrey.t.kirsher@intel.com, jacob.e.keller@intel.com, alexander.h.duyck@linux.intel.com, Jakub Kicinski Subject: [PATCH net-next 03/15] net: fec: reject unsupported coalescing params Date: Wed, 11 Mar 2020 15:32:50 -0700 Message-Id: <20200311223302.2171564-4-kuba@kernel.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200311223302.2171564-1-kuba@kernel.org> References: <20200311223302.2171564-1-kuba@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Set ethtool_ops->supported_coalesce_params to let the core reject unsupported coalescing parameters. This driver did not previously reject unsupported parameters. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/freescale/fec_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index af7653e341f2..ce154695f67c 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -2641,6 +2641,8 @@ fec_enet_set_wol(struct net_device *ndev, struct ethtool_wolinfo *wol) } static const struct ethtool_ops fec_enet_ethtool_ops = { + .supported_coalesce_params = ETHTOOL_COALESCE_USECS | + ETHTOOL_COALESCE_MAX_FRAMES, .get_drvinfo = fec_enet_get_drvinfo, .get_regs_len = fec_enet_get_regs_len, .get_regs = fec_enet_get_regs,