From patchwork Thu Jul 4 23:14:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Khoronzhuk X-Patchwork-Id: 168499 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp2795543ilk; Thu, 4 Jul 2019 16:14:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqxNdOeKUCes4WG+HPC1Qy4Kcq6jhqaAT26tV24FDOcJXAitPQd2JFg1FIiVQZHNWrq485+e X-Received: by 2002:a17:902:bcc6:: with SMTP id o6mr770457pls.268.1562282088141; Thu, 04 Jul 2019 16:14:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562282088; cv=none; d=google.com; s=arc-20160816; b=bCMxxts/++y57iy3OJrg1QXtkF1HBcAzqO90J52TI5ghvKAkdEFDGI+cypl994xJD3 r6Oi8V6uv20YW3WK1tKRPz5TIXQBwErOeL+tZI44MUk1z9qFUG5NS48HFW5yZdKGXku1 hddBHRPFB1bo2XEJqmufMcDN42u8U9ViCHWbrtnknDwbfNPquUEkOW1tqTiMFnlAyp8Z jYM5+twOZ81SV0QTlQgJmTqLaFdt7xFQj9ZLyfcXjxMeVeS82b46ZM4/KxhS8mTvIGGD mGT8kPneS2npYf1fZEExRHHanmd1pKkLPMLaQngqzAXR4+o/uOelYzlGmNMKPmCeS/aY 4LpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=h0qJMdNciD39g3Q1jo3+1MbbNG9llP7wamgm8+ijc+0=; b=0f+V7415HRt6iVJlFMmXW4JvGULj18vT3LXuKCf2NTI91l5BVDqzPoW4QurTFBfgBu 79LNwB84F4aifwl8SJALB+75EaTXVocvLXjL63Fmshewn5a8fLteA0OZ4HMj1urMDEIq l8xdN7nS/7vV4BWIrv7wrjNRKIzQVVj2sMmX1EurfHsuoVLG7pbDfrFtS7r8zJKgr6TG vSJWHr4uKHy+OsN5ieORZNMnMwNk2VuFHUNx+++6ZqzfAocZG5ZkRZFHxUOeIB/wPOkx c5M26KNF3PSoi5umy3Q7KSTpMqsgS3gEhNYF4WUQrzUrcaXBx1+eP29JVtujyY9zC6jC 48eg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kQHpY4yA; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d18si6867233pfn.202.2019.07.04.16.14.47; Thu, 04 Jul 2019 16:14:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kQHpY4yA; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727700AbfGDXOj (ORCPT + 9 others); Thu, 4 Jul 2019 19:14:39 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:44928 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727675AbfGDXOi (ORCPT ); Thu, 4 Jul 2019 19:14:38 -0400 Received: by mail-lf1-f66.google.com with SMTP id r15so5089818lfm.11 for ; Thu, 04 Jul 2019 16:14:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=h0qJMdNciD39g3Q1jo3+1MbbNG9llP7wamgm8+ijc+0=; b=kQHpY4yAX9tuFqi39cDVI528gNTKLvGMgp0fqlEEE4DscT2m11B0xfPLDzS1j+aNlZ UGMk4PmMzG9FjNTsoVkPBdsX5iAy54gTqfhQ/kkz1CJfRr6/yZPK6hdSNfh52Ye2n2Z/ 7K1NL3GmJfoDXyyJRppCGfHFJcBQmsQ46cOe6yjy7ZT9VnXN/dCd6d5C5H+OXYUSIcU/ HA/ERprLUpxQi6I5rKcKODbM6zC6zJ89Q9AXb1sKtMe4+xhPbdzfhVvc/TrPTPHtcCHR IOCXKtNAOOOZ5q4fu+AHhPqh1/fAlMu7ALbCkPIvW8scV45AIsE51nY0Q9hCsrzhCYk6 NKBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=h0qJMdNciD39g3Q1jo3+1MbbNG9llP7wamgm8+ijc+0=; b=kn2ui3am7e6UBoae+2Jz7LLN/DsO5z4SDoWXa9upAgRsYi6gxitsLJ2JLigqTjyxNZ 0yvaAZtTv3drYe5XE/QKCjNOPZAJLDLZJWtiVOS5rYjbrdPteSTIt+H+9ei+CtL0ZAIq 1j2mMSNcSrf2CpeldZH5RADBxdUn3y82m/YLwgZKnEjFQXfhofGZZPOrtw8h1AGhCWeK 1fgnUyuJ00wNifSI7zGjZEfVCr514AAK9VR7/YtnKXD1zbDJWx9pz4PqTFE5rrz+o6tS saSedNTL7F8jdT3e9R6l6WBwk0nCFWkDOHjJAccCemO5QAJNNTsS0vVHshxBkVhbCTg5 oeiQ== X-Gm-Message-State: APjAAAXhx1Jrc/ACs9KAf6OKbUeUhkLkYSUhBeh0GBqC9UJPYjDcqe3v uq4IqiO8NzTYcSI2mjPWxDmicg== X-Received: by 2002:a05:6512:70:: with SMTP id i16mr413464lfo.26.1562282076772; Thu, 04 Jul 2019 16:14:36 -0700 (PDT) Received: from localhost.localdomain ([46.211.39.135]) by smtp.gmail.com with ESMTPSA id q6sm1407269lji.70.2019.07.04.16.14.34 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 04 Jul 2019 16:14:36 -0700 (PDT) From: Ivan Khoronzhuk To: grygorii.strashko@ti.com, hawk@kernel.org, davem@davemloft.net Cc: ast@kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, xdp-newbies@vger.kernel.org, ilias.apalodimas@linaro.org, netdev@vger.kernel.org, daniel@iogearbox.net, jakub.kicinski@netronome.com, john.fastabend@gmail.com, Ivan Khoronzhuk Subject: [PATCH v7 net-next 4/5] net: ethernet: ti: cpsw_ethtool: allow res split while down Date: Fri, 5 Jul 2019 02:14:05 +0300 Message-Id: <20190704231406.27083-5-ivan.khoronzhuk@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190704231406.27083-1-ivan.khoronzhuk@linaro.org> References: <20190704231406.27083-1-ivan.khoronzhuk@linaro.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org That's possible to set channel num while interfaces are down. When interface gets up it should resplit budget. This resplit can happen after phy is up but only if speed is changed, so should be set before this, for this allow it to happen while changing number of channels, when interfaces are down. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw_ethtool.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.17.1 diff --git a/drivers/net/ethernet/ti/cpsw_ethtool.c b/drivers/net/ethernet/ti/cpsw_ethtool.c index c477e6b620d6..e4d7185fde49 100644 --- a/drivers/net/ethernet/ti/cpsw_ethtool.c +++ b/drivers/net/ethernet/ti/cpsw_ethtool.c @@ -620,8 +620,7 @@ int cpsw_set_channels_common(struct net_device *ndev, } } - if (cpsw->usage_count) - cpsw_split_res(cpsw); + cpsw_split_res(cpsw); ret = cpsw_resume_data_pass(ndev); if (!ret)