From patchwork Mon Feb 18 20:10:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Murali Karicheri X-Patchwork-Id: 158639 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp2886923jaa; Mon, 18 Feb 2019 12:08:46 -0800 (PST) X-Google-Smtp-Source: AHgI3IbHoCzOQAKPXAkXdYTSgKqo/tI2FR+HtZAcRQDRxrYLqxrRabujSgVqSWZX7Am0gwJtbgr2 X-Received: by 2002:a17:902:7d83:: with SMTP id a3mr17901492plm.83.1550520526629; Mon, 18 Feb 2019 12:08:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550520526; cv=none; d=google.com; s=arc-20160816; b=NVI1Ewlx7RdqliIrUKpynfMDmIZI9KE+73DB4O/LmS1yrgOIfGdviP0n9h9OWxx5jq q6j6lE0OM0HFbszXvpBG7P6P9wX1CyULH0pOBOlMHjmYNaPRwVNSxP2Ov7Y49a00e+jS LdPxgTYNPaOjK6axpt9StBNdQYscmClxOtnDVhbrhWZUasuJIFSeoXCHnIh33pu4jkVj 6tCtJt1QaLRSDrgQOpSJBj7bh6FkeCMAdMlLkK9+3a09HNQFujut9FxJMbXDTjKYz85J 9tj1lyU9CieESTjzhZjulyeqw1u6LPuJUNl5Q2nkLUTByTQnxNTLTPARc3pCXsSeizp8 Zvyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:to :from:dkim-signature; bh=Cycs5QM9uKU23eLxQmyTFOJmeGX7Hw4SKUFgGRrofjA=; b=r1dhqw7P5tfCdAwG8KXDZMpFiauzpy4gWAE0s+LO3CsBPhu6syLyAhYPJ0ucmly6MV Z/ZTjgOZyUEAZmJkQOW7HtJOFiOJVV8HOmqNYBeFT/byX4bQ5vA8hySTVQU+puPgYWV7 kOZVRSUUP+xhI0jkDcThn1XpFpn1gsbMIomTNZDz6lIDIEM4XsoeDMaldQeq35JH1we0 +5we6e9t0uqciiufnvahrAhdC18zMx1ixl1pe58ib/hJeKrp1YVOfBuqvBZCL9HP8QNh MMsUT++WXuuiA978G8orrExgKn0DR/RqIurzP4nhZ+QpiSqzKJdm7x3Vtrh6ihQm26Ww DaTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=kF3u+fBA; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 75si9735051pgb.230.2019.02.18.12.08.45; Mon, 18 Feb 2019 12:08:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=kF3u+fBA; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728272AbfBRUIo (ORCPT + 10 others); Mon, 18 Feb 2019 15:08:44 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:51246 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728450AbfBRUIn (ORCPT ); Mon, 18 Feb 2019 15:08:43 -0500 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x1IK8gm3024794; Mon, 18 Feb 2019 14:08:42 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1550520522; bh=Cycs5QM9uKU23eLxQmyTFOJmeGX7Hw4SKUFgGRrofjA=; h=From:To:Subject:Date; b=kF3u+fBA5Uw4/sGRlW6aW3KQ22RwNReVioLE5PP2wwcijhrqqtnw0b/WOi6Ln72sX Uy/bwW7FzXV4gmGmGOsdjajQ6zsj9zxNl9TdhPHALt25zRzvwrT9yEpidDKtqH7CVC xSQjmGHKpnLgxfuXuXTnDtcxwTP/ZZeujUUSnj1Q= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x1IK8gZm113345 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 18 Feb 2019 14:08:42 -0600 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Mon, 18 Feb 2019 14:08:41 -0600 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Mon, 18 Feb 2019 14:08:41 -0600 Received: from uda0868495.dhcp.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id x1IK8f0B018546; Mon, 18 Feb 2019 14:08:41 -0600 From: Murali Karicheri To: , , , Subject: [PATCH] net: netcp: Fix ethss driver probe issue Date: Mon, 18 Feb 2019 15:10:51 -0500 Message-ID: <20190218201051.19623-1-m-karicheri2@ti.com> X-Mailer: git-send-email 2.17.0 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Recent commit below has introduced a bug in netcp driver that causes the ethss driver probe failure and thus break the networking function on K2 SoCs such as K2HK, K2L, K2E etc. This patch fixes the issue to restore networking on the above SoCs. Fixes: 21c328dcecfc ("net: ethernet: Convert to using %pOFn instead of device_node.name") Signed-off-by: Murali Karicheri --- Failure log: https://pastebin.ubuntu.com/p/cGCFZC4WkC/ With fix: https://pastebin.ubuntu.com/p/G9qYzXXNbw/ drivers/net/ethernet/ti/netcp_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.0 diff --git a/drivers/net/ethernet/ti/netcp_core.c b/drivers/net/ethernet/ti/netcp_core.c index 1f612268c998..d847f672a705 100644 --- a/drivers/net/ethernet/ti/netcp_core.c +++ b/drivers/net/ethernet/ti/netcp_core.c @@ -259,7 +259,7 @@ static int netcp_module_probe(struct netcp_device *netcp_device, const char *name; char node_name[32]; - if (of_property_read_string(node, "label", &name) < 0) { + if (of_property_read_string(child, "label", &name) < 0) { snprintf(node_name, sizeof(node_name), "%pOFn", child); name = node_name; }