From patchwork Mon Jun 18 07:19:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 138851 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp3624564lji; Mon, 18 Jun 2018 00:19:36 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJJ7jGaT1N6shfrgE3XRKrls4xI0M87iZpYNiYP/7m1UaQ/Z/dcGpczG0ErtJobyDY+3fzd X-Received: by 2002:a63:2c94:: with SMTP id s142-v6mr9727860pgs.39.1529306376546; Mon, 18 Jun 2018 00:19:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529306376; cv=none; d=google.com; s=arc-20160816; b=BdjmJ6YKFE7N37q1IfAy7YuKpTjiWVEVkJXRFBWICzzd7yJuECh1AkdUmXhcvTNxBa S16yTxmu2MjV2+zXtre0dXllMAbjCrH9lqGhT6rt19fr87Ota3cwFWyUdgNesiX6UPpG cwDpQth6nrl1PpEfjtCYtXBL2mUSAqIsDeRuO3+0UkQPC4IOewoR+c3V36C1o/LZC+SD NS1vHH5y5x9ZPcsXeePTECG5OsP7UNCJeURGbw2Mmo482O+DcM6BYonZouvtyZaPbydr L9S1be2Xz/jpoy1VViYS22dG1PNcYZGdoIRhML+S8dkrq0jbH0AtmE+gjwr4022/4WgB mQtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=th+ouKZz60SQahGghh0HbdvE/9uo1+uG20JvZVWjkWA=; b=oofbcjZvbMtoaZYTBOXBtljj1IgsCsbT8QhhBi5fMWr4Hr4arZDIDwT+w26+HA9vNX 0Ne7YYR22Y0tn5hRcpVbeUgl38999SU2jnz8jWmHj8pi+c1BfxaFbgKrGQutwrkKijR7 D6Ma2vt1W+i2J1pJvKIPu5nocvBnh/lSbQJMBg5ZGijSk8i6/qtCetCptTi72qLiKHq6 dQOV2Xow//RirfCQ3E6LPyO5MLzqjCJKLr/n8Y5Hqe2HgMLvy1NMrbJh8JiD47J6GIoH juOkUlMBmwBBfNRvqOGJE9XPUw0U9A4jJASOuy+GUHO+UzfZ1IKPyw/p5J4bHe5LdItm bLPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=m3YFM5Gz; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i64-v6si14773122pli.431.2018.06.18.00.19.36; Mon, 18 Jun 2018 00:19:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=m3YFM5Gz; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932650AbeFRHTe (ORCPT + 9 others); Mon, 18 Jun 2018 03:19:34 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36354 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932510AbeFRHTd (ORCPT ); Mon, 18 Jun 2018 03:19:33 -0400 Received: by mail-pf0-f194.google.com with SMTP id a12-v6so7711926pfi.3 for ; Mon, 18 Jun 2018 00:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=th+ouKZz60SQahGghh0HbdvE/9uo1+uG20JvZVWjkWA=; b=m3YFM5Gzx9fIK9uffup2z8NiK8g92/JZ/y84X5rAI4dt8YmITsdWbvUQVDyLV3lLeu EIEb7IEp0+n83HEmH/aDLs9OC+jn+HqTjZPz180W3/xn2BhY/ZSzyVM4BsHn9ovf21Kw DBUlzCXQ7VhPmaqymoXEjFgMWpL8URWQAQkawf02JvhuyqX02MUbwKu6PCeO+3rjH2rA lUXSqkWpcCEaTYVEZLyJVDuLteKP6fvKYjddbNsi7hSHH1blSP0gREz8q3xlOPbZ/vLJ L1VBp1Yd3fpm+OE/uzN/AH2RXZcpp4Tu0PNTeGMpk1nbR39YlAMkcZuXlqnNA8gCcA8R i7lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=th+ouKZz60SQahGghh0HbdvE/9uo1+uG20JvZVWjkWA=; b=rxOhMTj81whHqOm7GbE4VE5RdpgTp5jfqGmw3zzM3qRTuAIHN4PVebJt07ss88Oxmu TyzRvBX4yN2sx0ci+ALwvkghvR/3mxnRvX/fgKRsLOaGbIer14L2PEAhC3mmH3n3NTso N41ydJgYg+8DcmmL8T8NM9XTqYmhx/in/htdF/nKckHjDK4HiHcFRBnM+GZ0R3S9NF/V L3H/CSPKjvoaMuVhYOc+x9eL+y27tDJZOTknrfEHcXUeqGlmsAPrVsiyzV0j/lI47/B1 OkzJsn5l6odkBi2TJnZxG3K3M7Wlqwk/uIqMkhsjDAbH8zihIs4hAVMj20SBjS0WG6+N CD2w== X-Gm-Message-State: APt69E31qr19WLXC5GJTUMZV4AE5vdYHBjV2BABZdg4QTUSasTlt5EiR 6B8PWlaftwcRMqFuothyAys= X-Received: by 2002:a62:7db:: with SMTP id 88-v6mr12229944pfh.178.1529306372352; Mon, 18 Jun 2018 00:19:32 -0700 (PDT) Received: from aurora.jms.id.au ([203.0.153.9]) by smtp.gmail.com with ESMTPSA id g80-v6sm29095770pfd.21.2018.06.18.00.19.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jun 2018 00:19:31 -0700 (PDT) Received: by aurora.jms.id.au (sSMTP sendmail emulation); Mon, 18 Jun 2018 16:49:27 +0930 From: Joel Stanley To: Samuel Mendoza-Jonas , "David S . Miller" Cc: netdev@vger.kernel.org Subject: [PATCH 1/4] net/ncsi: Silence debug messages Date: Mon, 18 Jun 2018 16:49:13 +0930 Message-Id: <20180618071916.6765-2-joel@jms.id.au> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180618071916.6765-1-joel@jms.id.au> References: <20180618071916.6765-1-joel@jms.id.au> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In normal operation we see this series of messages as the host drives the network device: ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state down ftgmac100 1e660000.ethernet eth0: NCSI: suspending channel 0 ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0 ftgmac100 1e660000.ethernet eth0: NCSI: channel 0 link down after config ftgmac100 1e660000.ethernet eth0: NCSI interface down ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state up ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0 ftgmac100 1e660000.ethernet eth0: NCSI interface up ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state down ftgmac100 1e660000.ethernet eth0: NCSI: suspending channel 0 ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0 ftgmac100 1e660000.ethernet eth0: NCSI: channel 0 link down after config ftgmac100 1e660000.ethernet eth0: NCSI interface down ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state up ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0 ftgmac100 1e660000.ethernet eth0: NCSI interface up This makes all of these messages netdev_dbg. They are still useful to debug eg. misbehaving network device firmware, but we do not need them filling up the kernel logs in normal operation. Signed-off-by: Joel Stanley --- drivers/net/ethernet/faraday/ftgmac100.c | 2 +- net/ncsi/ncsi-aen.c | 4 ++-- net/ncsi/ncsi-manage.c | 14 +++++++------- 3 files changed, 10 insertions(+), 10 deletions(-) -- 2.17.1 diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c index 78db8e62a83f..a78413d5bfde 100644 --- a/drivers/net/ethernet/faraday/ftgmac100.c +++ b/drivers/net/ethernet/faraday/ftgmac100.c @@ -1735,7 +1735,7 @@ static void ftgmac100_ncsi_handler(struct ncsi_dev *nd) if (unlikely(nd->state != ncsi_dev_state_functional)) return; - netdev_info(nd->dev, "NCSI interface %s\n", + netdev_dbg(nd->dev, "NCSI interface %s\n", nd->link_up ? "up" : "down"); } diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c index e7b05de1e6d1..f899ed61bb57 100644 --- a/net/ncsi/ncsi-aen.c +++ b/net/ncsi/ncsi-aen.c @@ -73,8 +73,8 @@ static int ncsi_aen_handler_lsc(struct ncsi_dev_priv *ndp, ncm->data[2] = data; ncm->data[4] = ntohl(lsc->oem_status); - netdev_info(ndp->ndev.dev, "NCSI: LSC AEN - channel %u state %s\n", - nc->id, data & 0x1 ? "up" : "down"); + netdev_dbg(ndp->ndev.dev, "NCSI: LSC AEN - channel %u state %s\n", + nc->id, data & 0x1 ? "up" : "down"); chained = !list_empty(&nc->link); state = nc->state; diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c index 5561e221b71f..616441c2b54f 100644 --- a/net/ncsi/ncsi-manage.c +++ b/net/ncsi/ncsi-manage.c @@ -816,9 +816,9 @@ static void ncsi_configure_channel(struct ncsi_dev_priv *ndp) } else { hot_nc = NULL; nc->state = NCSI_CHANNEL_INACTIVE; - netdev_warn(ndp->ndev.dev, - "NCSI: channel %u link down after config\n", - nc->id); + netdev_dbg(ndp->ndev.dev, + "NCSI: channel %u link down after config\n", + nc->id); } spin_unlock_irqrestore(&nc->lock, flags); @@ -1199,14 +1199,14 @@ int ncsi_process_next_channel(struct ncsi_dev_priv *ndp) switch (old_state) { case NCSI_CHANNEL_INACTIVE: ndp->ndev.state = ncsi_dev_state_config; - netdev_info(ndp->ndev.dev, "NCSI: configuring channel %u\n", - nc->id); + netdev_dbg(ndp->ndev.dev, "NCSI: configuring channel %u\n", + nc->id); ncsi_configure_channel(ndp); break; case NCSI_CHANNEL_ACTIVE: ndp->ndev.state = ncsi_dev_state_suspend; - netdev_info(ndp->ndev.dev, "NCSI: suspending channel %u\n", - nc->id); + netdev_dbg(ndp->ndev.dev, "NCSI: suspending channel %u\n", + nc->id); ncsi_suspend_channel(ndp); break; default: