From patchwork Sun Sep 18 11:54:09 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 4160 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 4036323EFB for ; Sun, 18 Sep 2011 11:52:30 +0000 (UTC) Received: from mail-fx0-f52.google.com (mail-fx0-f52.google.com [209.85.161.52]) by fiordland.canonical.com (Postfix) with ESMTP id 2E350A183F2 for ; Sun, 18 Sep 2011 11:52:30 +0000 (UTC) Received: by mail-fx0-f52.google.com with SMTP id 23so4345047fxe.11 for ; Sun, 18 Sep 2011 04:52:30 -0700 (PDT) Received: by 10.223.61.66 with SMTP id s2mr3014637fah.27.1316346749998; Sun, 18 Sep 2011 04:52:29 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.152.18.198 with SMTP id y6cs4599lad; Sun, 18 Sep 2011 04:52:29 -0700 (PDT) Received: by 10.68.38.166 with SMTP id h6mr2542389pbk.466.1316346748235; Sun, 18 Sep 2011 04:52:28 -0700 (PDT) Received: from mail-pz0-f45.google.com (mail-pz0-f45.google.com [209.85.210.45]) by mx.google.com with ESMTPS id f6si8439655pbd.152.2011.09.18.04.52.27 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 18 Sep 2011 04:52:28 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.210.45 is neither permitted nor denied by best guess record for domain of shawn.guo@linaro.org) client-ip=209.85.210.45; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.210.45 is neither permitted nor denied by best guess record for domain of shawn.guo@linaro.org) smtp.mail=shawn.guo@linaro.org Received: by mail-pz0-f45.google.com with SMTP id 33so12982704pzk.4 for ; Sun, 18 Sep 2011 04:52:27 -0700 (PDT) Received: by 10.68.28.199 with SMTP id d7mr2418949pbh.142.1316346747255; Sun, 18 Sep 2011 04:52:27 -0700 (PDT) Received: from localhost.localdomain ([180.106.36.88]) by mx.google.com with ESMTPS id 4sm2053371pbk.5.2011.09.18.04.52.12 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 18 Sep 2011 04:52:26 -0700 (PDT) From: Shawn Guo To: netdev@vger.kernel.org Cc: "David S. Miller" , linux-arm-kernel@lists.infradead.org, patches@linaro.org, Shawn Guo Subject: [PATCH 1/4] net/fec: change phy-reset-gpio request warning to debug message Date: Sun, 18 Sep 2011 19:54:09 +0800 Message-Id: <1316346852-17090-2-git-send-email-shawn.guo@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1316346852-17090-1-git-send-email-shawn.guo@linaro.org> References: <1316346852-17090-1-git-send-email-shawn.guo@linaro.org> FEC can work without a phy reset on some platforms, which means not very platform necessarily have a phy-reset gpio encoded in device tree. So it makes more sense to have the phy-reset-gpio request failure as a debug message rather than a warning. Signed-off-by: Shawn Guo --- drivers/net/fec.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/fec.c b/drivers/net/fec.c index e8266cc..6a638e9 100644 --- a/drivers/net/fec.c +++ b/drivers/net/fec.c @@ -1422,7 +1422,7 @@ static int __devinit fec_reset_phy(struct platform_device *pdev) phy_reset = of_get_named_gpio(np, "phy-reset-gpios", 0); err = gpio_request_one(phy_reset, GPIOF_OUT_INIT_LOW, "phy-reset"); if (err) { - pr_warn("FEC: failed to get gpio phy-reset: %d\n", err); + pr_debug("FEC: failed to get gpio phy-reset: %d\n", err); return err; } msleep(1);