From patchwork Fri Mar 28 17:57:36 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Byungho An X-Patchwork-Id: 27372 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yh0-f72.google.com (mail-yh0-f72.google.com [209.85.213.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 36C6620062 for ; Fri, 28 Mar 2014 17:58:25 +0000 (UTC) Received: by mail-yh0-f72.google.com with SMTP id f10sf12436815yha.11 for ; Fri, 28 Mar 2014 10:58:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :mime-version:thread-index:dlp-filter:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type :content-transfer-encoding:content-language; bh=67f4O8dYHWbatyhjdJVJ4BJIXZMW/CSEuWrmSVsa/ZM=; b=G7YQ3Nb8+rX9nFQakfThmsUjJiFIR0+/sV4l8yUhkhkMy1nVJbquycEuntVsPykJ2h 331j5wI3TO5TEl3XIrL6zxx5yAhgbcgC2k1YiTgmAR1jgun6/xRHX4s9B67+5O9DSmce p3sniaLA4Yjxt8BRudM4AkE8pqTZscU2reT5fWDS6VNWNIrucCs9FM7xFEBihIJvvzLi wLU2uoHEWf16Dr3lhLdoTcE2HaSDohA25AE2+b9XitXulnlsayApLJHpjFLbyYpyHgng /+z+KwJSTjvEoOW1MyKLurSo+iPMH9mCuwbq3ts/9lUyoJ4jkEUTB2gfthvtpOPAzvJd HGLQ== X-Gm-Message-State: ALoCoQnOU2SB/UpRwTmi2YEVd95Sd2LfoJO79PRrBUg7/NEgqv8vkCeVF0SoYUkOveITbOjEdQZj X-Received: by 10.58.41.39 with SMTP id c7mr2553376vel.25.1396029504955; Fri, 28 Mar 2014 10:58:24 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.19.81 with SMTP id 75ls1646232qgg.75.gmail; Fri, 28 Mar 2014 10:58:24 -0700 (PDT) X-Received: by 10.220.12.66 with SMTP id w2mr8144680vcw.15.1396029504790; Fri, 28 Mar 2014 10:58:24 -0700 (PDT) Received: from mail-vc0-f173.google.com (mail-vc0-f173.google.com [209.85.220.173]) by mx.google.com with ESMTPS id ls10si1375675vec.118.2014.03.28.10.58.24 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 28 Mar 2014 10:58:24 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.173; Received: by mail-vc0-f173.google.com with SMTP id il7so6276518vcb.32 for ; Fri, 28 Mar 2014 10:58:24 -0700 (PDT) X-Received: by 10.220.162.6 with SMTP id t6mr8434042vcx.12.1396029504697; Fri, 28 Mar 2014 10:58:24 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.12.8 with SMTP id v8csp28162vcv; Fri, 28 Mar 2014 10:58:24 -0700 (PDT) X-Received: by 10.68.13.42 with SMTP id e10mr9969001pbc.118.1396029504031; Fri, 28 Mar 2014 10:58:24 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id yj1si4127495pac.33.2014.03.28.10.58.23; Fri, 28 Mar 2014 10:58:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753137AbaC1R6T (ORCPT + 4 others); Fri, 28 Mar 2014 13:58:19 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:48653 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753230AbaC1R5p (ORCPT ); Fri, 28 Mar 2014 13:57:45 -0400 Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N3500LY9R871750@mailout3.samsung.com>; Sat, 29 Mar 2014 02:57:43 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.51]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id 38.A2.10092.718B5335; Sat, 29 Mar 2014 02:57:43 +0900 (KST) X-AuditID: cbfee68f-b7f156d00000276c-d0-5335b817c482 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id F6.56.29263.718B5335; Sat, 29 Mar 2014 02:57:43 +0900 (KST) Received: from VISITOR1LAB ([105.128.34.229]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N3500ETLR856Y50@mmp2.samsung.com>; Sat, 29 Mar 2014 02:57:43 +0900 (KST) From: Byungho An To: netdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: 'David Miller' , 'kbuild test robot' , 'Girish K S' , 'Siva Reddy' , 'Vipul Pandya' Subject: [PATCH net-next] net: sxgbe: fix sparse warnings about static declaration Date: Fri, 28 Mar 2014 10:57:36 -0700 Message-id: <031b01cf4aaf$35e1b3b0$a1a51b10$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac9KrP2p5stiKjwNTP6z+AbS3iWAFw== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMIsWRmVeSWpSXmKPExsVy+t8zY13xHabBBm/azCzmnG9hsXj/fD2z xfyjO5gsZpzfx2RxbIGYxYqmrYwW2xZcYHZg99iy8iaTx+I9L5k8+rasYvT4vEkugCWKyyYl NSezLLVI3y6BK+Nxy2PWgqMiFYtPnWFpYLwh2MXIySEhYCLR37uaHcIWk7hwbz1bFyMXh5DA MkaJqzefssAUday8wwyRmM4ocer6fRYI5y+jxMXn2xhBqtgE1CSaZ15mA7FFBGwllhz5DDaW WeAyo0TbSlcQW1ggRGLTsUNMXYwcHCwCqhI/HpeDhHkFLCV2bfzCAmELSvyYfI8FolVLYv3O 40wQtrzE5jVvmSEOUpDYcfY1I8QqPYldB2+wQdSIS0x68BDqm1PsEvvnVIPYLAICEt8mH2IB WSshICux6QDUGEmJgytusExgFJuFZPMsJJtnIdk8C8mGBYwsqxhFUwuSC4qT0ouM9YoTc4tL 89L1kvNzNzFCIrB/B+PdA9aHGJOB1k9klhJNzgdGcF5JvKGxmZGFqYmpsZG5pRlpwkrivPcf JgUJCaQnlqRmp6YWpBbFF5XmpBYfYmTi4JRqYLS8bq5lzHtb8Mk/04aaIL/r3BmfvWdeXLdd qs4vms/If7PRyuNtP2/eNz2u1FfJriCoF/DG9MSdLyICr4Q4F9tJB040WXxQ5sbiQ4ufffdy 2DtflX3HZP2bMyM+iIvxv3SbuH3ZJHuunDPWf0/P0ct/b/3BVNif5/zzta5NynuifrBsXTy9 TlSJpTgj0VCLuag4EQAjjJ5G1gIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIKsWRmVeSWpSXmKPExsVy+t9jQV3xHabBBuvvGFjMOd/CYvH++Xpm i/lHdzBZzDi/j8ni2AIxixVNWxktti24wOzA7rFl5U0mj8V7XjJ59G1ZxejxeZNcAEtUA6NN RmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtAFSgpliTml QKGAxOJiJX07TBNCQ9x0LWAaI3R9Q4LgeowM0EDCOsaMxy2PWQuOilQsPnWGpYHxhmAXIyeH hICJRMfKO8wQtpjEhXvr2boYuTiEBKYzSpy6fp8FwvnLKHHx+TZGkCo2ATWJ5pmX2UBsEQFb iSVHPrOD2MwClxkl2la6gtjCAiESm44dYupi5OBgEVCV+PG4HCTMK2ApsWvjFxYIW1Dix+R7 LBCtWhLrdx5ngrDlJTaveQt1kILEjrOvGSFW6UnsOniDDaJGXGLSg4fsExgFZiEZNQvJqFlI Rs1C0rKAkWUVo2hqQXJBcVJ6rqFecWJucWleul5yfu4mRnCEP5PawbiyweIQowAHoxIPr0Cr abAQa2JZcWXuIUYJDmYlEd6siUAh3pTEyqrUovz4otKc1OJDjMlAj05klhJNzgcmn7ySeENj EzMjSyMzCyMTc3PShJXEeQ+0WgcKCaQnlqRmp6YWpBbBbGHi4JRqYBQMe5YRfHFRzpz4FwLZ N3U+WR388XnnlYWZO06/KUzUn2gdZ77czKfCgX+NyGQ+/1r5Q6VcptE3vZ0iT6mHh5RqrmrN uO8efav9/4oCrkviaswPV3/rXbQ/4c6RZZnZByvKfa49XnGY4eevy5tYussX/GRf5649vVVU dmXW1HkVUkJS23dOX6PEUpyRaKjFXFScCACW6pTZNAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: netdev@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: bh74.an@samsung.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit Content-language: en-us From: Byungho An This fixes followings: sparse warnings: (new ones prefixed by >>) >> drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:197:5: sparse: symbol 'sxgbe_platform_freeze' was not declared. Should it be static? >> drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:204:5: sparse: symbol 'sxgbe_platform_restore' was not declared. Should it be static? >> drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:228:24: sparse: symbol 'sxgbe_platform_driver' was not declared. Should it be static? >> drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c:1795:6: sparse: symbol 'sxgbe_get_ops' was not declared. Should it be static? Reported-by: kbuild test robot Signed-off-by: Byungho An --- drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c | 2 +- drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c index 1869d4c6..ee1fd3c 100644 --- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c +++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c @@ -2013,7 +2013,7 @@ static const struct net_device_ops sxgbe_netdev_ops = { }; /* Get the hardware ops */ -void sxgbe_get_ops(struct sxgbe_ops * const ops_ptr) +static void sxgbe_get_ops(struct sxgbe_ops * const ops_ptr) { ops_ptr->mac = sxgbe_get_core_ops(); ops_ptr->desc = sxgbe_get_desc_ops(); diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c b/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c index 94c2cd7..b147d46 100644 --- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c +++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c @@ -200,14 +200,14 @@ static int sxgbe_platform_resume(struct device *dev) return sxgbe_resume(ndev); } -int sxgbe_platform_freeze(struct device *dev) +static int sxgbe_platform_freeze(struct device *dev) { struct net_device *ndev = dev_get_drvdata(dev); return sxgbe_freeze(ndev); } -int sxgbe_platform_restore(struct device *dev) +static int sxgbe_platform_restore(struct device *dev) { struct net_device *ndev = dev_get_drvdata(dev); @@ -231,7 +231,7 @@ static const struct of_device_id sxgbe_dt_ids[] = { }; MODULE_DEVICE_TABLE(of, sxgbe_dt_ids); -struct platform_driver sxgbe_platform_driver = { +static struct platform_driver sxgbe_platform_driver = { .probe = sxgbe_platform_probe, .remove = sxgbe_platform_remove, .driver = {