From patchwork Thu Mar 20 17:26:11 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Byungho An X-Patchwork-Id: 26750 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pb0-f72.google.com (mail-pb0-f72.google.com [209.85.160.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 4BDC9202E0 for ; Thu, 20 Mar 2014 17:27:08 +0000 (UTC) Received: by mail-pb0-f72.google.com with SMTP id jt11sf2927466pbb.11 for ; Thu, 20 Mar 2014 10:27:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :mime-version:thread-index:dlp-filter:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type :content-transfer-encoding:content-language; bh=yU9pGRKoEeSdM5swrsJOMX3u5yeyNLwr6dXH/bXstOU=; b=FR9mrWgveeF8HQPJuMC6Ko33V/3lE6nvRNe2VYoqpfraARI0W6T0zen/at73+gvmNr X8X8ugydvIejZddSD91LI28sfNIe3006AuQ39RQfTvoZ7LRBI8L1ISmlZNaZ1Gi4Eprv TQXt8Gazdt2cpOQxm18cd8DWobeLXKZPJeO7Tz/K6uWGAUfdyro2M7M/6NB0bt/Fw2xj Lk/BIv4pscpuH7KxmUuWNjDFv0qPrPTkfejkebFmjXMzKw9Ug8OUW6J3lsjFtspIt5bt 0qpOAe0WK8BicWVjDzHj0JmTYLXR7a8LLEEN1traY9XHaoKRiEuyVDcI5bscZnA+IxZC eTXQ== X-Gm-Message-State: ALoCoQnikCqjMrst/jFxaYvQebfKB/4e9Wf53EPNMKki/6Gx1qgh/UzhSzQeYyJLWXbUB5vEXnqx X-Received: by 10.66.141.231 with SMTP id rr7mr6800630pab.47.1395336427487; Thu, 20 Mar 2014 10:27:07 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.48.38 with SMTP id n35ls410642qga.68.gmail; Thu, 20 Mar 2014 10:27:07 -0700 (PDT) X-Received: by 10.220.10.2 with SMTP id n2mr5760928vcn.26.1395336427331; Thu, 20 Mar 2014 10:27:07 -0700 (PDT) Received: from mail-vc0-f180.google.com (mail-vc0-f180.google.com [209.85.220.180]) by mx.google.com with ESMTPS id uw4si587510vdc.37.2014.03.20.10.27.07 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 20 Mar 2014 10:27:07 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.180 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.180; Received: by mail-vc0-f180.google.com with SMTP id lf12so1313989vcb.25 for ; Thu, 20 Mar 2014 10:27:07 -0700 (PDT) X-Received: by 10.58.207.74 with SMTP id lu10mr34036605vec.15.1395336427239; Thu, 20 Mar 2014 10:27:07 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.78.9 with SMTP id i9csp406021vck; Thu, 20 Mar 2014 10:27:06 -0700 (PDT) X-Received: by 10.69.26.103 with SMTP id ix7mr49296407pbd.41.1395336426212; Thu, 20 Mar 2014 10:27:06 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id tk9si1897516pac.416.2014.03.20.10.27.05; Thu, 20 Mar 2014 10:27:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751685AbaCTR1D (ORCPT + 8 others); Thu, 20 Mar 2014 13:27:03 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:53641 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759436AbaCTR0Z (ORCPT ); Thu, 20 Mar 2014 13:26:25 -0400 Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N2Q00BQPWG0BN10@mailout3.samsung.com>; Fri, 21 Mar 2014 02:26:24 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.49]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id 7B.CE.10092.0C42B235; Fri, 21 Mar 2014 02:26:24 +0900 (KST) X-AuditID: cbfee68f-b7f156d00000276c-3e-532b24c0b833 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 86.ED.28157.0C42B235; Fri, 21 Mar 2014 02:26:24 +0900 (KST) Received: from VISITOR1LAB ([105.128.34.229]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N2Q0090WWFAQ850@mmp1.samsung.com>; Fri, 21 Mar 2014 02:26:24 +0900 (KST) From: Byungho An To: 'netdev' , linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org Cc: 'David Miller' , 'GIRISH K S' , 'SIVAREDDY KALLAM' , 'Vipul Chandrakant' , 'Ilho Lee' Subject: [PATCH V8 5/7] net: sxgbe: add Checksum offload support for Samsung sxgbe Date: Thu, 20 Mar 2014 10:26:11 -0700 Message-id: <013201cf4461$82a8a2c0$87f9e840$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac9EYOkOs6mD/qGQQsmqjIByjTS19w== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCIsWRmVeSWpSXmKPExsVy+t8zQ90DKtrBBjenylnMOd/CYjH/yDlW i6P/FjJazD+6g8lixvl9TBbHFohZrGjaymixbcEFZgcOjy0rbzJ59G1ZxejxeZNcAHMUl01K ak5mWWqRvl0CV8bj+70sBdstKx7t2MXWwLhGv4uRk0NCwETi5ax57BC2mMSFe+vZuhi5OIQE ljFKPO9YAJTgACtaus8NIr4IKL6siRHC+csosb1lLTNIN5uAmkTzzMtsILaIQJrE7kt7mEGK mAWuMUps+/2YBSQhLBAicf32BlaQqSwCqhJnJuiChHkFLCVe9W5lhrAFJX5MvgdWziygJbF+ 53EmCFteYvOat8wQlypI7Dj7mhFil57EyQcnmSFqxCUmPXjIDrJXQuAcu8TnzVfBBrEICEh8 m3yIBeIbWYlNB6DmSEocXHGDZQKj2Cwkq2chWT0LyepZSFYsYGRZxSiaWpBcUJyUXmSsV5yY W1yal66XnJ+7iRESg/07GO8esD7EmAy0fiKzlGhyPjCG80riDY3NjCxMTUyNjcwtzUgTVhLn vf8wKUhIID2xJDU7NbUgtSi+qDQntfgQIxMHp1QDY9iSZT+ckx/klgTMqt+lm/v5lBGH9rmS u84hb3ZMSks9u/RV7teTe+/9U4wT57lxoHZNpIHKdLupR07e+Hem+/f16PQa9dXxLhujebrV b0upsp1dfuDdo9QtnGs3dXs18H1boxW6aKXbrdzA4sKA84c6rr1vjZOQ/nmpX1J8VYXmM3tf HYZVEkosxRmJhlrMRcWJAIXcF8zXAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIKsWRmVeSWpSXmKPExsVy+t9jAd0DKtrBBre3i1nMOd/CYjH/yDlW i6P/FjJazD+6g8lixvl9TBbHFohZrGjaymixbcEFZgcOjy0rbzJ59G1ZxejxeZNcAHNUA6NN RmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtAFSgpliTml QKGAxOJiJX07TBNCQ9x0LWAaI3R9Q4LgeowM0EDCOsaMx/d7WQq2W1Y82rGLrYFxjX4XIweH hICJxNJ9bl2MnECmmMSFe+vZuhi5OIQEFjFKPF/WxAjh/GWU2N6ylhmkik1ATaJ55mU2EFtE IE1i96U9zCBFzALXGCW2/X7MApIQFgiRuH57AyvIBhYBVYkzE3RBwrwClhKvercyQ9iCEj8m 3wMrZxbQkli/8zgThC0vsXnNW2aIixQkdpx9zQixS0/i5IOTzBA14hKTHjxkn8AoMAvJqFlI Rs1CMmoWkpYFjCyrGEVTC5ILipPSc430ihNzi0vz0vWS83M3MYIj/Jn0DsZVDRaHGAU4GJV4 eCs4tYOFWBPLiitzDzFKcDArifAWKgCFeFMSK6tSi/Lji0pzUosPMSYDPTqRWUo0OR+YfPJK 4g2NTcyMLI3MLIxMzM1JE1YS5z3Yah0oJJCeWJKanZpakFoEs4WJg1OqgbFt8VqfqfUxtfNv qq3f4sB55Og0r3PXv//nuPqX7byWiK75rWlPk7/NDZ57Ofx3jdmB9cr7NohvdpDx0TH8+GVD r1RTycFfGyrdU9rcr81NkXk8fXnuX4ewSY5p2bckF5r/a1ntK3kza8YNv30eOlnKMUkhs1yu tr9Q/TTVypBLbZmYZHNX43IlluKMREMt5qLiRACmOFWENAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: bh74.an@samsung.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.180 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit Content-language: en-us From: Vipul Pandya This patch adds TX and RX checksum offload support. Signed-off-by: Vipul Pandya Neatening-by: Joe Perches Signed-off-by: Byungho An --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 5 +++ drivers/net/ethernet/samsung/sxgbe/sxgbe_core.c | 20 +++++++++ drivers/net/ethernet/samsung/sxgbe/sxgbe_desc.h | 6 +-- drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c | 46 ++++++++++++++++----- 4 files changed, 63 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h b/drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h index 5f1d02c..f06d439 100644 --- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h +++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h @@ -337,6 +337,10 @@ struct sxgbe_core_ops { void (*set_eee_timer)(void __iomem *ioaddr, const int ls, const int tw); void (*set_eee_pls)(void __iomem *ioaddr, const int link); + + /* Enable disable checksum offload operations */ + void (*enable_rx_csum)(void __iomem *ioaddr); + void (*disable_rx_csum)(void __iomem *ioaddr); }; const struct sxgbe_core_ops *sxgbe_get_core_ops(void); @@ -449,6 +453,7 @@ struct sxgbe_priv_data { struct sxgbe_ops *hw; /* sxgbe specific ops */ int no_csum_insertion; int irq; + int rxcsum_insertion; spinlock_t stats_lock; /* lock for tx/rx statatics */ struct phy_device *phydev; diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_core.c b/drivers/net/ethernet/samsung/sxgbe/sxgbe_core.c index bf93b16..5885fd6 100644 --- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_core.c +++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_core.c @@ -217,6 +217,24 @@ static void sxgbe_set_eee_timer(void __iomem *ioaddr, writel(value, ioaddr + SXGBE_CORE_LPI_TIMER_CTRL); } +static void sxgbe_enable_rx_csum(void __iomem *ioaddr) +{ + u32 ctrl; + + ctrl = readl(ioaddr + SXGBE_CORE_RX_CONFIG_REG); + ctrl |= SXGBE_RX_CSUMOFFLOAD_ENABLE; + writel(ctrl, ioaddr + SXGBE_CORE_RX_CONFIG_REG); +} + +static void sxgbe_disable_rx_csum(void __iomem *ioaddr) +{ + u32 ctrl; + + ctrl = readl(ioaddr + SXGBE_CORE_RX_CONFIG_REG); + ctrl &= ~SXGBE_RX_CSUMOFFLOAD_ENABLE; + writel(ctrl, ioaddr + SXGBE_CORE_RX_CONFIG_REG); +} + const struct sxgbe_core_ops core_ops = { .core_init = sxgbe_core_init, .dump_regs = sxgbe_core_dump_regs, @@ -233,6 +251,8 @@ const struct sxgbe_core_ops core_ops = { .reset_eee_mode = sxgbe_reset_eee_mode, .set_eee_timer = sxgbe_set_eee_timer, .set_eee_pls = sxgbe_set_eee_pls, + .enable_rx_csum = sxgbe_enable_rx_csum, + .disable_rx_csum = sxgbe_disable_rx_csum, }; const struct sxgbe_core_ops *sxgbe_get_core_ops(void) diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_desc.h b/drivers/net/ethernet/samsung/sxgbe/sxgbe_desc.h index 547edf3..3c0b5a8 100644 --- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_desc.h +++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_desc.h @@ -113,7 +113,7 @@ struct sxgbe_rx_norm_desc { /* WB RDES3 */ u32 pkt_len:14; u32 rdes3_reserved:1; - u32 err_summary:15; + u32 err_summary:1; u32 err_l2_type:4; u32 layer34_pkt_type:4; u32 no_coagulation_pkt:1; @@ -273,8 +273,8 @@ struct sxgbe_desc_ops { int (*get_rx_ld_status)(struct sxgbe_rx_norm_desc *p); /* Return the reception status looking at the RDES1 */ - void (*rx_wbstatus)(struct sxgbe_rx_norm_desc *p, - struct sxgbe_extra_stats *x); + int (*rx_wbstatus)(struct sxgbe_rx_norm_desc *p, + struct sxgbe_extra_stats *x, int *checksum); /* Get own bit */ int (*get_rx_ctxt_owner)(struct sxgbe_rx_ctxt_desc *p); diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c index d105b2c..b845322 100644 --- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c +++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c @@ -1255,6 +1255,7 @@ void sxgbe_tso_prepare(struct sxgbe_priv_data *priv, static netdev_tx_t sxgbe_xmit(struct sk_buff *skb, struct net_device *dev) { unsigned int entry, frag_num; + int cksum_flag = 0; struct netdev_queue *dev_txq; unsigned txq_index = skb_get_queue_mapping(skb); struct sxgbe_priv_data *priv = netdev_priv(dev); @@ -1335,7 +1336,7 @@ static netdev_tx_t sxgbe_xmit(struct sk_buff *skb, struct net_device *dev) __func__); priv->hw->desc->prepare_tx_desc(tx_desc, 1, no_pagedlen, - no_pagedlen); + no_pagedlen, cksum_flag); } } @@ -1353,7 +1354,7 @@ static netdev_tx_t sxgbe_xmit(struct sk_buff *skb, struct net_device *dev) /* prepare the descriptor */ priv->hw->desc->prepare_tx_desc(tx_desc, 0, len, - len); + len, cksum_flag); /* memory barrier to flush descriptor */ wmb(); @@ -1474,6 +1475,8 @@ static int sxgbe_rx(struct sxgbe_priv_data *priv, int limit) unsigned int entry = priv->rxq[qnum]->cur_rx; unsigned int next_entry = 0; unsigned int count = 0; + int checksum; + int status; while (count < limit) { struct sxgbe_rx_norm_desc *p; @@ -1490,7 +1493,18 @@ static int sxgbe_rx(struct sxgbe_priv_data *priv, int limit) next_entry = (++priv->rxq[qnum]->cur_rx) % rxsize; prefetch(priv->rxq[qnum]->dma_rx + next_entry); - /*TO DO read the status of the incoming frame */ + /* Read the status of the incoming frame and also get checksum + * value based on whether it is enabled in SXGBE hardware or + * not. + */ + status = priv->hw->desc->rx_wbstatus(p, &priv->xstats, + &checksum); + if (unlikely(status < 0)) { + entry = next_entry; + continue; + } + if (unlikely(!priv->rxcsum_insertion)) + checksum = CHECKSUM_NONE; skb = priv->rxq[qnum]->rx_skbuff[entry]; @@ -1504,7 +1518,11 @@ static int sxgbe_rx(struct sxgbe_priv_data *priv, int limit) skb_put(skb, frame_len); - netif_receive_skb(skb); + skb->ip_summed = checksum; + if (checksum == CHECKSUM_NONE) + netif_receive_skb(skb); + else + napi_gro_receive(&priv->napi, skb); entry = next_entry; } @@ -1750,15 +1768,15 @@ static int sxgbe_set_features(struct net_device *dev, { struct sxgbe_priv_data *priv = netdev_priv(dev); netdev_features_t changed = dev->features ^ features; - u32 ctrl; if (changed & NETIF_F_RXCSUM) { - ctrl = readl(priv->ioaddr + SXGBE_CORE_RX_CONFIG_REG); - if (features & NETIF_F_RXCSUM) - ctrl |= SXGBE_RX_CSUMOFFLOAD_ENABLE; - else - ctrl &= ~SXGBE_RX_CSUMOFFLOAD_ENABLE; - writel(ctrl, priv->ioaddr + SXGBE_CORE_RX_CONFIG_REG); + if (features & NETIF_F_RXCSUM) { + priv->hw->mac->enable_rx_csum(priv->ioaddr); + priv->rxcsum_insertion = true; + } else { + priv->hw->mac->disable_rx_csum(priv->ioaddr); + priv->rxcsum_insertion = false; + } } return 0; @@ -2121,6 +2139,12 @@ struct sxgbe_priv_data *sxgbe_dvr_probe(struct device *device, } } + /* Enable Rx checksum offload */ + if (priv->hw_cap.rx_csum_offload) { + priv->hw->mac->enable_rx_csum(priv->ioaddr); + priv->rxcsum_insertion = true; + } + /* Rx Watchdog is available, enable depend on platform data */ if (!priv->plat->riwt_off) { priv->use_riwt = 1;