From patchwork Fri Jun 19 17:35:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Lobakin X-Patchwork-Id: 217524 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2849AC433E0 for ; Fri, 19 Jun 2020 17:35:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F122E207FC for ; Fri, 19 Jun 2020 17:35:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=pm.me header.i=@pm.me header.b="QePdyPao" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392582AbgFSRfR (ORCPT ); Fri, 19 Jun 2020 13:35:17 -0400 Received: from mail1.protonmail.ch ([185.70.40.18]:37315 "EHLO mail1.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391129AbgFSRfP (ORCPT ); Fri, 19 Jun 2020 13:35:15 -0400 Date: Fri, 19 Jun 2020 17:35:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail; t=1592588111; bh=pmcgB8cIWmktL8m7nzcLgHPgxr84gMsapvN9vA7VbRQ=; h=Date:To:From:Cc:Reply-To:Subject:From; b=QePdyPaod+pKMacktRWNzHWsjJrj3nxq+JWWbCnDXbS/XssWQheK7VvLrcMZFk2TB tE6C6kVxHHDZGWQSt4YUXJGXoF2xlHDw9Nj4aNVf1feMzuXoYFjlNqeqf/Bkogl1sN Gdd4U/c1Ul12Xg+pO2TRkX3u8u0U7IUkHORviBlTfSK1tjI1ZcOtCXZLZ/hLQ0B3Q7 /Ruv9nJHKEmLkQ3Si7B4scvBY5q0MInhS+i6cseXRzT7cOS7QhGcpbpsYd+MahWE7D NUVIGh8kYWqdls84gtjAdA//pd+ORdZNtzWFX451SUecJOE3fuxEtOPSNq92vAIqq4 LjyhnBMB6pXZQ== To: "David S. Miller" , Jakub Kicinski From: Alexander Lobakin Cc: Michal Kubecek , Florian Fainelli , Andrew Lunn , Jiri Pirko , Antoine Tenart , Steffen Klassert , Aya Levin , Tom Herbert , Alexander Lobakin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Reply-To: Alexander Lobakin Subject: [PATCH net 0/3] net: ethtool: netdev_features_strings[] cleanup Message-ID: MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This little series adds the last forgotten feature string for NETIF_F_GSO_TUNNEL_REMCSUM and attempts to prevent such losses in future. Patches 2-3 seem more like net-next candidates rather than net-fixes, but if we don't stop it now, no guarantees that it won't happen again soon. I was thinking about some kind of static assertion to have an early prevention mechanism for this, but the existing of 2 intended holes (former NO_CSUM and UFO) makes this problematic, at least at first sight. Alexander Lobakin (3): net: ethtool: add missing string for NETIF_F_GSO_TUNNEL_REMCSUM net: ethtool: fix indentation of netdev_features_strings net: ethtool: sync netdev_features_strings order with enum netdev_features net/ethtool/common.c | 133 ++++++++++++++++++++++++------------------- 1 file changed, 74 insertions(+), 59 deletions(-)