From patchwork Tue Sep 14 05:54:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jiang Wang X-Patchwork-Id: 511588 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DBF2C433F5 for ; Tue, 14 Sep 2021 05:55:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7461E61151 for ; Tue, 14 Sep 2021 05:55:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239673AbhINF4h (ORCPT ); Tue, 14 Sep 2021 01:56:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239744AbhINF4g (ORCPT ); Tue, 14 Sep 2021 01:56:36 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB7F4C061762 for ; Mon, 13 Sep 2021 22:55:19 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id j16so11145997pfc.2 for ; Mon, 13 Sep 2021 22:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6P3Hg4gutReG5Sbg1AE6RT45vebLhTpUQQ0b1X0Vkms=; b=MTzR0KmUJ1q87fdNpZpMK9h6XXbkg3fNZXH1AdkDVsoU3folKJwrb7SxjpFephEJ+s Co9XYjV55zRvYYAZqUnw6dO4OMIo8ugxiV0uPZtcCDCHNYWlF++UvRgPoWrYlnf3+3U0 3Anob837AbiXEBBpPm/SKtgL2qJkxWYS9phkXAGetq1PZCNQZPdzkCxIx5xxDuDLQxN8 3CbGgvObm98SUG0bw9brVu0UgqOsKtB11gRlqpzemoPM4lmQHqmIVG9OWn0XkMSRb79W nFTzBA0FqXd/Kd+xCv1JFnHJkeax4Z+gFbP9DwSy2dC0cdz6pCuDHdB+g7eumCL2TwRJ 0j3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6P3Hg4gutReG5Sbg1AE6RT45vebLhTpUQQ0b1X0Vkms=; b=MdJDsjtzMp5FK5ikB0clBZ0taSR5L0fnnYaUNJE5qmxmjVHqGFOPsno5/ymjqij5UP p1IZi41I0ykD2uGeJanx+30eU0cupUxaXTFmpuMeXFojua8mQG0W7lPUjzTe6167l8hS ZIWGrGOJOl826Ek8SMnJF/WBKet/MfeLiCXK093vc+Uwaoq36vTvRJlTu9KLIFwuH9It DHK32BkoR3vk2RZ4DlA637EykwHRXr/dwAnHxkbceGhpKrLY9XU0P9x1MPvhIGVo3NtR 4VlU7lNEX3U0wk+CkGhhUXWyTK15NqLr9mrJtjATs2ya69sSW8urJmrEXmzq1/68zHF7 1iBQ== X-Gm-Message-State: AOAM533ym8y8ZdWAMto/D15Z4dSMGPBuHuajxpUOTiz6TNvIO6oRPf/p Oh5HU69QoDMTKo7oLShx+FsxEQ== X-Google-Smtp-Source: ABdhPJw5fb14z2YynodbTwMlTVY7BcqTzJq0/T4qCik4yyJ5qrktWf11pHZnIZuysBAmwYQb055O/Q== X-Received: by 2002:aa7:9115:0:b029:359:69db:bc89 with SMTP id 21-20020aa791150000b029035969dbbc89mr3185623pfh.32.1631598919355; Mon, 13 Sep 2021 22:55:19 -0700 (PDT) Received: from ip-10-124-121-13.byted.org (ec2-54-241-92-238.us-west-1.compute.amazonaws.com. [54.241.92.238]) by smtp.gmail.com with ESMTPSA id v14sm719432pfi.111.2021.09.13.22.55.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Sep 2021 22:55:18 -0700 (PDT) From: Jiang Wang To: jiangleetcode@gmail.com Cc: virtualization@lists.linux-foundation.org, stefanha@redhat.com, sgarzare@redhat.com, mst@redhat.com, arseny.krasnov@kaspersky.com, jhansen@vmware.com, cong.wang@bytedance.com, duanxiongchun@bytedance.com, xieyongji@bytedance.com, chaiwen.cc@bytedance.com, Jason Wang , "David S. Miller" , Jakub Kicinski , Steven Rostedt , Ingo Molnar , kvm@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC v2 0/5] virtio/vsock: introduce SOCK_DGRAM support Date: Tue, 14 Sep 2021 05:54:33 +0000 Message-Id: <20210914055440.3121004-1-jiang.wang@bytedance.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patchset implements support of SOCK_DGRAM for virtio transport. Datagram sockets are connectionless and unreliable. To avoid unfair contention with stream and other sockets, add two more virtqueues and a new feature bit to indicate if those two new queues exist or not. Dgram does not use the existing credit update mechanism for stream sockets. When sending from the guest/driver, sending packets synchronously, so the sender will get an error when the virtqueue is full. When sending from the host/device, send packets asynchronously because the descriptor memory belongs to the corresponding QEMU process. The virtio spec patch is here: https://www.mail-archive.com/virtualization@lists.linux-foundation.org/msg47457.html For those who prefer git repo, here is the link for the linux kernel： https://github.com/Jiang1155/linux/tree/vsock-dgram-v2 qemu patch link: https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg03462.html To do: 1. use skb when receiving packets 2. support multiple transport 3. support mergeable rx buffer 4. support disabling F_STREAM feature bit v1 -> v2 : - fix migration bug in vhost-vsock - rename some variables - clean up some code in virtio-vsock - use le_to_cpu16 in virtio-vsock Jiang Wang (5): virtio/vsock: add VIRTIO_VSOCK_F_DGRAM feature bit virtio/vsock: add support for virtio datagram vhost/vsock: add support for vhost dgram. vsock_test: add tests for vsock dgram virtio/vsock: add sysfs for rx buf len for dgram drivers/vhost/vsock.c | 220 +++++++-- include/linux/virtio_vsock.h | 9 + include/net/af_vsock.h | 1 + .../events/vsock_virtio_transport_common.h | 2 + include/uapi/linux/virtio_vsock.h | 3 + net/vmw_vsock/af_vsock.c | 12 + net/vmw_vsock/virtio_transport.c | 463 +++++++++++++++--- net/vmw_vsock/virtio_transport_common.c | 181 ++++++- tools/testing/vsock/util.c | 105 ++++ tools/testing/vsock/util.h | 4 + tools/testing/vsock/vsock_test.c | 195 ++++++++ 11 files changed, 1083 insertions(+), 112 deletions(-)