From patchwork Fri Aug 27 00:44:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mat Martineau X-Patchwork-Id: 504026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5EF9C43214 for ; Fri, 27 Aug 2021 00:45:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7F1A60F5B for ; Fri, 27 Aug 2021 00:45:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243897AbhH0Ap4 (ORCPT ); Thu, 26 Aug 2021 20:45:56 -0400 Received: from mga17.intel.com ([192.55.52.151]:40465 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243879AbhH0Apw (ORCPT ); Thu, 26 Aug 2021 20:45:52 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10088"; a="198108895" X-IronPort-AV: E=Sophos;i="5.84,354,1620716400"; d="scan'208";a="198108895" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2021 17:45:00 -0700 X-IronPort-AV: E=Sophos;i="5.84,354,1620716400"; d="scan'208";a="599007122" Received: from mjmartin-desk2.amr.corp.intel.com (HELO mjmartin-desk2.intel.com) ([10.209.68.199]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2021 17:45:00 -0700 From: Mat Martineau To: netdev@vger.kernel.org Cc: Mat Martineau , davem@davemloft.net, kuba@kernel.org, matthieu.baerts@tessares.net, mptcp@lists.linux.dev, pabeni@redhat.com Subject: [PATCH net-next 0/5] mptcp: Optimize received options handling Date: Thu, 26 Aug 2021 17:44:49 -0700 Message-Id: <20210827004455.286754-1-mathew.j.martineau@linux.intel.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org These patches optimize received MPTCP option handling in terms of both storage and fewer conditionals to evaluate in common cases, and also add a couple of cleanup patches. Patches 1 and 5 do some cleanup in checksum option parsing and clarification of lock handling. Patches 2 and 3 rearrange struct mptcp_options_received to shrink it slightly and consolidate frequently used fields in the same cache line. Patch 4 optimizes incoming MPTCP option parsing to skip many extra comparisons in the common case where only a DSS option is present. Paolo Abeni (5): mptcp: do not set unconditionally csum_reqd on incoming opt mptcp: better binary layout for mptcp_options_received mptcp: consolidate in_opt sub-options fields in a bitmask mptcp: optimize the input options processing mptcp: make the locking tx schema more readable net/mptcp/options.c | 141 +++++++++++++++++++------------------------ net/mptcp/protocol.c | 14 +++-- net/mptcp/protocol.h | 36 ++++++----- net/mptcp/subflow.c | 40 ++++++------ 4 files changed, 112 insertions(+), 119 deletions(-) base-commit: deecae7d96843fceebae06445b3f4bf8cceca31a