mbox series

[net,v3,0/4] bnxt: Tx NAPI disabling resiliency improvements

Message ID 20210812214242.578039-1-kuba@kernel.org
Headers show
Series bnxt: Tx NAPI disabling resiliency improvements | expand

Message

Jakub Kicinski Aug. 12, 2021, 9:42 p.m. UTC 
A lockdep warning was triggered by netpoll because napi poll
was taking the xmit lock. Fix that and a couple more issues
noticed while reading the code.

Jakub Kicinski (4):
  bnxt: don't lock the tx queue from napi poll
  bnxt: disable napi before canceling DIM
  bnxt: make sure xmit_more + errors does not miss doorbells
  bnxt: count Tx drops

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 98 ++++++++++++++---------
 drivers/net/ethernet/broadcom/bnxt/bnxt.h |  1 +
 2 files changed, 62 insertions(+), 37 deletions(-)

Comments

Edwin Peer Aug. 12, 2021, 10:35 p.m. UTC | #1 
Reviewed-by: Edwin Peer <edwin.peer@broadcom.com>

Regards,
Edwin Peer

On Thu, Aug 12, 2021 at 2:42 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> A lockdep warning was triggered by netpoll because napi poll
> was taking the xmit lock. Fix that and a couple more issues
> noticed while reading the code.
>
> Jakub Kicinski (4):
>   bnxt: don't lock the tx queue from napi poll
>   bnxt: disable napi before canceling DIM
>   bnxt: make sure xmit_more + errors does not miss doorbells
>   bnxt: count Tx drops
>
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 98 ++++++++++++++---------
>  drivers/net/ethernet/broadcom/bnxt/bnxt.h |  1 +
>  2 files changed, 62 insertions(+), 37 deletions(-)
>
> --
> 2.31.1
>
Jakub Kicinski Aug. 13, 2021, 5:27 p.m. UTC | #2 
On Thu, 12 Aug 2021 15:07:53 -0700 Michael Chan wrote:
> On Thu, Aug 12, 2021 at 2:42 PM Jakub Kicinski <kuba@kernel.org> wrote:

> >

> > A lockdep warning was triggered by netpoll because napi poll

> > was taking the xmit lock. Fix that and a couple more issues

> > noticed while reading the code.  

> 

> Reviewed-by: Michael Chan <michael.chan@broadcom.com>


Applied, thanks!