From patchwork Tue Aug 3 17:25:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petko Manolov X-Patchwork-Id: 491342 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E46DC43214 for ; Tue, 3 Aug 2021 17:25:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18E5B60F70 for ; Tue, 3 Aug 2021 17:25:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237977AbhHCRZw (ORCPT ); Tue, 3 Aug 2021 13:25:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238181AbhHCRZv (ORCPT ); Tue, 3 Aug 2021 13:25:51 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD01FC06175F for ; Tue, 3 Aug 2021 10:25:38 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id z4so26160508wrv.11 for ; Tue, 03 Aug 2021 10:25:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fikxz6m7nLtIUxzcxfvtkYHHMgYkclWBOg9VXYihnPw=; b=hxgIQ280QUzCdlXWaO9fcAbU8qE15shqtnNoyLO/mA2kwayZNeLy7nkwJvP8lzdiM+ pEHLAv7vDR5UAvr5kgKTAIZXbt0nECepbb4lDo/oGz93HnNkm02FQ2bA3lh7yC9iY+kd sdkFjEeAV/O3jRIsM8ywkB8FOkw01sfrv0na4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fikxz6m7nLtIUxzcxfvtkYHHMgYkclWBOg9VXYihnPw=; b=ZlOQImay/L0QzO1QuItcqbNFC6V3J9vjDDF2iytf8Qq9/75RtryzTslmIXXA5ayBTq hY4Xjo6Gva0qloPVrC95xSwU6W+SuC+F8KNz5IHnR6A9kMWrBFUe32kCTov90NQbYVbl K0v3fCtV1c8rOddQLV6gS9OvCQY+fCHW1o1UtKlAJy5q7wkFaGqp02lpp+jD9CZLB7I7 92o0V0B8Kii9qAPvAFFnpz/Kp6Q2L4cUH7ppyBVPs0dt03eCSuMf2wSqvnDbdDcFQHDX dsc2VzzITOLnEXelGsJzFh25uYNwOgirBs+BxMX6ieYPsWxVM8L+WZxoz76LjCqdHuAR hAQA== X-Gm-Message-State: AOAM533PM2KPnfjR4Vp2jNUe0z1rJmmE7/C7stEEeiEmnJdj+wZ63SnK T1bWRLGgQaBAbHxOOzV1Mmg8XeUxQgytHg== X-Google-Smtp-Source: ABdhPJwhBubg85ICYXjME3WV8v9BP2tHzfYUtn/hU2vBpbqtcwoZyYM38A6CbIR66vTiP8XSrEziyA== X-Received: by 2002:adf:f2cd:: with SMTP id d13mr24243070wrp.315.1628011537181; Tue, 03 Aug 2021 10:25:37 -0700 (PDT) Received: from taos.k.g (lan.nucleusys.com. [92.247.61.126]) by smtp.gmail.com with ESMTPSA id e5sm18489190wrr.36.2021.08.03.10.25.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Aug 2021 10:25:36 -0700 (PDT) From: Petko Manolov To: netdev@vger.kernel.org Cc: paskripkin@gmail.com, davem@davemloft.net, gregkh@linuxfoundation.org, stable@vger.kernel.org, Petko Manolov Subject: [PATCH net v3 0/2] net: usb: pegasus: better error checking and DRIVER_VERSION removal Date: Tue, 3 Aug 2021 20:25:22 +0300 Message-Id: <20210803172524.6088-1-petko.manolov@konsulko.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Petko Manolov v3: Pavel Skripkin again: make sure -ETIMEDOUT is returned by __mii_op() on timeout condition; v2: Special thanks to Pavel Skripkin for the review and who caught a few bugs. setup_pegasus_II() would not print an erroneous message on the success path. v1: Add error checking for get_registers() and derivatives. If the usb transfer fail then just don't use the buffer where the legal data should have been returned. Remove DRIVER_VERSION per Greg KH request. Petko Manolov (2): Check the return value of get_geristers() and friends; Remove the changelog and DRIVER_VERSION. drivers/net/usb/pegasus.c | 138 +++++++++++++++++++++----------------- 1 file changed, 77 insertions(+), 61 deletions(-) Acked-by: Greg Kroah-Hartman