mbox series

[net,v3,0/2] net: usb: pegasus: better error checking and DRIVER_VERSION removal

Message ID 20210803172524.6088-1-petko.manolov@konsulko.com
Headers show
Series net: usb: pegasus: better error checking and DRIVER_VERSION removal | expand

Message

Petko Manolov Aug. 3, 2021, 5:25 p.m. UTC
From: Petko Manolov <petkan@nucleusys.com>

v3:

Pavel Skripkin again: make sure -ETIMEDOUT is returned by __mii_op() on timeout
condition;

v2:

Special thanks to Pavel Skripkin for the review and who caught a few bugs.
setup_pegasus_II() would not print an erroneous message on the success path.

v1:

Add error checking for get_registers() and derivatives.  If the usb transfer
fail then just don't use the buffer where the legal data should have been
returned.

Remove DRIVER_VERSION per Greg KH request.

Petko Manolov (2):
  Check the return value of get_geristers() and friends;
  Remove the changelog and DRIVER_VERSION.

 drivers/net/usb/pegasus.c | 138 +++++++++++++++++++++-----------------
 1 file changed, 77 insertions(+), 61 deletions(-)

Comments

Greg Kroah-Hartman Aug. 4, 2021, 6:19 a.m. UTC | #1
On Tue, Aug 03, 2021 at 08:25:24PM +0300, Petko Manolov wrote:
> From: Petko Manolov <petkan@nucleusys.com>

> 

> These are now deemed redundant.

> 

> Signed-off-by: Petko Manolov <petkan@nucleusys.com>

> ---

>  drivers/net/usb/pegasus.c | 30 ++----------------------------

>  1 file changed, 2 insertions(+), 28 deletions(-)


Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
patchwork-bot+netdevbpf@kernel.org Aug. 4, 2021, 9:50 a.m. UTC | #2
Hello:

This series was applied to netdev/net.git (refs/heads/master):

On Tue,  3 Aug 2021 20:25:22 +0300 you wrote:
> From: Petko Manolov <petkan@nucleusys.com>
> 
> v3:
> 
> Pavel Skripkin again: make sure -ETIMEDOUT is returned by __mii_op() on timeout
> condition;
> 
> [...]

Here is the summary with links:
  - [net,v3,1/2] net: usb: pegasus: Check the return value of get_geristers() and friends;
    https://git.kernel.org/netdev/net/c/8a160e2e9aeb
  - [net,v3,2/2] net: usb: pegasus: Remove the changelog and DRIVER_VERSION.
    https://git.kernel.org/netdev/net/c/bc65bacf239d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html