mbox series

[0/2] Fixes for KSZ DSA switch

Message ID 20210714191723.31294-1-LinoSanfilippo@gmx.de
Headers show
Series Fixes for KSZ DSA switch | expand

Message

Lino Sanfilippo July 14, 2021, 7:17 p.m. UTC 
These patches fix issues I encountered while using a KSZ9897 as a DSA
switch with a broadcom GENET network device as the DSA master device.

PATCH 1 fixes an invalid access to an SKB in case it is scattered.
PATCH 2 fixes incorrect hardware checksum calculation caused by the DSA
tag.

The patches have been tested with a KSZ9897 and apply against net-next.

Lino Sanfilippo (2):
  net: dsa: tag_ksz: linearize SKB before adding DSA tag
  net: dsa: tag_ksz: dont let the hardware process the layer 4 checksum

 net/dsa/tag_ksz.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)


base-commit: 5e437416ff66981d8154687cfdf7de50b1d82bfc

Comments

Florian Fainelli July 15, 2021, 11:23 p.m. UTC | #1 
On 7/14/21 12:17 PM, Lino Sanfilippo wrote:
> These patches fix issues I encountered while using a KSZ9897 as a DSA
> switch with a broadcom GENET network device as the DSA master device.
> 

Is this off the shelf hardware that can be interfaced to a Raspberry Pi
4 or is this a custom design that only you have access to?

> PATCH 1 fixes an invalid access to an SKB in case it is scattered.
> PATCH 2 fixes incorrect hardware checksum calculation caused by the DSA
> tag.
> 
> The patches have been tested with a KSZ9897 and apply against net-next.
> 
> Lino Sanfilippo (2):
>   net: dsa: tag_ksz: linearize SKB before adding DSA tag
>   net: dsa: tag_ksz: dont let the hardware process the layer 4 checksum
> 
>  net/dsa/tag_ksz.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> 
> base-commit: 5e437416ff66981d8154687cfdf7de50b1d82bfc
>
Lino Sanfilippo July 16, 2021, 8:49 a.m. UTC | #2 
Hi Florian,

> Gesendet: Freitag, 16. Juli 2021 um 01:23 Uhr
> Von: "Florian Fainelli" <f.fainelli@gmail.com>
> An: "Lino Sanfilippo" <LinoSanfilippo@gmx.de>, woojung.huh@microchip.com
> Cc: UNGLinuxDriver@microchip.com, andrew@lunn.ch, vivien.didelot@gmail.com, olteanv@gmail.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
> Betreff: Re: [PATCH 0/2] Fixes for KSZ DSA switch
>
> On 7/14/21 12:17 PM, Lino Sanfilippo wrote:
> > These patches fix issues I encountered while using a KSZ9897 as a DSA
> > switch with a broadcom GENET network device as the DSA master device.
> >
>
> Is this off the shelf hardware that can be interfaced to a Raspberry Pi
> 4 or is this a custom design that only you have access to?
>

The setup I use is a Raspberry Pi 4 connected to an EVB KSZ9897 from Microchip:

https://www.microchip.com/DevelopmentTools/ProductDetails/PartNO/EVB-KSZ9897-1

Best regards,
Lino