mbox series

[net-next,0/7] Cleanup for the bridge replay helpers

Message ID 20210625185321.626325-1-olteanv@gmail.com
Headers show
Series Cleanup for the bridge replay helpers | expand

Message

Vladimir Oltean June 25, 2021, 6:53 p.m. UTC 
This patch series brings some improvements to the logic added to the
bridge and DSA to handle LAG interfaces sandwiched between a bridge and
a DSA switch port.

        br0
        /  \
       /    \
     bond0  swp2
     /  \
    /    \
  swp0  swp1

In particular, it ensures that the switchdev object additions and
deletions are well balanced per physical port. This is important for
future work in the area of offloading local bridge FDB entries to
hardware in the context of DSA requesting a replay of those entries at
bridge join time (this will be submitted in a future patch series).
Due to some difficulty ensuring that the deletion of local FDB entries
pointing towards the bridge device itself is notified to switchdev in
time (before the switchdev port disconnects from the bridge), this is
potentially still not the final form in which the replay helpers will
exist. I'm thinking about moving from the pull mode (in which DSA
requests the replay) to a push mode (in which the bridge initiates the
replay). Nonetheless, these preliminary changes are needed either way.

The patch series also addresses some feedback from Nikolai which is long
overdue by now (sorry).

Switchdev driver maintainers were deliberately omitted due to the
trivial nature of the driver changes (just a function prototype).

Vladimir Oltean (7):
  net: bridge: include the is_local bit in br_fdb_replay
  net: ocelot: delete call to br_fdb_replay
  net: switchdev: add a context void pointer to struct
    switchdev_notifier_info
  net: bridge: ignore switchdev events for LAG ports which didn't
    request replay
  net: bridge: constify variables in the replay helpers
  net: bridge: allow the switchdev replay functions to be called for
    deletion
  net: dsa: replay a deletion of switchdev objects for ports leaving a
    bridged LAG

 .../ethernet/freescale/dpaa2/dpaa2-switch.c   |  2 +-
 .../marvell/prestera/prestera_switchdev.c     |  6 ++--
 .../mellanox/mlx5/core/en/rep/bridge.c        |  3 ++
 .../mellanox/mlxsw/spectrum_switchdev.c       |  6 ++--
 .../microchip/sparx5/sparx5_switchdev.c       |  2 +-
 drivers/net/ethernet/mscc/ocelot_net.c        | 29 +++++++++++-----
 drivers/net/ethernet/ti/am65-cpsw-switchdev.c |  6 ++--
 drivers/net/ethernet/ti/cpsw_switchdev.c      |  6 ++--
 include/linux/if_bridge.h                     | 30 ++++++++--------
 include/net/switchdev.h                       | 13 +++----
 net/bridge/br_fdb.c                           | 23 +++++++++----
 net/bridge/br_mdb.c                           | 23 +++++++++----
 net/bridge/br_stp.c                           |  4 +--
 net/bridge/br_vlan.c                          | 15 ++++++--
 net/dsa/port.c                                | 34 ++++++++++++++-----
 net/dsa/slave.c                               | 15 ++++++--
 net/switchdev/switchdev.c                     | 25 ++++++++------
 17 files changed, 157 insertions(+), 85 deletions(-)