| Message ID | 20210416022752.2814621-1-kuba@kernel.org |
|---|---|
| Headers | show |
| Series | ethtool: add uAPI for reading standard stats | expand |
On Fri, 16 Apr 2021 18:44:26 +0300 Ido Schimmel wrote: > On Thu, Apr 15, 2021 at 07:27:43PM -0700, Jakub Kicinski wrote: > > Continuing the effort of providing a unified access method > > to standard stats, and explicitly tying the definitions to > > the standards this series adds an API for general stats > > which do no fit into more targeted control APIs. > > > > There is nothing clever here, just a netlink API for dumping > > statistics defined by standards and RFCs which today end up > > in ethtool -S under infinite variations of names. > > > > This series adds basic IEEE stats (for PHY, MAC, Ctrl frames) > > and RMON stats. AFAICT other RFCs only duplicate the IEEE > > stats. > > > > This series does _not_ add a netlink API to read driver-defined > > stats. There seems to be little to gain from moving that part > > to netlink. > > > > The netlink message format is very simple, and aims to allow > > adding stats and groups with no changes to user tooling (which > > IIUC is expected for ethtool). > > > > On user space side we can re-use -S, and make it dump > > standard stats if --groups are defined. > > Jakub, do you have a link for the user space patches? I would like to > test it with mlxsw given you already patched it (thanks!). Done! > > $ ethtool -S eth0 --groups eth-phy eth-mac eth-ctrl rmon > > Given that you have now standardized these stats, do you plan to feed > them into some monitoring system? Yes and no, I'm only intending to replace the internal FB ethtool scraping script with these stats.. > For example, Prometheus has an ethtool > exporter [1] and now I see that support is also being added to > node_exporter [2] where it really belongs. They obviously mentioned [3] > the problem with lack of standardization: "There is also almost no > standardization, so if you use multiple network card vendors, you have > to examine the data closely to find out what is useful to you and set up > your alerts and dashboards accordingly." > > [1] https://github.com/Showmax/prometheus-ethtool-exporter > [2] https://github.com/prometheus/node_exporter/pull/1832 > [3] https://tech.showmax.com/2018/11/scraping-ethtool-data-into-prometheus/ Wow, are you working with those projects? We should probably let them know about the patches.
On Thu, Apr 15, 2021 at 07:27:50PM -0700, Jakub Kicinski wrote: > mlxsw has nicely grouped stats, add support for standard uAPI. > I'm guessing the register access part. Compile tested only. Jakub, wanted to let you know that it seems to be working. I'll review the patches tomorrow/Sunday, as it's already late here. Thanks! $ ./ethtool -S swp13 --groups eth-phy eth-mac rmon Standard stats for swp13: eth-phy-SymbolErrorDuringCarrier: 0 eth-mac-FramesTransmittedOK: 8 eth-mac-FramesReceivedOK: 8 eth-mac-FrameCheckSequenceErrors: 0 eth-mac-AlignmentErrors: 0 eth-mac-OctetsTransmittedOK: 928 eth-mac-OctetsReceivedOK: 848 eth-mac-MulticastFramesXmittedOK: 8 eth-mac-BroadcastFramesXmittedOK: 0 eth-mac-MulticastFramesReceivedOK: 8 eth-mac-BroadcastFramesReceivedOK: 0 eth-mac-InRangeLengthErrors: 0 eth-mac-OutOfRangeLengthField: 0 eth-mac-FrameTooLongErrors: 0 rmon-etherStatsUndersizePkts: 0 rmon-etherStatsOversizePkts: 0 rmon-etherStatsFragments: 0 rmon-rx-etherStatsPkts64Octets: 0 rmon-rx-etherStatsPkts65to127Octets: 6 rmon-rx-etherStatsPkts128to255Octets: 2 rmon-rx-etherStatsPkts256to511Octets: 0 rmon-rx-etherStatsPkts512to1023Octets: 0 rmon-rx-etherStatsPkts1024to1518Octets: 0 rmon-rx-etherStatsPkts1519to2047Octets: 0 rmon-rx-etherStatsPkts2048to4095Octets: 0 rmon-rx-etherStatsPkts4096to8191Octets: 0 rmon-rx-etherStatsPkts8192to10239Octets: 0
On Fri, Apr 16, 2021 at 09:08:16AM -0700, Jakub Kicinski wrote: > On Fri, 16 Apr 2021 18:44:26 +0300 Ido Schimmel wrote: > > Given that you have now standardized these stats, do you plan to feed > > them into some monitoring system? > > Yes and no, I'm only intending to replace the internal FB ethtool > scraping script with these stats.. Cool > > > For example, Prometheus has an ethtool > > exporter [1] and now I see that support is also being added to > > node_exporter [2] where it really belongs. They obviously mentioned [3] > > the problem with lack of standardization: "There is also almost no > > standardization, so if you use multiple network card vendors, you have > > to examine the data closely to find out what is useful to you and set up > > your alerts and dashboards accordingly." > > > > [1] https://github.com/Showmax/prometheus-ethtool-exporter > > [2] https://github.com/prometheus/node_exporter/pull/1832 > > [3] https://tech.showmax.com/2018/11/scraping-ethtool-data-into-prometheus/ > > Wow, are you working with those projects? We should probably let them > know about the patches. I'm mostly a user, not a contributor (wrote some exporters of my own). I'll drop a comment there once your patches are in net-next.