From patchwork Sat Mar 20 14:17:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 405446 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp2212706jai; Sat, 20 Mar 2021 07:20:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJybWViTHleIUjrDz2pNzViDD511Rv/BaZjp8zMVtakrbrF8+L4bGXJTWK6u+dXVXm7ijJuM X-Received: by 2002:a17:906:a2d3:: with SMTP id by19mr9751810ejb.98.1616250013199; Sat, 20 Mar 2021 07:20:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616250013; cv=none; d=google.com; s=arc-20160816; b=wwBWSMoQ4OpaezVVkQvGWi0INVCqvjqp0OPIMuIhgqghbFHrG0qJGSiN4PJ7aLqP/w 2gYaM95xa4auzZ5wUzpeXKgNApVt698Cd58NDn8NXsT/j9zlrpfBOwBjBQUh+I50ZZLU j5a6SpojYCktCYUlcOzv0owyOvQnsDSQntV/mxjS/7rvo4m4wbTwudBDqawMP2nNUXs4 A0M5VNNvt7mYVi9uSjtV/t7dzKxGo2D2jXUY0tOOe9shPUCgu2w9DWdBFJXjaPyYJuLE bq0PDBdV2d5gVT+xOQ6C8CqawlYi989IxFP9EyVZl8uioe5/bmj5xBRR7+vX+8ZSctzg P/aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ieGGL6rIftmGUrUPP8WBA7EIeMeymcZEigdcphOIazQ=; b=w59gaRdve8hgNye9Lra6c9Hvo/nqbRgkfgLfFJHyCYSZ8kJGdb6ndPDwbuxx10FNrl Cck1RRw7ji4KkTBdlYnrym6sMUe4Y5IXJVdvIsPyh0TXIpMYcLBRLO0sY0a6EneIsp3y GMFSSurELrynvYb/GIH0VLxqvjnJtpSVBSRjC6o1Zu8eMnEJECWuXVECgsouHVumezJi CuiDY/Krz9y++nbRRwPJLUX8VDI5OuRq61IZJLXx21EKy1RVvAwmf4LhIPbSWotCYfSZ 7yiSAjI+yeyyhmx23UoXY8DgH4S4Qzy2hiUE9NZRLzdkd0b8BZeAjdJM4nXI2ZOscO1F Ca9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AyIlZKGP; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nc2si5215549ejc.165.2021.03.20.07.20.12; Sat, 20 Mar 2021 07:20:13 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AyIlZKGP; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229893AbhCTOR5 (ORCPT + 8 others); Sat, 20 Mar 2021 10:17:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229588AbhCTORe (ORCPT ); Sat, 20 Mar 2021 10:17:34 -0400 Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBDAFC061574 for ; Sat, 20 Mar 2021 07:17:33 -0700 (PDT) Received: by mail-io1-xd2e.google.com with SMTP id j26so9173821iog.13 for ; Sat, 20 Mar 2021 07:17:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ieGGL6rIftmGUrUPP8WBA7EIeMeymcZEigdcphOIazQ=; b=AyIlZKGPBW3eGyJxO0O0uPvBmrF4lKvqtgqSZQeDuly+wQsd8oojNcLxw1XvQfTcLG wJPiqhwweEVI3hl1BiTUfI7j+tmO5V9VXtG1N8JecVkXNifS7knjSX5lL88UKd86VRAQ aPQAEQ2ZNuACW0x4WZQNLQZTPL+p2x14plohxHe6gyDZVkRwofwCR1rJ4u4bM/iiSl8n /4AWuB4o8tyB4im3N1RQ+B6wZcV+KsoIg1eqrIPq65sksKLqs6dH/4gSFn0fhNQHiMFx xcSjmeDGrSepdnWGDDVwBkAoXx2fKMzdzRY5QOQpsLu+WTCJvHvopE7+rj3z1bV52+R5 EwtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ieGGL6rIftmGUrUPP8WBA7EIeMeymcZEigdcphOIazQ=; b=QdgUGJ9dexyXBoYVCJ9VMpfk1IQzoch6GKAwHGXGmXH+Z5BCHbY6UWXqOCPZ+udECp kn/fEuRqnVDQzTvYV6qTvAVBccbU8gw8Bl7ihyxT13xXHxPRu+sN6nj564JqspGgbCWx rhzt7bgMJ7LvhcrDJ6+LqugLQog2hHL7O1OIgsFgRRlAGrCM5KOrdJFHUMSMn3Dupvx9 aySNqtADCs0o8CZqsRGiYxkSE2Qzb1HXVxCd+NZ2IbZLZ3Q1jYiQrm6J9stvTrpx0+Z9 YbI6tqtifUBRvpb4v9MsKftUXV31WhNpcIa2mb8zYxZ+77alocfYcqa102DEmkXZd41b 07QA== X-Gm-Message-State: AOAM533rGpbD7esH0X6wOj3Hwa6mRGN4NPuAdBJVAu4ELEpPRrAHWd6N pxckocFhLH/AVFxTp+Cu7iPWlA== X-Received: by 2002:a5e:d61a:: with SMTP id w26mr6065331iom.40.1616249853034; Sat, 20 Mar 2021 07:17:33 -0700 (PDT) Received: from localhost.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id s16sm4273221ioe.44.2021.03.20.07.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Mar 2021 07:17:32 -0700 (PDT) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: leon@kernel.org, andrew@lunn.ch, bjorn.andersson@linaro.org, evgreen@chromium.org, cpratapa@codeaurora.org, subashab@codeaurora.org, elder@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 0/2] net: ipa: fix validation Date: Sat, 20 Mar 2021 09:17:27 -0500 Message-Id: <20210320141729.1956732-1-elder@linaro.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org There is sanity checking code in the IPA driver that's meant to be enabled only during development. This allows the driver to make certain assumptions, but not have to verify those assumptions are true at (operational) runtime. This code is built conditional on IPA_VALIDATION, set (if desired) inside the IPA makefile. Unfortunately, this validation code has some errors. First, there are some mismatched arguments supplied to some dev_err() calls in ipa_cmd_table_valid() and ipa_cmd_header_valid(), and these are exposed if validation is enabled. Second, the tag that enables this conditional code isn't used consistently (it's IPA_VALIDATE in some spots and IPA_VALIDATION in others). This series fixes those two problems with the conditional validation code. Version 2 removes the two patches that introduced ipa_assert(). It also modifies the description in the first patch so that it mentions the changes made to ipa_cmd_table_valid(). -Alex Alex Elder (2): net: ipa: fix init header command validation net: ipa: fix IPA validation drivers/net/ipa/Makefile | 2 +- drivers/net/ipa/gsi_trans.c | 8 ++--- drivers/net/ipa/ipa_cmd.c | 54 ++++++++++++++++++++++------------ drivers/net/ipa/ipa_cmd.h | 6 ++-- drivers/net/ipa/ipa_endpoint.c | 6 ++-- drivers/net/ipa/ipa_main.c | 6 ++-- drivers/net/ipa/ipa_mem.c | 6 ++-- drivers/net/ipa/ipa_table.c | 6 ++-- drivers/net/ipa/ipa_table.h | 6 ++-- 9 files changed, 58 insertions(+), 42 deletions(-) -- 2.27.0